From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76789EE6449 for ; Fri, 15 Sep 2023 08:47:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9339E6B025A; Fri, 15 Sep 2023 04:47:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E3E76B025B; Fri, 15 Sep 2023 04:47:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ABA66B025C; Fri, 15 Sep 2023 04:47:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6D2BA6B025A for ; Fri, 15 Sep 2023 04:47:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 38589160F57 for ; Fri, 15 Sep 2023 08:47:39 +0000 (UTC) X-FDA: 81238203438.29.208D3E4 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf04.hostedemail.com (Postfix) with ESMTP id B4B4240002 for ; Fri, 15 Sep 2023 08:47:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GLFzQdT0; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694767657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ldtjCWhn5cbHIMPW1zk7VmYyZJ2iO7oYLIHE3RYnz9I=; b=KzoU4uIsLkyIkf8w2B9nEN2rk0YZTpDKj+e5x+Hq1zD78mphRPOVg/tWnQZM/kmtGMlccF H1zDPhJmEYKwsa4oYmTvsqfmHxZjhxLzPmuK0WrX2iP6ApFaj5Ta5h9CfEUd/s/+jQS8WC icEZ1bIKGn38LLxnUOxhwlJNG2mzR4M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GLFzQdT0; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694767657; a=rsa-sha256; cv=none; b=zcYVbCIWFX++GNzHiMeYcdlWpr3nZcd6yVcH/7U1Awvaxov1wWrC1/WkrZK6BzW5R/SM/8 BF2mycgjC6HP8slbDOwEnwULfFryin7pbpJO7fvJrXj54dgSVgOAZAlzD4nKHqAp9rlHlY iqC1q2lDqTX+dfC1tKXbQFtScMAyDTE= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1c328b53aeaso16125675ad.2 for ; Fri, 15 Sep 2023 01:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694767654; x=1695372454; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ldtjCWhn5cbHIMPW1zk7VmYyZJ2iO7oYLIHE3RYnz9I=; b=GLFzQdT0SxR8LY4evwUaa6v1a/GiODNotlDiMEmy04yb9GgKou01ynDH/o0S2f67QO rv1WgUoqRLjY9929eDGwv6TA+4YtNRFFZg6ojinxKL88PAY2JwhtM6dnTWtnkQNBrCXM GCh6oTvMNIpd3iFp0woY8kgWgVGJwUNGy6+ZW4yM71nAydMPZfZO/vIQZk3QBw2zmYPq 90mNmISVuuIekZqpmDULxUBajEYc328y+Xw03vUJFaR7144553ZgHMmAuB/DtxM14kRq 0oasITpEUiTnRtz5SDioOsWKRaQSnJOoEPzu5aUlR6BHSH1E/+ZyEuiDTbZ21JxOQQdH caaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694767654; x=1695372454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ldtjCWhn5cbHIMPW1zk7VmYyZJ2iO7oYLIHE3RYnz9I=; b=r3eh+kHdC5l0RU/h26loPbU1qKfQCFscqX8Hf+po5j3l4gO+SNSfrCC/SU52eUv8Wq SazsDtRcvB/A8TogUo4YBMeY47nx4rkq/T5V6g55iBfEx6nurWM3M/dTSxHLXPL++nmk i+90F96ddKDbmf3docZp8C8YtSx3dcAvrRlKvQuZU1qmbvlYejDqbg/RkaOlbuJdPOEp zxFN9sTSaN34SpeCLS9q6xRSKdvTqR1Fa6G8ZQF0u1FMfR0FQidwYUfyTzjucmw3AeEm gSZ7n6bkXWQXuJhFysHs8DP7CFcZPgOs37GEQ+R7bjY+w+Q9JlIhHbEBcA05+Xaey/oR JYXA== X-Gm-Message-State: AOJu0YybbCoWPWw+GWqgyPqg2H7sKQLLEKDBU0gNBUr62oHSYd+Nl1z/ CDHGq5MnSgtkjinORfmZ7B88fg== X-Google-Smtp-Source: AGHT+IFwLxVHAWkalspdMHGEoI/dMr0rCuF/wfuyRQZl7VlakttPexcsCgvZYDr0fzlZrafT9Hx0ZA== X-Received: by 2002:a17:902:c191:b0:1bb:ce4a:5893 with SMTP id d17-20020a170902c19100b001bbce4a5893mr883577pld.30.1694767654337; Fri, 15 Sep 2023 01:47:34 -0700 (PDT) Received: from [10.84.152.163] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id x20-20020a170902ea9400b001bb28b9a40dsm2962631plb.11.2023.09.15.01.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 01:47:33 -0700 (PDT) Message-ID: <8d6bf3e9-5e44-cd83-bc49-c9dddd7b6b03@bytedance.com> Date: Fri, 15 Sep 2023 16:47:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: Re: [RFC PATCH net-next 0/3] sock: Be aware of memcg pressure on alloc To: Shakeel Butt Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Morton , Roman Gushchin , Michal Hocko , Johannes Weiner , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Breno Leitao , Alexander Mikhalitsyn , David Howells , Jason Xing , open list , "open list:NETWORKING [GENERAL]" , "open list:MEMORY MANAGEMENT" References: <20230901062141.51972-1-wuyun.abel@bytedance.com> <20230914212042.nnubjht3huiap3kk@google.com> Content-Language: en-US From: Abel Wu In-Reply-To: <20230914212042.nnubjht3huiap3kk@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B4B4240002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: g7h56wtqnjgfq7t6cmp539kzt6haydsb X-HE-Tag: 1694767655-834751 X-HE-Meta: U2FsdGVkX1+hQ/UInuMzXHuawuBHjkVF8EKvpCvwoxqLNF0b/1N/9m61iWHqV+UP9bldwG1L/FMnhPdGDXXGkR+9SVITMEihIeHqihvKKox+XJtIN2RI8cfgoxG6qE05AmkQCXZbqCr0rSBvXxh/GEvT2eQMuZPXZGtQdkeqN3jlgdwgbKQ5PKDbYKphXcCDSNAqPnq+Tw6ei6i0SMBg1PhFCHwj+V8thejjNZ5L/A1yg85U6moMDFDcsFdsUEkBBbwCNiuXJW2aBcO8qUJXimQDKAvERFGKdk2tasA+TPVPQW2YTdlsCXk7NJJO4RDEMcZLPuk0jUGi5L4TBFFlyy2L2QMrnpg7K9QesQyb6uh/t7/y4tmrnRQ8BPaWfzb9kus1IUwenh616x/RfxahniqU4Vidy8i50CniGzVEZuXSmC6I85tRS8/oaOdZLWZC9/mkN/QerAaIjGGHhq/rj2qlrxsqGOA7/Ypcz+l53ttzOopnTHUN8ZFwhyRY3+0Cqtr/YED+77wIL6HRr5u9N5u9tDXCVVgtgWdnhsfAVUZw5Ot0nBbhZUylDTVnJVB23quyIb4xfLK/+IlbA/1DFbYhuIIBRFGOjc13YV8osNEbbBNQdya7PeV7TOTJ+/WP7Sk0G3JJM90qNMFvqTQOA4tZxveWJeX9ht4+hLeaVG0dqnXaHaOFnUJ5hiTcvxbinY3zlK8jyWLNOnizUHmZXGXCZ7HGOQGkuo7qz4nfowzBWJxeYhRkIzEzOHLZHKPAi7M3jhZaHaqWTfKw53rwozwo7ksuNOQbhO3DusJ8JnJtq423URwOHICKhB7/c65YT1u1BPGfXbVatiK++AmB9zeZ7YGgFgEa7AxVawCqv3Qg3fAGDTcQ1Kv/WJyaVoB2wpkCWrMt9zGVYhtsinmgsH0OSMoNniPMgzzV5DZu5uYUNRzF6hEig8eTfnKu1gEf/q/sGRXo68OM0hN64o0 9cee87f1 2jnNmdBacM97ELDq5d6bq4DjXg9hdU6PPQCXSRtsEReB4TW9RC/QyYHF8h7mx0nGLQUQ7gTUyJkbGxkchDzlvdttrJYMPMOt5lZRWHt6YnXzuoxzVmjlQ09xewzu6q07NSBt4ob00aRgP4ePDgFMbkgwNbsfuF/KjM3yD+8wdForfzTIIaXfXIIgNbLUdi38H2CTE18w5AGN3i32ngQIESfyzffP/eWxyHkeJ2iThRtmuaYl/CcenXaLnWWH9vyfZHx8jE+coTOAsmr40odkxElxdV1dNnztf/2L0HagEowHbO1q6FAD1wj/MNeLmgJBwVJ64LXhkxexkpsuggnT7MhNkDN6B8seaItE8+YecmoCp2BbwOIGuYQRCs/UsRHoG4BbxlDjpJq82RYG9P+rUA8G1F7MR+VO5Xp1cNiGY4HF0T5MNA0+OSLOpmrFMzpLejVfcMyz6DXKmlxsHVdEQgID96LmvyQ9p/jYM7hMfIj3vqFkdnrxgplQpTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/15/23 5:20 AM, Shakeel Butt wrote: > On Fri, Sep 01, 2023 at 02:21:25PM +0800, Abel Wu wrote: >> > [...] >> As expected, no obvious performance gain or loss observed. As for the >> issue we encountered, this patchset provides better worst-case behavior >> that such OOM cases are reduced at some extent. While further fine- >> grained traffic control is what the workloads need to think about. >> > > I agree with the motivation but I don't agree with the solution (patch 2 > and 3). This is adding one more heuristic in the code which you yourself > described as helped to some extent. In addition adding more dependency > on vmpressure subsystem which is in weird state. Vmpressure is a cgroup > v1 feature which somehow networking subsystem is relying on for cgroup > v2 deployments. In addition vmpressure acts differently for workloads > with different memory types (mapped, mlocked, kernel memory). Indeed. > > Anyways, have you explored the BPF based approach. You can induce socket > pressure at the points you care about and define memory pressure however > your use-case cares for. You can define memory pressure using PSI or > vmpressure or maybe with MEMCG_HIGH events. What do you think? Yeah, this sounds much better. I will re-implement this patchset based on your suggestion. Thank you for helpful comments! Best, Abel