From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81190C433F5 for ; Thu, 24 Mar 2022 16:12:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEAF56B0071; Thu, 24 Mar 2022 12:12:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A456B0073; Thu, 24 Mar 2022 12:12:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEF006B0074; Thu, 24 Mar 2022 12:12:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id C10F66B0071 for ; Thu, 24 Mar 2022 12:12:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 995931639 for ; Thu, 24 Mar 2022 16:12:20 +0000 (UTC) X-FDA: 79279772040.11.DE5E6C8 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 2DF56C003D for ; Thu, 24 Mar 2022 16:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uAXtrFVTYFlU6SINGu8qFTFFnOjTtViqC7W/L6BqaRA=; b=d/lf48MGjvEI9H9UyYocV5dA/iS/aF8eez+XTeWigWwULvhO39isja8S1DTAE2QfZQaWzyiheEg6/zxuGGHnSvIdt0kD/U5zRw3SvrvV6kjCowtdM1eqXdl5OlsAOghZbuG/5DN4ZC+DRb6uq5sVZ8+Hht512kcyzxax6TDa2SM= Received: from DB8PR09CA0028.eurprd09.prod.outlook.com (2603:10a6:10:a0::41) by DBBPR08MB5945.eurprd08.prod.outlook.com (2603:10a6:10:1f7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Thu, 24 Mar 2022 16:12:14 +0000 Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::53) by DB8PR09CA0028.outlook.office365.com (2603:10a6:10:a0::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17 via Frontend Transport; Thu, 24 Mar 2022 16:12:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18 via Frontend Transport; Thu, 24 Mar 2022 16:12:13 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Thu, 24 Mar 2022 16:12:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 96b264b5c4ec880f X-CR-MTA-TID: 64aa7808 Received: from 87b5762759c3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2B5D140C-2826-4F41-9B9D-2E0056D27691.1; Thu, 24 Mar 2022 16:12:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 87b5762759c3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 24 Mar 2022 16:12:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OX9/bX17piThhMxyCMvVgJFKnF1zFeAVO7fYEEsRguCyPlWc6XUVnZr19pGoHB2PvlsWe6PR6y5eywmsP0xgqt+MsxP3NorMdWYk7aZvpKINyCGYYvPqZNsInIIn41Mn5gl1j968ubnwzJ/3TdgolNm/Gl9tA29Bb+dms/TZap5IyLhLRo5l94FKGOrweqyUCwMYQP9XmgKbakcuPvmFAq4hBkJC7tj6uD6jUdSi6CDCva1lrHCXY6YpFA07kU+MDDEh6rtPE/fQK62aCeLzKm0+3XwmD1ER6Nus+x/CzsNsyNhVj0fhRxyqfX254WgeR25ohacl5LLA6vpLzYM4PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uAXtrFVTYFlU6SINGu8qFTFFnOjTtViqC7W/L6BqaRA=; b=VaxHrrcNkEG5P3L711d0CZolSNrkiBTSQb76LymwsmJvTlpkFFjHI8zlGejYpboUrp2cltTw7dgtTKFMW8hD8hzAgGGT3VNp1cwfIBhe7u3Gm9qq0GQUKEqsTAjwiqLfiHA71Y2m2oV5oNxV7HfsVwbrCjLtwnmNNuQ8Aj976JFa7I3UO72rCCKzFr+haDIMHMhjkCYerHTHXNTsrfHHc8Y9s8iQVk/cFSAouhcx3Q5NyxkjC16TTb2ZzU3QWa4ycVFcupBOYV7xq6MMZUn1VV4Lx8ID4/nqMLiFVRBryk7z6Ei8rXuUolsVDieUups34xSPCFgf//LYX1q/z9EQ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uAXtrFVTYFlU6SINGu8qFTFFnOjTtViqC7W/L6BqaRA=; b=d/lf48MGjvEI9H9UyYocV5dA/iS/aF8eez+XTeWigWwULvhO39isja8S1DTAE2QfZQaWzyiheEg6/zxuGGHnSvIdt0kD/U5zRw3SvrvV6kjCowtdM1eqXdl5OlsAOghZbuG/5DN4ZC+DRb6uq5sVZ8+Hht512kcyzxax6TDa2SM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB7028.eurprd08.prod.outlook.com (2603:10a6:20b:34f::8) by DB9PR08MB6377.eurprd08.prod.outlook.com (2603:10a6:10:259::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Thu, 24 Mar 2022 16:12:01 +0000 Received: from AS8PR08MB7028.eurprd08.prod.outlook.com ([fe80::bc91:3925:e9dc:a851]) by AS8PR08MB7028.eurprd08.prod.outlook.com ([fe80::bc91:3925:e9dc:a851%8]) with mapi id 15.20.5102.017; Thu, 24 Mar 2022 16:12:01 +0000 Message-ID: <8d5f53c2-2e67-66e4-6453-946a62d5ee98@arm.com> Date: Thu, 24 Mar 2022 16:11:57 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness To: Peter Zijlstra Cc: linux-mm@kvack.org, David Hildenbrand , Anshuman Khandual , Catalin Marinas , Will Deacon , nd@arm.com References: <20220323165218.35499-1-steve.capper@arm.com> <20220324143331.GF8939@worktop.programming.kicks-ass.net> <2dbb5cf0-ce41-da93-9a3d-5666601f71c5@arm.com> <20220324155852.GI8939@worktop.programming.kicks-ass.net> From: Steve Capper In-Reply-To: <20220324155852.GI8939@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0357.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::20) To AS8PR08MB7028.eurprd08.prod.outlook.com (2603:10a6:20b:34f::8) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 399b9c43-aa43-4b46-5df0-08da0db10ed6 X-MS-TrafficTypeDiagnostic: DB9PR08MB6377:EE_|DB5EUR03FT062:EE_|DBBPR08MB5945:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DkNeXl1GOzPlfDxIoWsftqZudCd5nrOlucLWMT7TMcP6xOnily85/FNMmIl8t4me37UT+3TKmOwWnbUZ2S8Y0q3Rt9fvtE4l8WINsxsawcoi1JuggYxv9Ia2YSxrO7CZH41xFglWoXSzc1NCbikpAao2dCTXsmdAEGS98eh9QkUbicbsceVkr26Fx8QBDrS0gDD+p+nAfK5KfTzldDZDUeyXhnQ0crEB/2bYyyRSvLyjQCAaiLOAwNBFxkrw6wWQuKB2uj666mrpXXd92mxyCxtsmWkDvwM12sW9N4m+fIY8apP9FGA5nAyUuNHKxBjfqxmbSb9tx7Rom4FssKrkw2YoUqp6fJqWIj6olXcfIjQfr1C0lNz/4TCSiGKu89qT2zrUmaTI6W0K+9EavKjDYhWonfuoLamQWn6XUBRQ0ZESsg5GzDuzJP3Dlqw9I9BdAXT/mkklvkbtK15iXd+fsofRXtUPT869HtUZlCycrlEfCa4hSQc2Z/cERiUQHZJB6FGRVBFhOjbjML6FeMTq+Uyr9+YrrnvrxebaSvqypi6vNDbIkNkdWJjQBOSyM+8atD6eleQhKAYvkqgRGvyqan/9J2N1iTR0ZhHnrEZvqhb6fIXebonKsOMrDQTnFykISCtNH7sw6vUoJ38OAX6hjVY87MK8afPBT6PITHDM0th75VEt98S9XzVZMAwndZtP4M3qMYS/ernSdmAwrWGbcir5jLCRv0o6NZdfE6ABvh7W4fvwcSj82+M3HdEVDF0Z X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7028.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(508600001)(2616005)(8676002)(4326008)(66476007)(66946007)(186003)(26005)(66556008)(6506007)(6916009)(54906003)(6666004)(5660300002)(8936002)(53546011)(2906002)(316002)(6486002)(86362001)(44832011)(6512007)(31686004)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6377 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ac4060c7-012d-44ca-b045-08da0db1075c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UkU6uvS1XPjI+9syWJXkmF3IZoGPHywcF5rjYWgAn306BWmGm850gxuY8LCvU+SSzIx3b7yb0C89mwoJoQd2EFj4v6foel5ZZNFu4+eXB6x6qfUrJwqIN3mYGMF56ioRVdU/UBnXGxz5JhR9JDslmSl+afffhK7cgUxl7xifoCIVzssvtbmYGOz6fiYjJZCjbJYTZHOVw1bKRGaUEMRvWQUqJ1y2cje/+JBBXI3yBXe6nEHXzPXYPa5C26eSVAclEbD9uX4rNHsBIc3JcOllOPmnf4aGwYqOaEklXNo7tLjM9KFZv0RSaxJv53Qt/gXyB+bTcw+pIsILCMDliBzAzsYMfe1pyXYhYS/fRJyFwNBXfEeSLOfnyipvhqnVIeAx/wwH8apAnCbV6H+gDubPpBjdbBvhjGcumwuu4b85IjpW+i8m40e4GwjupkU74nnfsIXGrSByAEwgZyiMGX71xOwWOLGoM5rS37X6tNhzzcll702YGDwput7uUEuqd48VlGU3PazO6IRkXNj6EzuCKISEJluaYR3oHGEwxXnI3UhMsAMwyszJ1S1TTvf48d75vdA3BCNhbL9Uda/aFKDF7EKEPZxZcVJk0WaorTvE65YjGPtGPlNrQzxpwP86DAluE8cSVy0XW0ogE2AGyZVamFmAjEL6olSaabsmbaBUf0w1iXxu8W1t/W6zoIVQDuyUtsDsM7ML9YOe0xEwm9Jm4g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(6862004)(26005)(6666004)(8676002)(2616005)(53546011)(31686004)(186003)(4326008)(336012)(40460700003)(508600001)(356005)(6512007)(6486002)(54906003)(44832011)(5660300002)(47076005)(31696002)(316002)(86362001)(2906002)(6506007)(70586007)(81166007)(82310400004)(36756003)(70206006)(36860700001)(8936002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2022 16:12:13.5648 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 399b9c43-aa43-4b46-5df0-08da0db10ed6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5945 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b="d/lf48MG"; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b="d/lf48MG"; spf=pass (imf10.hostedemail.com: domain of Steve.Capper@arm.com designates 40.107.6.55 as permitted sender) smtp.mailfrom=Steve.Capper@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Stat-Signature: wtmch7utwti6ikgizz7898kyo8rjrnsc X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2DF56C003D X-HE-Tag: 1648138339-821610 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24/03/2022 15:58, Peter Zijlstra wrote: > On Thu, Mar 24, 2022 at 02:35:44PM +0000, Steve Capper wrote: >>> It occurs to me that perhaps this can be written like: >>> >>> unsigned long _sz = huge_page_size(h); >>> if (_sz >= P4D_SIZE) >>> tlb_flush_p4d_range(tlb, address, _sz); >>> else if (_sz >= PUD_SIZE) >>> tlb_flush_pud_range(tlb, address, _sz); >>> else if (_sz >= PMD_SIZE) >>> tlb_flush_pmd_range(tlb, address, _sz); >>> else >>> tlb_flush_pte_range(tlb, address, _sz); >>> __tlb_remove_tlb_entry(tlb, ptep, address); >>> >>> And then it can still be generic.. >> >> Thanks Peter, >> My concern with that would be the CONT_PMD_SIZE case would result in a call >> to tlb_flush_pte_range rather than tlb_flush_pmd_range causing some of the >> level parameters to be different. > > arch/arm64/include/asm/pgtable-hwdef.h:#define CONT_PMD_SIZE (CONT_PMDS * PMD_SIZE) > > Seems to imply CONT_PMD_SIZE >= PMD_SIZE, and would thus tickle: > >>> else if (_sz >= PMD_SIZE) >>> tlb_flush_pmd_range(tlb, address, _sz); > > Or am I confused? Nope, it was me who was confused :-). I misread one of the the lines sorry. Yeah this should be fine for arm64. Cheers, -- Steve