From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFE9C3DA64 for ; Thu, 1 Aug 2024 20:23:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 550A16B0082; Thu, 1 Aug 2024 16:23:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FF656B0083; Thu, 1 Aug 2024 16:23:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39FC56B0085; Thu, 1 Aug 2024 16:23:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 202556B0082 for ; Thu, 1 Aug 2024 16:23:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9E75D1609FD for ; Thu, 1 Aug 2024 20:23:49 +0000 (UTC) X-FDA: 82404802578.15.BD5FF4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 47A381C0010 for ; Thu, 1 Aug 2024 20:23:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OMtP2B+e; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722543785; a=rsa-sha256; cv=none; b=Kem3mlbF/JvjzkYN3Lm3jiiwz0F9UYAOT8KhWJ8lnA2zCS48xSIwyjM3+Cnl7ObBqq1Z0f 5RsiOEV0WNW48FfPYdAEfZnSuXa5JKkmRZ1t4iiEHtrMfwFSmgQ7+K9aYTtjoQzTHFfl+c oTu9zbMx2BUpiMcD0dhnzLQKWK3hjTQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OMtP2B+e; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722543785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LceHOKD/czLZDCNE7keMHLxgiWYU+BMQyASQdTk9Nxo=; b=zZfkM/UD91xAgjUjh/bvXGZ6KeXpTYXL1rThDY8WzVywbwAi8agVv15pTDal4XWndX5/SP o4+6VFebCRuDMuyM458YEdVUhv5QGfrtQYr1UMGzsQ3O5rtUWVsfdY3rDQM16GAR4aFnu9 sfOnQVMGrhBBQure3+QcAvUfjpDbMZ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722543826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LceHOKD/czLZDCNE7keMHLxgiWYU+BMQyASQdTk9Nxo=; b=OMtP2B+e2+/GHn31WnNAqxP376JWNmNFvWZ9mPcN1lYW0g9jkPt9GlGhBe+vRIoxIvDB4p JrKPSQWGMSTT2l2EXl0gEzMvuuHoOK9+22spqwDgMObn/mpHvSPYi2t771nXbTCzf8lseu IcNrGi0fUZAOmQytCctY701eP9Nt7j8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-8G_zUPGxOFSc1Rh1HuATKw-1; Thu, 01 Aug 2024 16:23:45 -0400 X-MC-Unique: 8G_zUPGxOFSc1Rh1HuATKw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42809eb7b99so14336335e9.0 for ; Thu, 01 Aug 2024 13:23:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722543824; x=1723148624; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LceHOKD/czLZDCNE7keMHLxgiWYU+BMQyASQdTk9Nxo=; b=CyRixFBg0xBNAQrJYH8+L5qMbxdkZYBh8wriX1+M+lmyfIHgGBCXXVbO6FN9eTXPia uRVsnrqLylXVi22748I65MXrtujg3fyaXBx6ZEI06rgCJCvXjbNPeXEP4ywKPvbNjd2J 8SGg+NCqa6bEMYzq5ISmdCRVD+ELmV7wyZmqQ+M2ezGVRcGwtyLi357MZhUsfAxAbEr7 K6buXA30FLRHTjzusgi02s1KIpiwpwx6OWbMob89ty87/SRLaO4k4qmpb3DjzsBrGpca OoNWtVEVtdJp37sZVtike++rIRFzeUIITXrE981w2RfW/f/LFZB3IuxPfM3nbdcOuUOr QKOA== X-Forwarded-Encrypted: i=1; AJvYcCUmjWhvV5pxtex4UKtAVTL5AxSpcoMYUkIBVRC/oAVSAkx1RAaI9CwctgEvsO+LTAVYfvjTc1u3gQ5y08Jg3xwIfI0= X-Gm-Message-State: AOJu0Yw5gs5PNlwfR1rjIxIsQD84Cg6emaXhd8AFp2WTsc73t3//xc1Q tUuwK/jiABgwKdOeS1gqQ4UhNLUmwJ/H2jYAh/DxYuYGUODwa7wFwO6MlSgpLhPc9zM2eIy52kN bCy9k9nuhLS0AOzO4ExqLYGn6b2pvRD6T7CpdljXPUfGC82Nv X-Received: by 2002:a05:600c:470d:b0:426:63bc:f031 with SMTP id 5b1f17b1804b1-428e69866admr9242215e9.1.1722543824275; Thu, 01 Aug 2024 13:23:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2ts+Zc1u2jZJ/PSuYb2wER98SDXfAAlyRq0mNUwCg6i6CACafXZLabL1vtB2iqFq88DUnOA== X-Received: by 2002:a05:600c:470d:b0:426:63bc:f031 with SMTP id 5b1f17b1804b1-428e69866admr9242095e9.1.1722543823716; Thu, 01 Aug 2024 13:23:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282bb98109sm66576225e9.39.2024.08.01.13.23.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 13:23:43 -0700 (PDT) Message-ID: <8d5cb85d-dd8c-4073-9bba-14f5c03aa49d@redhat.com> Date: Thu, 1 Aug 2024 22:23:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-5-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240725011647.1306045-5-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47A381C0010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: guw1t66uk6mpdewfs5x6mhcgid9j5zer X-HE-Tag: 1722543827-581113 X-HE-Meta: U2FsdGVkX1/Px0THsSAPcmsEPPHeL4KjONcU/fjOTdNplKD0ivSp26Vn+qAmrp6+y18G9nK2TrfltY5Ay18PM2jtG45BZPaeSKIesgkUgk8obJBrvrS1gBpQBHfzFNlRyNchgPFkk+sY2AlfNAmoza+7m+w1VJ4FBk3zOsQAZQwEWPexN0R3kGrAV3HwDyMDrO0s+N6n3xWRfZolR2xnY8vznPF2ccLxOc6+J7HYx2PdL7lh/2a+lH0WcgKz9jM0mXbVfYshULP8uOInids23Jg7SB0+1+DjMDfKWj+1HoRV6cT+CPsLu7MYni+Jn6f/nQjjWUlh085/8STeJa7EXupvJFMgdE2YsIefaZfHYo9j0P8kBv6PikIaiIGapuFY/v7k820urNRdpqXCwQzw4n5EkdvQhoDe4eVfKJI7YPv3k3vQ9Z1fR6p8vUR3GbH+iHZ0NaY9IhnsGyYG9IxNGnF4OgP47gBV2GcRC+aNk+QPX3Fcf8cU7SE0lpKWqyos6zEpcpfn5gUrQlPeidmjxysb9jfg5kYyHwVtbHVk3LJrvCQsJTAUmz+y9Csdd08OwSDp6LuCW5VPCFtOeWyuX1+IV8jQMmNtidcfiy00xmU6P9G5BW4vgkG0AW0S//+GTGJYAjeT7DMlJKNs4LzN2V+2hqtoJdGWFJ8PSugg7CvQw6NdsYXN2I9BHL3rz1vzn/afnpKXLaRgyVaOfZBibYlE5hiicmDsaLEW1q3HcY3nhRhh+Qn3lg55zi0RY6B2JWqTS+CAsY0bwULPglomD7fShXrP/vp4VrzKFT0vHN/ePhD0LArYvQ/itIP47J075q4JwPGsktMUSMzWdsV1YB1L56F7J096p4xcQ7b1EEeax81HEBiy/CwkrPFFG+i7BpcBIJBU9oO7bcbTfYEi6g3RB/jg7DSG+U8DMUTaxr2LdgJuL3Ry6M1T5uzJyoWBE804znVH4+7WzzX3lLJ 6IMZpI+6 kj+/SxKZbjx9gtCTSrw/TWTG3XuIp/s2gFwGrw3dddRSsjHof3Y7Q1DJ4EKiawC5cj0WfmQ7nj2kIZfSGfIYbqX3m2t/vZqo42ncEOa4okhNeo5dPNmyCjDhSoIulAtFDQB9e8mOLJ8WVfUw2FD8+4bOgOkYsu05qi2UYNDCVcINl6Zub9wsjN1GEZWKd/C6VFMdku7LxCPat4XybQnBh0u8MbEo97QlG5zGQ3HxOk3bDKTbc7oiV43Q8AfFCwqScZ0rgDgfpJKgAl11kAOZPtsGUfwDyaj7M7Si0VLPMHpQJCwuR4nFC+dxHdN9+am9/leSJUU8FFPb1lyshw4Nny5SPEUldm/AsIJFOcQZCJkkdBgavjjos7AuN0Z03c7JZGZV2anmiUjRLTVkv5mOUtdrVfA6JwDevaaiVWX0SrxyqlOfp0JWrb/YszJQq6HR7FYwQXsVz73/1VYiotDIYE1KUzPTeyDclciKm9o5vcpxCq1nfSl2iAlwLg9u1OHjBaAf9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.07.24 03:16, Kefeng Wang wrote: > Move isolate_hugetlb() after grab a reference, and use the > isolate_folio_to_list() to unify hugetlb/LRU/non-LRU folio > isolation, which cleanup code a bit and save a few calls to > compound_head(). > > Signed-off-by: Kefeng Wang > --- > mm/memory_hotplug.c | 48 +++++++++++++++------------------------------ > 1 file changed, 16 insertions(+), 32 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index ccaf4c480aed..057037766efa 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1773,20 +1773,17 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > { > unsigned long pfn; > - struct page *page, *head; > LIST_HEAD(source); > + struct folio *folio; > static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > > for (pfn = start_pfn; pfn < end_pfn; pfn++) { > - struct folio *folio; > - bool isolated; > + struct page *page; > > if (!pfn_valid(pfn)) > continue; > page = pfn_to_page(pfn); > - folio = page_folio(page); > - head = &folio->page; > > /* > * HWPoison pages have elevated reference counts so the migration would > @@ -1808,36 +1805,22 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > continue; > } > > - if (PageHuge(page)) { > - pfn = page_to_pfn(head) + compound_nr(head) - 1; > - isolate_hugetlb(folio, &source); > + folio = folio_get_nontail_page(page); > + if (!folio) > continue; There is one interesting case: 1 GiB hugetlb folios can span multiple memory blocks (e.g., 128 MiB). Offlining individual blocks must work. If you do the folio_get_nontail_page() we'd not be able to offline a memory block in the middle anymore, because we'd never try even isolating it. So likely we have to try getting the head page of a large folio instead (as a fallback if this fails?) and continue from there. In case of an free hugetlb tail page we would now iterate each individual page instead of simply jumping forward like the old code would have done. I think we want to maintain that behavior as well? > - } else if (PageTransHuge(page)) > - pfn = page_to_pfn(head) + thp_nr_pages(page) - 1; > - > - if (!get_page_unless_zero(page)) > - continue; > - /* > - * We can skip free pages. And we can deal with pages on > - * LRU and non-lru movable pages. > - */ > - if (PageLRU(page)) > - isolated = isolate_lru_page(page); > - else > - isolated = isolate_movable_page(page, ISOLATE_UNEVICTABLE); > - if (isolated) { > - list_add_tail(&page->lru, &source); > - if (!__PageMovable(page)) > - inc_node_page_state(page, NR_ISOLATED_ANON + > - page_is_file_lru(page)); > > - } else { > + /* Skip free folios, deal with hugetlb, LRU and non-lru movable folios. */ Can you clarify what "skip free folios" means? For free folios the folio_get_nontail_page() shouldn't have succeeded. Did you mean if the folio got freed in the meantime? > + if (!isolate_folio_to_list(folio, &source)) { > if (__ratelimit(&migrate_rs)) { > pr_warn("failed to isolate pfn %lx\n", pfn); > dump_page(page, "isolation failed"); > } > } -- Cheers, David / dhildenb