From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0815EC83038 for ; Wed, 2 Jul 2025 04:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58EDE6B00C5; Wed, 2 Jul 2025 00:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53F8E6B00C6; Wed, 2 Jul 2025 00:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 455186B00C8; Wed, 2 Jul 2025 00:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31A516B00C5 for ; Wed, 2 Jul 2025 00:13:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8F8411A06A7 for ; Wed, 2 Jul 2025 04:13:06 +0000 (UTC) X-FDA: 83618004372.19.60B7A27 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id D1BF810000B for ; Wed, 2 Jul 2025 04:13:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751429584; a=rsa-sha256; cv=none; b=J671avpDopZVRn8eMxMVuD4Qz8cThg7YrRjfcbjnxgyUF2cRpwHA0fgHOwe6wNtbIUePlq mCNVRgB0bl+LktMGik5ek9AMe/8sTUbrTVGWza5stoo3kp2JeVCNZM221SibZvoKQIBX7H AftQvMwQpI1qDygTvNq34bX+GlNNpOU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751429584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VJjABr2ZuazghLXfBOzEDYgWdRlN+3uwHRqJBtJybIc=; b=rabBkf3Y7sWLHv100WPEbyq18ZMtpdEXTF1TXXQM5CJQkVXsN8IK1nXFQOdVnt0btYBEAD T5Err5ILNory8N0WTX/pToVizX2vWSw0jczcjGwS+6IiZIxZaqEtSl5U6o2gCbZefXdC5H PvYBEis2fdpxolYaypNw6sJa07mU/rM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEF371595; Tue, 1 Jul 2025 21:12:48 -0700 (PDT) Received: from [10.163.88.114] (unknown [10.163.88.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7E0F13F58B; Tue, 1 Jul 2025 21:13:02 -0700 (PDT) Message-ID: <8d4aeea1-fff4-4e3a-a83f-67c429afa653@arm.com> Date: Wed, 2 Jul 2025 09:42:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: Use str_plural() in cma_declare_contiguous_multi() To: Thorsten Blum , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250630132318.41339-2-thorsten.blum@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250630132318.41339-2-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D1BF810000B X-Stat-Signature: 48utngcd6tdikfpaozakjdigtn88bxt3 X-Rspam-User: X-HE-Tag: 1751429584-452862 X-HE-Meta: U2FsdGVkX1+CLdEdUMnrlj7DLqlcZikDJf2Yz70+ZMJsi/2TMYqh8Q2/uEpTqzhby8zwWk4t/FVHV7RXWh4/g0mBn1UsErF6+qRggBOYgqUQ4mNLRoQgAq4e99FLbhgFoPhAsfk6EXLaxJXkhBZG+mpDEw1AI6xARYAG4Uh/moutQ0mwHJ4yPt5cqivIQ4tz3EgJgXRgYn1mZIc0US6LcWi2bnI3nNfZ9eEKxRicTF25huGJG1grRFTEK/k4lOh/m1aMS0iT1b9Ku0dBrH46cyU97EgxMCsW3HeRCPWrHjs/UBwSlbCnL7Jbi+kDToC5+1lIFhSZBKh3h5P2MAuRwhqG9CT8FY0SKNFXc0ZYzkpX5RUZxqqkQaSW+VMXwCLsmchW8RYTANFwB3uYFSlD3QHrSpti/2uJnB+dANq/SNoYPRBfB0gTf5md8BP1S4kth/g0mXvdKdn6BeZ0cDpzVufFk9+NGGbUOGFxjC5eO7E/UD3eEy8C+bgtDXGJT1qediQv72Ec6OWEyEpS0reS63/smzw6kCTrZoE+e97a1bwuEfrSkck4kHGLbR6sXuAHH2Cr2S0L5sKqXbVi+Q8MtMU8WS40CpPYiIyMsHB415uBBEjFtMxUlB7kWb/H0Pqjz1iS+GEmVGrJeYa6tdKAwikInZ7rt4GM0dwEyq58RoV0x73eJXpxYVTqxzgbXoz6SxOJ6HXnuqsxyRuK5FkGUriwQmWQTWRnq73qdLDT17TiLsKZ45fFMVp+25xMO9rDY6JzO3zS+5DTeZudu2XEHRkNU/xJOJmJ1k0MMR/ME/uLhvOjTq0lW7HB7JdClrgeCdb6yb6r7Ek2RvZ2zf1caieckEXKXNTYmZ4BTuixX5hYxsUdIgNHI2potblIViAwt129Fjfdw81wEGlMGCMuT+6MdTyJEls4Dd6Por8mh3YQlejHZbLaicqgWG+Ke12JlPBI1IP1Q+PDvPGNfUv JUbcY3my hRj0i+VBw9dXSxoczQeekKN5MZ0RAcqkQ0ASnbUs1JyGfLuJWoycuZVj8nhQesObQD2mO+RoIybKvWHyIzcakD83BULvEc1wn++n4ircYCob+I4NtomVfm3j3Cvv/6UecywXpxyKnNAc6DocsxshP89Wle2YhNaBLbiZVS1a18ZIXLlnrP2xIL+gYVS/Mk7IlBHikCaDKBrgDko6S7cq4qSmwPHuO8LyDHKHa76Zt1eGWIP7u4kqFYfoU18qe0DQQEHZVU8e7N0u3ziKDBZqRz+/qwDwiisyx+v4pg+kzfjZ6Nr7SxylVqKQAv1jMxdSsTxGC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30/06/25 6:53 PM, Thorsten Blum wrote: > Use the string choice helper function str_plural() to simplify the code > and to fix the following Coccinelle/coccicheck warning reported by > string_choices.cocci: > > opportunity for str_plural(nr) > > Signed-off-by: Thorsten Blum > --- > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index c0b2630a1b81..c40d53298801 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -548,8 +549,7 @@ int __init cma_declare_contiguous_multi(phys_addr_t total_size, > (unsigned long)total_size / SZ_1M); > else > pr_info("Reserved %lu MiB in %d range%s\n", > - (unsigned long)total_size / SZ_1M, nr, > - nr > 1 ? "s" : ""); > + (unsigned long)total_size / SZ_1M, nr, str_plural(nr)); > return ret; > } > Reviewed-by: Anshuman Khandual