From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C959C52D7C for ; Wed, 21 Aug 2024 11:28:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4AB16B00FD; Wed, 21 Aug 2024 07:28:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFAAF6B00FE; Wed, 21 Aug 2024 07:28:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4D2E6B00FF; Wed, 21 Aug 2024 07:28:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A50306B00FD for ; Wed, 21 Aug 2024 07:28:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 448D61A0BDC for ; Wed, 21 Aug 2024 11:28:16 +0000 (UTC) X-FDA: 82476028992.28.D49F402 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 120691A0005 for ; Wed, 21 Aug 2024 11:28:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hw+uAdib; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724239635; a=rsa-sha256; cv=none; b=vOPQbRIhITgW9bmepvroOnd70Rxx1YRu/JpgrYbWVHf2XF7PItUjLz9PwuuzWb63F3hNMa xwq5+ISsbWpwLx40J1OkNMDJvTMAWjVgh1aN2Pa5Jelb2Vh6P90BJh2ZKpNF6iAaHxydwU DC7lWWtUay69c86UhDzXsXZSdpCcUDc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hw+uAdib; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724239635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qne6Mfq7XN0PgJHnYPv+oM9l8Itj9wstRbNvLqM8lx4=; b=rA6GGj9+Bijp7NjEjoa7LxbtMOPbb++Qa5MFeED+DU1CKM78sCxHOzTXSODokUSE6EFcgV T6lgjEBcWRwf3HePXkr5Ra2BKNEyElZBgKMty5g8k9knAZoIrFlB+Q0EfEXthZGON95Fuy pYqngTiVBoB2hD3a61pI1DyRz4TaBVs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724239693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qne6Mfq7XN0PgJHnYPv+oM9l8Itj9wstRbNvLqM8lx4=; b=Hw+uAdibopC4GyyT1ij2rYD3yyqVwQmqC1h8qk9wxyKEgmi/MBF5EGf4w+qDNtvel+mMKG 38NEFMm9fsJGqhgBXXGwNSc83I3kPHHlOGmgB+Toj9ING5g+HRQne7PjDIorRqIvrpsBF8 xP5txqgUFEJtyZHH9ZwUm1W10/sBNVo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-39MBbHQFP4CFHrPGPNSu4A-1; Wed, 21 Aug 2024 07:28:12 -0400 X-MC-Unique: 39MBbHQFP4CFHrPGPNSu4A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-429e937ed39so55807045e9.1 for ; Wed, 21 Aug 2024 04:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724239691; x=1724844491; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qne6Mfq7XN0PgJHnYPv+oM9l8Itj9wstRbNvLqM8lx4=; b=DTdsJoq0QFgDS79iL3YDJHIvI/bncDgR4ArDqr38y0rwMr1qCI1y9lIh46S7hiAY8N RdFnlCbu216UmxBaGzl+K3Ea6sMXrlIJ4edfCznp/NpmCkWFcMYnqigRW3nOYx+bLtfj 0+ZT80WvX5Ty9NeQMvHPc0bsn+AVVkxjdcQR6/ICQzZUaLqiMcdn8Xb9WDOSqX3s6NRs V8oXpFZXAhrEUS3R+0ZMI/f0pAIYlcALw8jEYCHfGhCQnTdhUJl/RPQg5PG28X33kVHI kVFUW6CCLkziukjVSkjr3ps8oNzDGQ4axf2hjhRr14ikPgm8cqwuxDHGx5RZIQkuRtxG O/dg== X-Forwarded-Encrypted: i=1; AJvYcCXwOgmm3XhoVxnsyXEQpbY5sqWCN94LtzTNKVk/MQ+RJ+9mAiRk/4gi9Rtoix/bGvlFK4cVa39dEw==@kvack.org X-Gm-Message-State: AOJu0Yy5CcrNG5QLNJkoQB8oknOcUU9N+yNRtIIWS1ZUCpTQNbNo1loQ iPN0gTIzeb2afxtMpuGRT2qC+MQX/4TKX+TubZS0ZbqiS6m1m7MGSJm/NhuBfNq+SVbMkhG2pzG 8uUx189WJhcoSW0q1k107IVjmcwox+ZfhLROsWeL1sm6aV+TcWExUADsWoG0= X-Received: by 2002:a05:600c:1986:b0:429:dc88:7e65 with SMTP id 5b1f17b1804b1-42abd21293cmr16440475e9.12.1724239690856; Wed, 21 Aug 2024 04:28:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmbgWpiWAbJrU2VCY8lzmx3OGuYsJIizApBkzPXMMf+CMDZqKbj7GqsitWq8P6PuZThQuA+Q== X-Received: by 2002:a05:600c:1986:b0:429:dc88:7e65 with SMTP id 5b1f17b1804b1-42abd21293cmr16440135e9.12.1724239690012; Wed, 21 Aug 2024 04:28:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4300:16d5:c5b:8388:a734? (p200300cbc705430016d50c5b8388a734.dip0.t-ipconnect.de. [2003:cb:c705:4300:16d5:c5b:8388:a734]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189897066sm15510040f8f.76.2024.08.21.04.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 04:28:09 -0700 (PDT) Message-ID: <8d40e74e-c68b-4f94-ae1e-42c4430d55e2@redhat.com> Date: Wed, 21 Aug 2024 13:28:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/page_poison: slightly optimize check_poison_mem() To: Zhen Lei , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240821075311.1953-1-thunder.leizhen@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240821075311.1953-1-thunder.leizhen@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 120691A0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3f45nrcuh9cfhmqtr3co5chmcid7csws X-HE-Tag: 1724239693-872394 X-HE-Meta: U2FsdGVkX18AC4Bb4AD2TsGPppqBhMLACnczYrNe/N0/eDFe6eK223gxJVQttXkNIanNfPNhTqv9jH8ZnrrVWajjz3GbmPDrW/idagftQtZV09NXAlBLGQL/zF6ECPKsWzWCFzvJynDrKh4kqyeaUkalYAMeVqOKNRW3Noz421qQ7BFmThSdCqhJzmZa5Ql+RJNonsOEh+xzxzR9vUGvyWlZKY3tdSXkIr6R8kNPbmT8KVMTwi4NClqXXBWdT+vDo56btk9BAFubvzma5J+fRhWQDyfRM2yh+UE+PcVC/IWfkFyoy8ceavH7GM+KnPfxdEnQEA1T8z/zAOGA1SsJ58arbbeQ4Bd2InNvJMySQzvhK3iB5ZFOyIpIUeWGB4g7wmtlBMkZZjBepdnhouYJTzzyNaWvLtUW9wCLuTep/ie7Rq8+7dHciEFDDLviT7aGTg1m9i3KY1JrqoSjNB2V+Jmp9PERt/Dnvr6IJdoXeI+o9xv2YCUxptrBkKLB7ginILeJz6QBvcwD5voKOUweWKtk8ds/vBI0YNBJ57EgMo8Vqst6qbONQnMQEkLjGPB74iDaGutJCfMsVo28/LonIaySnWusWT8Ax7lt3FLQTJ77G+O7UTvj1b5l5V/Nrc/BezapE+av7C7vifCgz65bEmZgLOiRG+bkvZKdcrMQnd0Zzoyn2aXKABee8igFGRzVywJt1hkblfcPucS5XmqvH3a1EROZapgSzSrX3dmtJh+SWZwJr8IfPd/S1hlch8ST0OP7szan9gXykqROWFnm3uy02TGFSke2F52D94TbCn8zUcZ5uJU7ZbJz8M3l+HC2THlOmzHRr+P7oOSyJd/vVj+EXe3X1cMuMLxfKljaYgP8976++TR8NDbGqImq8AOdPNGzOIeQ9nLKG0LzVesxedTiPKO+X+PzFGhqzgHb1snqfWtNivJTilGIdQktNSuVeKJd33xXYGYLBMrq3dx f60qI5YT 15CGdzkjR99GqMLRB1s9VINS10uA2hIU0E84LpuAesMslWswron2yhuM+57lxXwIW75LRLVHsAYyaZXbACZkGd6mKwEROeJrO5mJ6yaeaKf+1Im5C96LOr+lusREwQh0NvJznjAStBZzexLLeJx9EAu4jER2dNELuHoffO4+CrkUpYYos+2ZitjW2pmc1FMpCt1hD5/MZqCNflkOfASCRqYkBmRRPhIGTsbZNcPa/P0ZeZrIkSrWNk8uUM8+vx4OhS0EiIW0IgR3JtTcG6aOzpATgBw9/e2NT5q4NC48+IcyjS03svhzaWOIFHC3rrkC1avJDtGkCQQxHC7Dr7HrDlgLLnPVklP3KrYbZDv3zA0ZTB9naAVMvlUzldE+EzpjNSl7ORgChdelYnZTN2aCDG+IRvnuJusxiJJSh3toHBUXLJ8bvmJg80QZcgmwUJsGHxNZv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.08.24 09:53, Zhen Lei wrote: > When the debug information needs to be suppressed due to ratelimit, > it is unnecessary to determine the end of the corrupted memory. > > Signed-off-by: Zhen Lei > --- > mm/page_poison.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/page_poison.c b/mm/page_poison.c > index 3e9037363cf9d85..23fa799214720f1 100644 > --- a/mm/page_poison.c > +++ b/mm/page_poison.c > @@ -55,14 +55,15 @@ static void check_poison_mem(struct page *page, unsigned char *mem, size_t bytes > if (!start) > return; > > + if (!__ratelimit(&ratelimit)) > + return; > + > for (end = mem + bytes - 1; end > start; end--) { > if (*end != PAGE_POISON) > break; > } > > - if (!__ratelimit(&ratelimit)) > - return; > - else if (start == end && single_bit_flip(*start, PAGE_POISON)) > + if (start == end && single_bit_flip(*start, PAGE_POISON)) > pr_err("pagealloc: single bit error\n"); > else > pr_err("pagealloc: memory corruption\n"); This way, you will be ratelimiting on every function call, possibly skipping PAGE_POISON checks even if there was no prior corruption detected? -- Cheers, David / dhildenb