From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 075C9C47DD9 for ; Wed, 28 Feb 2024 07:40:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 760016B02AA; Wed, 28 Feb 2024 02:40:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70B376B02AB; Wed, 28 Feb 2024 02:40:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AD8E6B02AC; Wed, 28 Feb 2024 02:40:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 478A66B02AA for ; Wed, 28 Feb 2024 02:40:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD44E1A0C6A for ; Wed, 28 Feb 2024 07:40:17 +0000 (UTC) X-FDA: 81840414474.01.200E408 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf20.hostedemail.com (Postfix) with ESMTP id 339221C0007 for ; Wed, 28 Feb 2024 07:40:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=OtWipHqM; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709106016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NVlJ77mhRzQ/mcmS2t+ED1kMM0vLY+HiiLyI/tdXrLI=; b=pYdXauw7NHcQSbJu4yYMWCj3n69d3HPgKEjzEq+LXd9IiF6GHCdgxJl6tzaf1zcTj0e0Rs TgSWTu5U0djzNOqeIisgdWHU/16l1M+pbrVKB7PJCrWt3lniarWa9Z2/4SaFyOSNvDQj1F /hhZVk1YbMdJMKK5aGtvVAp8eqYJXF4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=OtWipHqM; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709106016; a=rsa-sha256; cv=none; b=CkXCvb497y7acdVeIQuz0NpG0c4U8imNiQve0UkJiGN6S05j6XgeXbpHwjno/UFub5ldc+ RlMH+Yi6/fAeoezstvbl0C1wDQIMOU1bfRLlu6+6pKykFG3F+iVcnNK1HcOIV8eGTyLkiG fzSXzka+MG24qhkf4kZc5uNgnWJF1wc= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1709106011; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=NVlJ77mhRzQ/mcmS2t+ED1kMM0vLY+HiiLyI/tdXrLI=; b=OtWipHqMjpw1KQJy3FnZG0JFTvTfTYdOJtxcFhZBm8qGAoMsGWbjgyZxkthTzrhRHJMD/vcOCQzpuFCn8FUPajV5jY5Jki+kFdQvxplbMBON0GWlDhh35Xro4say4C+wfoGBgIuQg199GV9phmxxHJHEExvvFYaLPFfLszayQ00= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W1P0G-v_1709106008; Received: from 30.97.56.58(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W1P0G-v_1709106008) by smtp.aliyun-inc.com; Wed, 28 Feb 2024 15:40:09 +0800 Message-ID: <8d35b8ae-b8d8-4237-bfcf-ed63c0bb4223@linux.alibaba.com> Date: Wed, 28 Feb 2024 15:40:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: hugetlb: make the hugetlb migration strategy consistent To: Oscar Salvador Cc: akpm@linux-foundation.org, muchun.song@linux.dev, david@redhat.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 339221C0007 X-Rspam-User: X-Stat-Signature: idhbgqhozp75c7w1ky1u7megtq94b78k X-Rspamd-Server: rspam01 X-HE-Tag: 1709106014-181142 X-HE-Meta: U2FsdGVkX1/7ChCQ4poQVCzWOBUalBZa0w+VYqSe181q2DJG6xGsjgQEll9R/HkgY6rRoIlfkcoPMm7NNF6QsgcrtEf95KbYEvv2cJoJoaQDFjW9IoseLdcsunTsyOY/rY7Qt2+lSD4qli2eVP5rRNkI3Ox/4ck9z0EXhR+wjevJIUMWH91HJFED38Tleq+c7+MCsDxCGoBSLFEJ+/OUFfiMZCIMCR9aRBkv/fV+ZCsD9lK5Bnp7PGSK/wg4uKN29IpSLVK84/09u0gCihcA8l5CUzgIkcajQTQe3BYNzeNF2nFsq9D91QqpYSEy6v6tSVsE5lXGNSToX4Dddw5X0sRWIY/LqVpIgrkFrGc6yZO2+JFgO3DbMwY+nE8m7nA4sWCAk5YURRbM+rA2D/LOEeWlgzBOLWLLAIWz+zphbO+JvrbOCgMQAQdBGtTIrJecbBCUz0Trwd9TkYUyWnKVRZIxQJcexnU+z09VR/fKtRtRLZScwvHUMI+MUqyvG4H+GpdyaBKKxiBf/s4Ayr2syR/vFq84QyaOYmJrPW2HUyOEOkCaySb8+Dflx5qS16YKjFzQXlDJCXeIc661Uv77LQJHFn4hySb+7uMgC007AuIIl1RXr/FrsyqEZCPZU3vKhE/vp11nyvjfQQvKaSbO1j3tZP1ABTuJUBdJFjwXYK1p+TGocygdL8e2f1qp1awYlN/E1OcUa5g6JwPtcxtwsscuP2XeDzNTdT1AWQ2fUHDSNfW6KSJ6GBVZ2N78r8TP06N5s70JESiWWD7uJQIjn7ug8nKkc98omxXtAIne2fn9xt6pERBNHsuLkvDdDRKZWHuz8mpnU0wtfiF7mW07jcq90RA8Uv6FTRCbziq1QLlnOGxtE4ZAT667+8QVxYcMZQovU4mEeGpqLbtMzEUCJHe2zueOXxM8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/27 23:17, Oscar Salvador wrote: > On Tue, Feb 27, 2024 at 09:52:26PM +0800, Baolin Wang wrote: > >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -2567,13 +2567,38 @@ static struct folio *alloc_surplus_hugetlb_folio(struct hstate *h, >> } >> >> static struct folio *alloc_migrate_hugetlb_folio(struct hstate *h, gfp_t gfp_mask, >> - int nid, nodemask_t *nmask) >> + int nid, nodemask_t *nmask, int reason) > > I still dislike taking the reason argument this far, and I'd rather have > this as a boolean specifing whether we allow fallback on other nodes. > That would mean parsing the reason in alloc_migration_target(). > If we don't add a new helper e.g: gfp_allow_fallback(), we can just do > it right there an opencode it with a e.g: macro etc. > > Although doing it in an inline helper might help hiding these details. > > That's my take on this, but let's see what others have to say. Sure. I also expressed my preference for hiding these details within the hugetlb core as much as possible. Muchun, what do you think? Thanks.