From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FACC0015E for ; Thu, 13 Jul 2023 15:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCF416B00B1; Thu, 13 Jul 2023 11:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7F756B00B2; Thu, 13 Jul 2023 11:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6DE2900037; Thu, 13 Jul 2023 11:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B7D276B00B1 for ; Thu, 13 Jul 2023 11:36:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7A7081202E9 for ; Thu, 13 Jul 2023 15:36:23 +0000 (UTC) X-FDA: 81006990246.26.AEB7AC9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id A5B8A1C0024 for ; Thu, 13 Jul 2023 15:36:21 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689262581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8YQaB2jDVkCkEsLZTbTLFg0sKgcG4jxFxOS57utF+k=; b=675KsvONIZTy6WaYpp0o7leFmYEz7pqtiYyaViigMN/4khePRcR95jHdyckvcyY7few7tV qONuyQWD3Kbtl2hNXMdLDvTjqwG6ErTBaJ5Fubc5/VsyeVaPs3iaFWgOJvX6jf/Dy7xjJE TGA10Zh037kzreLZhczsKHsk1+PgaZA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689262581; a=rsa-sha256; cv=none; b=1t1LsYtSXldNU5fu/JAZMMAzwO8hUtu1GUbllsLhRXWVn6D5EN4GLPHr26VxIzCKhyeS28 iL08xUcuWSZGdyHxQVu0W7JUPpUulSfhkBdRub8kezsIi0vsChhsh2om8nav4E7/RDrjns UR7X+3GOeBsMzBB/6MrraKOOZq8vVnI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1FA231570; Thu, 13 Jul 2023 08:37:03 -0700 (PDT) Received: from [10.1.30.48] (C02Z41KALVDN.cambridge.arm.com [10.1.30.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3F0553F73F; Thu, 13 Jul 2023 08:36:19 -0700 (PDT) Message-ID: <8d2e75e7-0d38-6e6c-a02a-b66a18515dfb@arm.com> Date: Thu, 13 Jul 2023 16:36:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 9/9] selftests/mm: Run all tests from run_vmtests.sh To: Mark Brown Cc: David Hildenbrand , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , John Hubbard , Florent Revest , "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-10-ryan.roberts@arm.com> <2b586ba2-7522-a823-afd6-7b4d978f18c2@arm.com> <97742685-e026-417b-8c8f-938330027636@sirena.org.uk> From: Ryan Roberts In-Reply-To: <97742685-e026-417b-8c8f-938330027636@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: eaajr83mj1nicfr3rna74efh9htrsim3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A5B8A1C0024 X-HE-Tag: 1689262581-485533 X-HE-Meta: U2FsdGVkX19LnAxnWnDqWe16l0dEPBvPTAQDqOwFWhHtfCZ5kYiPF2P6DCKcNrVK3jQpUYAEa6hSeaSPQk/TcOF1vDhm2O+sEvp6kUVUq4B5LtvMmJtl9VkxgGxykjHlN//Ie2cgbbEFOWPszNnXMpqsoXfJK/PXdV2BAVimhgdXs3RsPxDhHe7aU6Rc4z0pOkgo7A2b8MkqNn8f9ha9k4rYix+u7IGGNpGGikEvBOq7PHf78H00DQVE8IKAB6pKcAQFqDjitGNXhJ+1g9Z9H3FzDOBE9UB8fvuLQnPkBaMdNxZPeFT7b/K/bsgkXYw61uswTzSV+o1BTVNUr0chjdjdqyqv4f0IobNjdhCSQiCPVtQYGjXs2HJu+6DZ7Is9zv+c5V9T5HScdBlJtyG5nyFIkiYSiFm6pz6FetVotxsyUqK1/2Hq0BCt9xUs++fx4nSHh25xcEQa0+3f0VAYquq9L0mxaHgGHtjZ3LgGL2vOnQwE8civD2MQUHjs9KVHWVTjsoq+/qiQyZot7kiC23M7av3gCdwbsy6uiVPXxKMxkXpkhdTNgJn3lzQrs6lBmDWygEciGXXRDKLR3JqeuyBhzcDQNaiUIMgdLK+itleMwHLMUQoUdBAv0O/VNSQolyNqrRsJV54rnJyiaA16a0Sb+nbiURcIp6wU0cn29wAFcuBSURh0vtlpjrJTH9vq9SI44stWQCuiXO5p+/vqjMz0h3jGNgDX71d3aWU5kWLoEbYrZHFtgyHgVdtZUF3nKxElkD0ToWAFVBRiGfl3kF4hioqZj9x+EfEcXGZJBicjj5iNJG62Torn4Z7p+zqZkCTfwoSvXDDz0wzW9GjE6lW9tkjS4s1w/lPuUMAFejMK6gJQWq5wVQp+Htx/YC2zb1JPrGuklC6C9c62q/sUDOqJNfiE6UF0/qiGcsEbuVXdhjUdOLknDdR+wZgFfm/LymRTYTT6/H77XJ6QTAR PHIzrZ5C Yok7VE9kFq7zN09tTqkcE0I650yIMoCddPJRaTN8y8zshL9W+vzfGyiTDATuEtIvBTrRS9OwsL/+OOcOmyJQMYSvP4VPbPs0Rp6aDqGTfEGqK86w8Cq86Ks+HvJb3ST8zq8y0ANe738VfGYwr96j+nYCsfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13/07/2023 16:30, Mark Brown wrote: > On Thu, Jul 13, 2023 at 04:04:44PM +0100, Ryan Roberts wrote: > >> So with this change at the kselftest level, there is a single test in its list; >> run_vmtests.sh. And all the other tests that were previously in that list are >> moved into run_vmtests.sh (if they weren't there already). > > The results parsers I'm aware of like the LAVA one will DTRT with nested > kselftests since that's required to pull see individual test cases run > by a single binary so it's the common case to see at least one level of > nesting. That's good to hear. But bear in mind that run_vmtests.sh does not use TAP. So you end up with a single top-level test who's result is reported with run_kselftest.sh's TAP output. Then you have a second level (run_vmtests.sh) using custom reporting, then _some_ of the tests invoked use TAP so you sometimes have TAP at level 3. But those tests at level 2 that don't do their own TAP output probably won't be parsed by LAVA? Since you agreed to put this into the CI, I was going to call this part "your problem" ;-)