From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1328CD2B921 for ; Tue, 5 Nov 2024 13:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A89D6B0096; Tue, 5 Nov 2024 08:08:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 358286B0098; Tue, 5 Nov 2024 08:08:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 247576B009A; Tue, 5 Nov 2024 08:08:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 046C26B0096 for ; Tue, 5 Nov 2024 08:08:54 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C3BCC1C767E for ; Tue, 5 Nov 2024 13:08:54 +0000 (UTC) X-FDA: 82752071052.02.F1C4C07 Received: from forward502a.mail.yandex.net (forward502a.mail.yandex.net [178.154.239.82]) by imf25.hostedemail.com (Postfix) with ESMTP id A3E2EA000B for ; Tue, 5 Nov 2024 13:08:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=yandex.ru header.s=mail header.b=cX7K70OG; spf=pass (imf25.hostedemail.com: domain of dmantipov@yandex.ru designates 178.154.239.82 as permitted sender) smtp.mailfrom=dmantipov@yandex.ru; dmarc=pass (policy=none) header.from=yandex.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730811967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4wyRHIkYbhqAEKZlXMvHtoPoEUJ6qmRUnxeCt98GNaM=; b=VPvDfQg//r4E9Nw2P12iYPL2ReMsX22USacNA6dEiCmsIlyYbxOtUQ5ekG5kpjytrdFRA5 M/MXai0ONaUHGI4Jkm2Ig5CbJcW/iYBLltLTit/YYOkjOlRPf/3zP9pBe6O+nxKACRAiSq YsyO9btZj1DLv+zzGLNddx3U9f3rKHM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=yandex.ru header.s=mail header.b=cX7K70OG; spf=pass (imf25.hostedemail.com: domain of dmantipov@yandex.ru designates 178.154.239.82 as permitted sender) smtp.mailfrom=dmantipov@yandex.ru; dmarc=pass (policy=none) header.from=yandex.ru ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730811967; a=rsa-sha256; cv=none; b=qPHWcoQa60kSi7nDfw0GM49Cal8BaWaU4de0rMfchuEi2qtjqWqIs3GzSdnokVLXMHw25C cDy7Uqn5C2mIbkk+bZKcpOf3ox3ksL63DRx1JCpmowUbnpF8RGY5wNraAMFm2/BIN6spNG qFsVfyMzDgh8WCQI3ZrNoJh5axxBeL0= Received: from mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0d:1611:0:640:6020:0]) by forward502a.mail.yandex.net (Yandex) with ESMTPS id 058A7614EA; Tue, 5 Nov 2024 16:08:50 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id l8g0BQVl54Y0-V6qE7Brb; Tue, 05 Nov 2024 16:08:49 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1730812129; bh=4wyRHIkYbhqAEKZlXMvHtoPoEUJ6qmRUnxeCt98GNaM=; h=In-Reply-To:To:From:Cc:Date:References:Subject:Message-ID; b=cX7K70OGzRamu2QeSblOnWZuQFzmpD5R+H5keC0IOXZ+T2lv/Y2Z8P1G39iNl9NXg 1WBvJcVweUjDWedC/zQxAgk3hb6Ldm3oq2TUV1HBWASfhNJHO+hXkLDxYXsfQ6wIO8 RvL09XZy8BCPQHZbnx/nLDcJ4tJ3W1VGl7It4T+c= Message-ID: <8d260125-ebd8-4862-bb00-41c2b76326bb@yandex.ru> Date: Tue, 5 Nov 2024 16:08:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] exec: do not pass invalid pointer to kfree() from free_bprm() To: Mateusz Guzik Cc: Tycho Andersen , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, lvc-project@linuxtesting.org, syzbot+03e1af5c332f7e0eb84b@syzkaller.appspotmail.com, vbabka@suse.cz References: <20241105111344.2532040-1-dmantipov@yandex.ru> Content-Language: en-MW From: Dmitry Antipov Autocrypt: addr=dmantipov@yandex.ru; keydata= xsDNBGBYjL8BDAC1iFIjCNMSvYkyi04ln+5sTl5TCU9O5Ot/kaKKCstLq3TZ1zwsyeqF7S/q vBVSmkWHQaj80BlT/1m7BnFECMNV0M72+cTGfrX8edesMSzv/id+M+oe0adUeA07bBc2Rq2V YD88b1WgIkACQZVFCo+y7zXY64cZnf+NnI3jCPRfCKOFVwtj4OfkGZfcDAVAtxZCaksBpTHA tf24ay2PmV6q/QN+3IS9ZbHBs6maC1BQe6clFmpGMTvINJ032oN0Lm5ZkpNN+Xcp9393W34y v3aYT/OuT9eCbOxmjgMcXuERCMok72uqdhM8zkZlV85LRdW/Vy99u9gnu8Bm9UZrKTL94erm 0A9LSI/6BLa1Qzvgwkyd2h1r6f2MVmy71/csplvaDTAqlF/4iA4TS0icC0iXDyD+Oh3EfvgP iEc0OAnNps/SrDWUdZbJpLtxDrSl/jXEvFW7KkW5nfYoXzjfrdb89/m7o1HozGr1ArnsMhQC Uo/HlX4pPHWqEAFKJ5HEa/0AEQEAAc0kRG1pdHJ5IEFudGlwb3YgPGRtYW50aXBvdkB5YW5k ZXgucnU+wsEJBBMBCAAzFiEEgi6CDXNWvLfa6d7RtgcLSrzur7cFAmYEXUsCGwMFCwkIBwIG FQgJCgsCBRYCAwEAAAoJELYHC0q87q+3ghQL/10U/CvLStTGIgjRmux9wiSmGtBa/dUHqsp1 W+HhGrxkGvLheJ7KHiva3qBT++ROHZxpIlwIU4g1s6y3bqXqLFMMmfH1A+Ldqg1qCBj4zYPG lzgMp2Fjc+hD1oC7k7xqxemrMPstYQKPmA9VZo4w3+97vvnwDNO7iX3r0QFRc9u19MW36wq8 6Yq/EPTWneEDaWFIVPDvrtIOwsLJ4Bu8v2l+ejPNsEslBQv8YFKnWZHaH3o+9ccAcgpkWFJg Ztj7u1NmXQF2HdTVvYd2SdzuJTh3Zwm/n6Sw1czxGepbuUbHdXTkMCpJzhYy18M9vvDtcx67 10qEpJbe228ltWvaLYfHfiJQ5FlwqNU7uWYTKfaE+6Qs0fmHbX2Wlm6/Mp3YYL711v28b+lp 9FzPDFqVPfVm78KyjW6PcdFsKu40GNFo8gFW9e8D9vwZPJsUniQhnsGF+zBKPeHi/Sb0DtBt enocJIyYt/eAY2hGOOvRLDZbGxtOKbARRwY4id6MO4EuSs7AzQRgWIzAAQwAyZj14kk+OmXz TpV9tkUqDGDseykicFMrEE9JTdSO7fiEE4Al86IPhITKRCrjsBdQ5QnmYXcnr3/9i2RFI0Q7 Evp0gD242jAJYgnCMXQXvWdfC55HyppWazwybDiyufW/CV3gmiiiJtUj3d8r8q6laXMOGky3 7sRlv1UvjGyjwOxY6hBpB2oXdbpssqFOAgEw66zL54pazMOQ6g1fWmvQhUh0TpKjJZRGF/si b/ifBFHA/RQfAlP/jCsgnX57EOP3ALNwQqdsd5Nm1vxPqDOtKgo7e0qx3sNyk05FFR+f9px6 eDbjE3dYfsicZd+aUOpa35EuOPXS0MC4b8SnTB6OW+pmEu/wNzWJ0vvvxX8afgPglUQELheY +/bH25DnwBnWdlp45DZlz/LdancQdiRuCU77hC4fnntk2aClJh7L9Mh4J3QpBp3dh+vHyESF dWo5idUSNmWoPwLSYQ/evKynzeODU/afzOrDnUBEyyyPTknDxvBQZLv0q3vT0UiqcaL7ABEB AAHCwPYEGAEIACAWIQSCLoINc1a8t9rp3tG2BwtKvO6vtwUCZgRdSwIbDAAKCRC2BwtKvO6v t9sFC/9Ga7SI4CaIqfkye1EF7q3pe+DOr4NsdsDxnPiQuG39XmpmJdgNI139TqroU5VD7dyy 24YjLTH6uo0+dcj0oeAk5HEY7LvzQ8re6q/omOi3V0NVhezdgJdiTgL0ednRxRRwNDpXc2Zg kg76mm52BoJXC7Kd/l5QrdV8Gq5WJbLA9Kf0pTr1QEf44bVR0bajW+0Lgyb7w4zmaIagrIdZ fwuYZWso3Ah/yl6v1//KP2ppnG0d9FGgO9iz576KQZjsMmQOM7KYAbkVPkZ3lyRJnukrW6jC bdrQgBsPubep/g9Ulhkn45krX5vMbP3wp1mJSuNrACQFbpJW3t0Da4DfAFyTttltVntr/ljX 5TXWnMCmaYHDS/lP20obHMHW1MCItEYSIn0c5DaAIfD+IWAg8gn7n5NwrMj0iBrIVHBa5mRp KkzhwiUObL7NO2cnjzTQgAVUGt0MSN2YfJwmSWjKH6uppQ7bo4Z+ZEOToeBsl6waJnjCL38v A/UwwXBRuvydGV0= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A3E2EA000B X-Stat-Signature: 78rjzi66u9butouw7i6a45zwoifdbu1s X-Rspam-User: X-HE-Tag: 1730812108-872243 X-HE-Meta: U2FsdGVkX19pRU0a7IYhHs3w80ZqadmE2KVB+N7z+H/KQEyky0Gp+BGK35+dLyz2J6JxXfdUR3KLL0qoef+pYP9FKhQh3MYZYyvcPvK9W/nJzy6C8AODxOlooQvfVCxEgYnCYjneZSWqvsNfANjC+6TkSI1juMd53nVUQtlcj+HhglB5TSI9O9yUyfg+DAgQ7PnQH1X2a1lMODBddC0gbMLFpsAFbE7f8qIaqMoT6UcjbYxM/hRUTqPuwM5a1rva5C7e+KdIoFa2U5LuSCcbDRBUdv/A4Fi76/3Hbo28EGoDlKYcr5xb7yxArJbbaOHxfXP1+7uImZ1W6pk2Y7SoUCeHz5DxwfrsdOnyyWdj0z0d2GBY/YXwLexgzdoOQU0s8M/ckfJybDqYao2PtBAqfOp047AOlNhi84lKx94nVPDfOgjgHkULExuVRiJrDO1Q12pL3/eWVL+D6pV15RSu/jCE2T8HP61AsMU6TCQqdLqsqodaW5MXQgzuzSWQN7XKLHz+lO71eJEtqN2gvskcURbStj+iZwg3FfxsfLkjUqjBIveSUNWZ74A9V3+ZUKU8oUSODO44FK3/hUq7ukFQDZO99ob4qZJVDvI6zHoOnUZ8hunWlWqAg7DeChMRrSe1qVH6q2aS9LzQX+Hi8Ol6xzj4+TvXLsr1UwUpqiLTuSkiaRiL+ngGRFFh8qwkgOrObRkZfBnXhFRR2IntQRwpCZf3fXrmZb4udZkExjbMgtbtc6OQP/ybivDj4EvOrTnjvXbGWZCax/nVA9PAlfSMlLFEtRjxIhl4DmfOrJ7h51x9egPuJI55csUVEN9yWcl0RkflWhb2iv/6rpD0Ob7xM/t2sb6AHcn6IGGK/9MwbQsNEiphgXZ4w68p7/eRmgqLqiBKcR4NWWfC6XT2WcjUTN6wk/YGYUAh6AKN3Ggi3QOUM76OG3X+YJuYhFkAhYQn4WzqiCSOel7WEsjBgfn YPY7b6Ms zZxikwHV9G70+vKCwoHz6wh3BotBuhnqnxabTLm7ahgM+Ba+uMwc0Sf4Yqj0onidwD6KnMCF8A0fOYjkFxVKuBkieVGQDiFYKlJYbsOr2Y/O07vIAm9mZDhJunl6Xg1wnf8z8LIwb58pIaAYIh/vhAdki3Lzim0BjTQ/YydJhEdS6H4LVeDYHFNu7IhMZGltDdhq3U+jWUGrVcvf7RKO900hTQM6PgQ83pqim4a6UrLfe976ZZdG2uuyUeHKU/V1QzyMNKCEUyhoWE8qQ8M3gmcjD1MZlWZWUajqPZX0MWMImxl/LDeNlBACPZkR3zgxqOZYRUDPAUP5nGVMv/7lV5GKQ7kbIfgnvdsNGxnxvdPPoXd803gXVKuSOiqhuI4HKjBjvD6QHknZDlCs4/FB/DioajGJSHaDT5zuUkvYBGwqnmkfN26VXrLwjEJB6+oDStuhizVVjkuwmkru6t1JMfi2N578A6+/8RWcPR1dbm81jOt4EWrwNstyZhAcQnzFhoJjWrF/K6lCQPC2qYgPiJT9PR6LWrTdDruUx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/5/24 2:30 PM, Mateusz Guzik wrote: > The specific instance aside, perhaps kfree could get patched up to > complain about it (when debug is enabled)? Yes, it may be useful to have WARN_ON() from kfree() for such a case when debugging. Dmitry