From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF1EC369A2 for ; Thu, 10 Apr 2025 06:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75AF46B00D3; Thu, 10 Apr 2025 02:34:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E98B6B00D4; Thu, 10 Apr 2025 02:34:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50DBD6B00D5; Thu, 10 Apr 2025 02:34:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 32ADA6B00D3 for ; Thu, 10 Apr 2025 02:34:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EEE841602C5 for ; Thu, 10 Apr 2025 06:34:47 +0000 (UTC) X-FDA: 83317171014.24.1191F06 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 9C84540002 for ; Thu, 10 Apr 2025 06:34:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744266886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Dx2RcHzq88Vo6OvOjCJrNpeRKdqhTGrdYNDZrKzW2A=; b=OSgG0I8GvZnaFI41uCJX5W8f2n4FFxIz0UgGduxFocNugeLymhm8v0l+H1vQFGzle+CYdN UU+QXN4h6nZsV4isFsbGX3IYGBu6t0TKmr+laGXwzjsUJOP8jZeK5qAvL1lUBw1ANkUBMN PAPj6re01WDqF9gOxv+fJFShhm7fQ7Y= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744266886; a=rsa-sha256; cv=none; b=EtJ4XmZWlz/h5Y/w7w+2WjmGLeWEwtSyOT/+wtnZP+TTiFA7Gr2VZbf+qXau8VSv6hMGSn DTrojcz8GvcxPleth7XZYQJoQsa9ZVntlwf1rX1LUWPq2TU1Fcuj5LgzpTfpAUeyCiyMDr X5wITS4nK0dKyfy1cnoBsIn+zjOEG3Y= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4ZY95S2m1Yz4f3jLm for ; Thu, 10 Apr 2025 14:34:20 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 6B6961A12C0 for ; Thu, 10 Apr 2025 14:34:38 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgA3nGBwZvdn20kuJA--.36687S2; Thu, 10 Apr 2025 14:34:38 +0800 (CST) Subject: Re: [linux-next:master 1753/1936] mm/swapfile.c:1517:20: warning: function 'swap_is_last_ref' is not needed and will not be emitted To: Andrew Morton , SeongJae Park Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Tim Chen , Baoquan He References: <20250408173959.f501f65ec5d5e52cefe6b129@linux-foundation.org> <20250409165452.305371-1-sj@kernel.org> <20250409174233.b3703db45767fbe5b9cd3b5b@linux-foundation.org> From: Kemeng Shi Message-ID: <8d237c70-5aac-924f-a8a3-31c6ef11a25e@huaweicloud.com> Date: Thu, 10 Apr 2025 14:34:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20250409174233.b3703db45767fbe5b9cd3b5b@linux-foundation.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgA3nGBwZvdn20kuJA--.36687S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYx7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7 xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40E FcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr 0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxv r21l42xK82IYc2Ij64vIr41l4c8EcI0Ec7CjxVAaw2AFwI0_JF0_Jw1l4I8I3I0E4IkC6x 0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2 zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF 4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU CwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIda VFxhVjvjDU0xZFpf9x07UWE__UUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9C84540002 X-Stat-Signature: mfyimsqk9udnnzm1gf8odnsuwtb6c6xf X-HE-Tag: 1744266883-459374 X-HE-Meta: U2FsdGVkX1/6H7KhVDwYEKfa4xYIw0xwjU41maJvY78JxeydsHjo5SdwUcH+7AmCI11zTXNL5F2f7DAk4KKBgP7/K86TNyMHkZzVcHGxCsBCxiIJZY8Ccm06Fc7Y5Pe2ZDg5oBCR+BRRRDyvNkP1wloGy87tN4c3ZNuK+TKpEE7G5TwtcOcEXG6s4puV7T5V/ugVIvx1+TvwMcsm7LjEIJQ5GI3WYSi3Ri2kCnu9mpGjJx4PQyv2SMlGj7srDORdbgpyr9Jfis6v5Odex5207WsyTCOqydr+1dg1yEhQZTx2x5kyjtaNGb59lH+kcVJE+WCYkjT3mMXS53yIIOjo4ss5XwhL2iIg0kOBMRaAXEmy/gmCVTMJKSxSUd5I3UMie1etS90O4E5VodqLMd/WepJ2YFBr3Y4jL7pAlXnprTdjRvfvnjzU2aRm11kwTSx7bfAbUgreAbO2beOdVlRrV5E8NkuJWamJbwZJm2xeachedLGa86gY2SSrd7ERjqjVZaoTIiAUVOYqTIwjn3hIWVWCBEg2im5ynGrec8OdFmx9rVUEo1MS9Tz4vcb57ugk6BYLFuEx/TMmdJ3F9kEnYtaSzRnr9kPIdtIszRFDfTAYQsvJ2uEXiNUZhXMgAA88/KlSRdBnhl8XOyxEV7Axujzh38H5rHmT9kkaLm3cM//TiPT2BjU2wTCvz6uw3Rc94B7pkIwXqfopbo8gxDiy5gkZ6fygWX8yJEqpDs4YxCN/j+pM6snFMHgCFnGTiMh4TKfl8cvLUsi5YZ9eu9vfhkRJ2kIZIx8w3nG06RGV1Y5tmbBZpqJ/oFOtxNJjq8kySuQNKZLbMpneH12j9rOFL/8aPSkjH95hyIsyGAwSy5MhzPjtn4H3rlV6Kl3gxh85/23Mg1KuHin/7bVlEqbJBfp4a8XDmIEmgunOFgW7OtV67XlI1UkIrrehE1WM9MBd86H+wY1Ah49S0Ud/YtG sCwDuRLR IOVmXtksM4luORaV8aU7fHwMVmL7eMnvDVnAg8R6FQfpnwAGg8mH8XEmI33ekOZBwGAT/X2mDCJoQd+T+Vz4oOH5a2793FskVySVDnZoTXvWh2TU0PMylur+gz4DbF4Sbg4nEBCRFnqIQbcmthtIs75AhZNvcdYOeDLo91I6f4h0FPr2mVPmmFpxVjxIxuq1Gpyz6KhSo0mFUFGCLSQiFoOMkNSCvMTSNQR8N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 4/10/2025 8:42 AM, Andrew Morton wrote: > On Wed, 9 Apr 2025 09:54:52 -0700 SeongJae Park wrote: > >>> I'll add this: >>> >> >> ... >> >> This makes my build fails when CONFIG_DEBUG_VM is unset as below. > > Uh, OK. I'll leave this to Kemeng to address, please. > Sure. Thanks to Baoquan and SeongJae for providing the solution and testing it. I will address build warning by adding __maybe_unused as Baoquan menthioned and update confusion comment before swap_is_last_ref(). Thanks, Kemeng