From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7107EC433FE for ; Mon, 30 May 2022 11:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E24DF6B0080; Mon, 30 May 2022 07:25:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFFBA6B0081; Mon, 30 May 2022 07:25:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9AB46B0082; Mon, 30 May 2022 07:25:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BAEFB6B0080 for ; Mon, 30 May 2022 07:25:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9712134701 for ; Mon, 30 May 2022 11:25:55 +0000 (UTC) X-FDA: 79522179870.30.0F23A8A Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf24.hostedemail.com (Postfix) with ESMTP id AFB79180032 for ; Mon, 30 May 2022 11:25:40 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id e4so11268664ljb.13 for ; Mon, 30 May 2022 04:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=gJ3rDFLPy4ULApkBUxHTk0EGt0vcK2KI8AydJnC3/9g=; b=qqG593hJBCUB/gBVGHwV+mSoLplrSbhyFYq3PDBSf9ltBe5cbhiDVTixDWLmpRgpSF iwnEYJ3CldnWOW++RbsHRj1dDdnf1ACIBj4U5pFXbGUTGG3PIfMCkkFZ4O9pmyMTQZdr +bkD/2gvyOgyI32Tq9RvL0Gk7HXu5G8aGokuVFTqDri1kgWoFxAnzbvNkMZGwJ7X0pC/ Vo4Yib/yG+2PfVpjYrCniWHVoDRH8VE4U4ratzu+Ki+d0mlBS/uoNAO/pkdhAlbDd9zT 0FEfj/BPuCe07LV8OQdVYc8sBe4VAlfFQn8tOtL08gUYChTRAO+LzL4aGvw7Uv/RDEi4 vNVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=gJ3rDFLPy4ULApkBUxHTk0EGt0vcK2KI8AydJnC3/9g=; b=rAnjXQdtxiScV48xgbHJ0Yd17Vf2gFq5gR6MNSaRZes+Y7z33pz/w73tXQjs95Ey1n S9DiR4trWHNw5/cewFKQFap/0kH92iXpdp3i5ayRpHRO0J5fJsRDdDuPlYl85G59U99K /lOyU4pfPxATQoc2GcRYRcZMqgUGnq3m/IkpZQ81i9y8niqiV91s1fBN+DEMKRBoT/V6 CpBhxa3j7QWXw1xiuVdUdtGkH111aefWxvpSKOywMMmFWUhYK36wCi6pg8LZBg99PcsM z1JnO2l2tDP9Kcnb3p5ZeMVL6ptT99idWLLkimPYreksYTr9YKb3ghM9WDnez+gGVJjG ihsQ== X-Gm-Message-State: AOAM531PhL3T+UZaX/ZZ3eRpPM1q0cItqQiUkkrp+cuaj1emBqhMSGUI cOQ1OFvxv90akfIl0x7tMwnfsA== X-Google-Smtp-Source: ABdhPJwmjz88tGcrOrlUOP44xp6aECdhqP3RDzmVcmv4VYqMwXbCOzQjYnYmz7JSR3oN8WHm8UMpkw== X-Received: by 2002:a2e:81cf:0:b0:253:bbe0:c047 with SMTP id s15-20020a2e81cf000000b00253bbe0c047mr33677010ljg.311.1653909953751; Mon, 30 May 2022 04:25:53 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id bq3-20020a056512150300b004787c77fcebsm2246335lfb.289.2022.05.30.04.25.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 04:25:53 -0700 (PDT) Message-ID: <8d20322e-928b-e995-bd5d-0695841c526f@openvz.org> Date: Mon, 30 May 2022 14:25:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v3 1/9] memcg: enable accounting for struct cgroup To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups@vger.kernel.org References: <06505918-3b8a-0ad5-5951-89ecb510138e@openvz.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AFB79180032 X-Stat-Signature: cohh1uhsrbx5wa5na6fpm9jwcig8nu1n X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=qqG593hJ; spf=pass (imf24.hostedemail.com: domain of vvs@openvz.org designates 209.85.208.175 as permitted sender) smtp.mailfrom=vvs@openvz.org; dmarc=pass (policy=none) header.from=openvz.org X-HE-Tag: 1653909940-820783 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Creating each new cgroup allocates 4Kb for struct cgroup. This is the largest memory allocation in this scenario and is epecially important for small VMs with 1-2 CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Accounting of this memory helps to avoid misuse inside memcg-limited containers. Signed-off-by: Vasily Averin Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt Reviewed-by: Muchun Song --- kernel/cgroup/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 1779ccddb734..1be0f81fe8e1 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5353,7 +5353,7 @@ static struct cgroup *cgroup_create(struct cgroup *parent, const char *name, /* allocate the cgroup and its ID, 0 is reserved for the root */ cgrp = kzalloc(struct_size(cgrp, ancestor_ids, (level + 1)), - GFP_KERNEL); + GFP_KERNEL_ACCOUNT); if (!cgrp) return ERR_PTR(-ENOMEM); -- 2.36.1