From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E3CC25B5F for ; Sat, 11 May 2024 09:51:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4445D6B0172; Sat, 11 May 2024 05:51:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CB1C6B0173; Sat, 11 May 2024 05:51:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293286B0174; Sat, 11 May 2024 05:51:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 09BC66B0172 for ; Sat, 11 May 2024 05:51:24 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4A3431409FA for ; Sat, 11 May 2024 09:51:23 +0000 (UTC) X-FDA: 82105647246.11.A2ADEA6 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by imf28.hostedemail.com (Postfix) with ESMTP id 1FC80C0013 for ; Sat, 11 May 2024 09:51:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=weissschuh.net header.s=mail header.b=k56XE3N3; spf=pass (imf28.hostedemail.com: domain of linux@weissschuh.net designates 159.69.126.157 as permitted sender) smtp.mailfrom=linux@weissschuh.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715421081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2O9BuJl8DeaatjYYLpBhN2fKSFlpNC2Rnp7OVw7gBRg=; b=NTuSGChulPSh5kcHM2K4roRvb64lUMsHnBu1ds7VdhqSLR4fTHpiDUibtn1faJ1OK1yIXx vmCW9Z58xYAjrc0zFRrWh/uHpkuJM8dVOydqpKnqYjTxBAFn55pO92nlKvodub00UYATRk 3FTd1y9LDJY8EqyU2gu2DKTeHIzFmbg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=weissschuh.net header.s=mail header.b=k56XE3N3; spf=pass (imf28.hostedemail.com: domain of linux@weissschuh.net designates 159.69.126.157 as permitted sender) smtp.mailfrom=linux@weissschuh.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715421081; a=rsa-sha256; cv=none; b=0WsqCd81CzNEVDfMMcuqPOWodvHn4FRPRSN9gF1+N/mvLaeiYOax47+o43hk2ofUzimk/7 qtJyu/w0PCuDxXdknDIsurqRZ4IBRmkUxiHRG3Cobn/SB1pDmtVb9sAJ5i8eWXDzw40/QJ lywKHrMuSyjAXbyqCd/BGQ1WIbBiwSE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1715421078; bh=0cJX+ofKilB0YeAddG2Rk34Tcb84daQhOHXhdzx0r3M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k56XE3N3d4pgs8RXOwLSnRLB27sLWUfITEgcvrDMjZdmJPa/Ir6S6oi9PpE553jPt sb7k+FxSLFp8Odclpb2t4vqVdgVnPhAwWUDBH9QwI80jAM7LA7gxjkMhJ80aDoR2yw DUA3ugAMpnt1Nr9pHpMHzjCRdAMZeTMxIBsCjZb8= Date: Sat, 11 May 2024 11:51:18 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Kees Cook Cc: Jakub Kicinski , Luis Chamberlain , Joel Granados , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <8d1daa64-3746-46a3-b696-127a70cdf7e7@t-8ch.de> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <202405080959.104A73A914@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202405080959.104A73A914@keescook> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1FC80C0013 X-Stat-Signature: ytyutrmsk6m4qpajpm13nds67obeqc9d X-Rspam-User: X-HE-Tag: 1715421080-128410 X-HE-Meta: U2FsdGVkX18Oc3kRCfTGecMkTuReAEQMsyZwJLVS1tL/0i2yo6acgiFSyzHx45vCTyF4aJYoH61OYwtns33AGZTc6iYv85n+/ZBCSgotwYaJW/xx3h/n1YhUDeTl/V2SSWsK+DFtUURV9KZ4RrPk3F52HtnsGcDTpf6HupKkhLkcTAcYuAPeS3wu74FeMugmvOHAVj4DkKUaU36PBCGNAMNb3jOWJt4PyQhUdOPQ+NxNqi0njBJ9R0/WY+9Ks4hbeuNn+VjjPaBHLn+s1wc0yVaDGhfs66/BajnnL35nGhY1ungf+yGpG9RK0Vl6gRKPdK0EUpLpCWug+J20FpSHJFPVKbeA5BuBmhkxQ6S3KKlkaBNbstcyOtESbu+VLQJ4PRoyxs06U/MQeXArnNNV/PMkedfr2xFDSinxP7bU3bGbRCCbxRWkeChC0XcK/Shhpuh3PRBeUrj7bKr45Ymzp8UA5wXRJmEsk6B8vK5KxrboTFvyFyklvB+C4Y0EWU/daXSJYBZ9BuSEnG9Mnzd/zT0x6aJNawdHwndxhWqlleA+NB1o+QQowdkacCQDg/MVe+7AxB5cHFWA1qcPSCdQKLtprVcCEIMs2MDnTBUbGna5OS5W/L6kw24Rs06mLyppcq7iGpYlIxh60ocm+oFjyQ6r4MlIgkxSzdZOfIh4I6cABKHgt3mtlrBgRvYXZ8bpZ1uvPk+TTNZg8fFml0rUlMIqVg6mfuVZgpEbg3K4HWlWSBost7Nlhj95YVUfMYNqQOmwapCzH8f99CTB3/hdwn3oarHrpaWS7nd92QweEI8SyNLAdhU07XyQSjMRkkVcZ8nIo7ge1xrovrQUUDUahqjsh41QLmmUTrVEPUivaMRjc8kKR2O5+G+y7NWfLYmfxMgauusTVxQX/Be7NAgUVlLhnvt3VltQcoaZF9BpUucQTweMCZMTx9iki/GRHrxfQ+V0clOXDF0e8pKuW1R NBZSfjNI KLAuF2+1cuKPyJMSSRLgB2Hr/sh1UZUUo8kOgZTfrPgSvwGD0Y7tOwaBnl+LYe2zYTc335pkKKxfxotSN85JwnkBczuhYjYO+D7DlxNkj+X+JGLE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kees, On 2024-05-08 10:11:35+0000, Kees Cook wrote: > On Wed, Apr 24, 2024 at 08:12:34PM -0700, Jakub Kicinski wrote: > > On Tue, 23 Apr 2024 09:54:35 +0200 Thomas Weißschuh wrote: > > > The series was split from my larger series sysctl-const series [0]. > > > It only focusses on the proc_handlers but is an important step to be > > > able to move all static definitions of ctl_table into .rodata. > > > > Split this per subsystem, please. > > I've done a few painful API transitions before, and I don't think the > complexity of these changes needs a per-subsystem constification pass. I > think this series is the right approach, but that patch 11 will need > coordination with Linus. We regularly do system-wide prototype changes > like this right at the end of the merge window before -rc1 comes out. That sounds good. > The requirements are pretty simple: it needs to be a obvious changes > (this certainly is) and as close to 100% mechanical as possible. I think > patch 11 easily qualifies. Linus should be able to run the same Coccinelle > script and get nearly the same results, etc. And all the other changes > need to have landed. This change also has no "silent failure" conditions: > anything mismatched will immediately stand out. Unfortunately coccinelle alone is not sufficient, as some helpers with different prototypes are called by handlers and themselves are calling handler and therefore need to change in the same commit. But if I add a diff for those on top of the coccinelle script to the changelog it should be obvious. > So, have patches 1-10 go via their respective subsystems, and once all > of those are in Linus's tree, send patch 11 as a stand-alone PR. Ack, I'll do that with the cover letter information requested by Joel. > (From patch 11, it looks like the seccomp read/write function changes > could be split out? I'll do that now...) Thanks! Thomas