From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3580C54749 for ; Wed, 28 Aug 2024 01:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 085036B0082; Tue, 27 Aug 2024 21:48:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 033CE6B0083; Tue, 27 Aug 2024 21:48:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3DF86B0085; Tue, 27 Aug 2024 21:48:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C65066B0082 for ; Tue, 27 Aug 2024 21:48:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 65D2A161AD5 for ; Wed, 28 Aug 2024 01:48:36 +0000 (UTC) X-FDA: 82499969832.16.4FE2EE1 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf02.hostedemail.com (Postfix) with ESMTP id 2B2F380006 for ; Wed, 28 Aug 2024 01:48:32 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724809626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G21QZqhIqooxOrBgyzs98eHZ+5a3dmlN7kbiJH98t5I=; b=iKrx1xfbZManPYco51EuWAi0MLyiAD2NkkUSmdBMYuUVa5X+ec7Qi4oBZc7IKOU7GZa9MF bfMyKID8y18KSPMrqU1o22vp4GTGSPRKNVBJ326csS/vzvyhCAqzjXN+VmQa0l7nrvkJJ7 8Qbl5lcioqHolJw5GWY7acUF551uwIo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724809626; a=rsa-sha256; cv=none; b=F2+CepQcJiA9Hlb+kOg2MvW9cV+WBMZ6pmH6uHQYy96CoRu9rlaCc63VYFYRGDsbKTmL1j LwqqqHWEA6alSXd1u0zfT21WUyxYTpOaI/ihFeBkqzaZ5eOV4ZjzwDHHsVyTGqC1aSdxzX kPRM2GqTnFvbyJUXiqGBBDUek6FOrHM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WtnMT3mLBzpTqg; Wed, 28 Aug 2024 09:46:45 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id F3DC414035E; Wed, 28 Aug 2024 09:48:26 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 09:48:21 +0800 Message-ID: <8d19aece-3a33-4667-8bcf-635a3a861d1d@huawei.com> Date: Wed, 28 Aug 2024 09:48:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v3 1/3] lib/string_choices: Add str_true_false()/str_false_true() helper Content-Language: en-US To: Andrew Morton CC: , , , , , , , References: <20240827024517.914100-1-lihongbo22@huawei.com> <20240827024517.914100-2-lihongbo22@huawei.com> <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> From: Hongbo Li In-Reply-To: <20240827164218.c45407bf2f2ef828975c1eff@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500022.china.huawei.com (7.185.36.66) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2B2F380006 X-Stat-Signature: 4nnm857y9r9f6qxqxxb748tgj3xacz85 X-HE-Tag: 1724809712-80230 X-HE-Meta: U2FsdGVkX1+UYBOezY8Col9H5Sgyxjb/9ev8EF6JelimmzymHIS0KF9d9fHBpN1xJKG+s03FL3xWMDTOKD667QTU/VVN0eJe21U+R72mTtLaWrR4Do+0xSXh/Pa2UQDSDDXoG9RqvznVEQw6CapHGaPjm+D3SgvLL3HdM8H2NreTFt5vipAAwhWVfDfAE6j4Ypzd1gfSNHkOMVo5g9kbrW/xPSC2mnGxDlLPMD9B/+cihU87k6/45ohcMySIz5XOJtdtuxAFUdCC92aMJpChQdO7LXi9fwmtquDXrK9ep5EKH+5arFdK9ra/P3csZ5mA9VFNQihkHUVAoTjAPh2FoTKq2S3Jh0K3EY5kR1BXeHJa5Aw4QyPGt+3OzpJkRq20jYdUe826Dnoex8Hd6sKa0ISHYHILUPP4lbhtubTd7SX4zPiF7y0v7Z5a/vtffn0lQSFkHIBDV+SDNhAsUTjE1pq9s8HHxwM9xebs0FN5weMcbEMVqC8m52qdR7FXDxpA1OEP4ZsD80AxFpkLZr9kC5UUzopQFlyu3wjPfxTsGJh/kKUsxb2ISSamfydToxI7mQWvmHEZEJ9NyWzV4+C3jNJBTtw7EwpJYJFJcW/4Oy3w8EK9r6I9qqosB9pnNhiczOnx2BqmRFoboc3/fsIWpwQ/pbdmyGvYDIHvNFJlHGXQE+N40ZRFEqSKIRonJMdmP3h7XObUBDcyyMh2LvTk9UYeZEa0XXWbKpBDEIsqZGeRosMVPXr/SZrttfgxS93DcZxVLRfjBSyAG7Enr0PjOl0VSuQ1NvI2sEZy7JRa/JnC2jUYUMXQf5ixhSZflQroGh2o633NVr6tiT01WPA1RXuRlles6SZods3Dguv4cuGB4Oer7TNHHnj4hU/NzUhEYe2ySaZbJ+iJbkbuwFQrFfVT6IRX0xEeqPUX6XIUcw20lv9LLRQh/2cv1FMeWVF48bsNzVoBzsCkf1fjNtV 3G7Cqf7L Fp+Ih4eg3hskqi5w2mPLyh8WP/cGWEv3OvH1O62QK17TLAzYYAxq3bDTCP5BJ4XxNDK+i2VrdYC8R8i+Xl/jowQc0/661HDcuKMzLd2+izKBwofagDofYlI7O2v21KrWNvCWAujOdS6Yfb/9IZbA2qXdd4qh5dCjxRccEu2CBZYef0lkwgMoygWT5Iot9irt6DdPLNGHovem6zyKg1Gxoo3uRAPYvVK9C3HrQPLar5kzC6rSGbmPgBdWajw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/28 7:42, Andrew Morton wrote: > On Tue, 27 Aug 2024 10:45:15 +0800 Hongbo Li wrote: > >> Add str_true_false()/str_false_true() helper to return "true" or >> "false" string literal. >> >> ... >> >> --- a/include/linux/string_choices.h >> +++ b/include/linux/string_choices.h >> @@ -48,6 +48,12 @@ static inline const char *str_up_down(bool v) >> } >> #define str_down_up(v) str_up_down(!(v)) >> >> +static inline const char *str_true_false(bool v) >> +{ >> + return v ? "true" : "false"; >> +} >> +#define str_false_true(v) str_true_false(!(v)) >> + >> /** >> * str_plural - Return the simple pluralization based on English counts >> * @num: Number used for deciding pluralization > > This might result in copies of the strings "true" and "false" being > generated for every .c file which uses this function, resulting in > unnecessary bloat. > > It's possible that the compiler/linker can eliminate this duplication. > If not, I suggest that every function in string_choices.h be uninlined. The inline function is in header file, it will cause code expansion. It should avoid the the copies of the strings. Thanks, Hongbo