From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1803CECAAA1 for ; Tue, 6 Sep 2022 04:29:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48D208024C; Tue, 6 Sep 2022 00:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43BBA80224; Tue, 6 Sep 2022 00:29:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3029A8024C; Tue, 6 Sep 2022 00:29:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1E86180224 for ; Tue, 6 Sep 2022 00:29:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DB7878043B for ; Tue, 6 Sep 2022 04:29:11 +0000 (UTC) X-FDA: 79880380902.02.EB2A20C Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf14.hostedemail.com (Postfix) with ESMTP id DCBBC100065 for ; Tue, 6 Sep 2022 04:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662438550; x=1693974550; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=63M0v4rYjUBbSUagId58PoYjjKjHQwRKlZW/9HSGqKw=; b=eJAthH6FJtuwd2Ke1hJchISTrHNp+q+2RYELzoJVIbTTzz7S1bscz+kr tlO6MipzGNIbmlAsC1JDEteuUL74nCeYRSqxioIQri9iFIxRZ3HBCP2eg PhpMBTHAqseK47BnS59w/guau08Ndgqn+jA1Z/W+da8b1t3+u/8sw3p1x fQ5YkMDyQBt47WRYRER2arBXgIjEeYgqvkLAtshoXaJOIG3Y44SMtNFyr K2lKid1Q2WuW/LVaFULM2zImqWMfmh8DIn52ZsSiWh+Lqod/xjpskkw03 ghtevwjT1xydaQUdMthh64gSawP/iFZnFY4qHH9GYzO4uePHUvaOaROlI w==; X-IronPort-AV: E=McAfee;i="6500,9779,10461"; a="360450416" X-IronPort-AV: E=Sophos;i="5.93,293,1654585200"; d="scan'208";a="360450416" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 21:29:00 -0700 X-IronPort-AV: E=Sophos;i="5.93,293,1654585200"; d="scan'208";a="675515848" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.254.208.188]) ([10.254.208.188]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 21:28:58 -0700 Subject: Re: [kbuild-all] Re: [linux-next:master 2262/4736] drivers/extcon/extcon-usbc-tusb320.c:19: warning: expecting prototype for drivers/extcon/extcon-tusb320.c(). Prototype was for TUSB320_REG8() instead To: Marek Vasut , kernel test robot Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Chanwoo Choi , =?UTF-8?Q?Alvin_=c5=a0ipraga?= References: <202209030755.eB4SkwGE-lkp@intel.com> <92d78ac2-c32a-cd19-891c-7bac77725b84@denx.de> <494af0d7-b07a-3d50-7539-09c300b79dd8@intel.com> <7f661266-757d-3913-851c-96559229e553@denx.de> From: "Chen, Rong A" Message-ID: <8d181fe6-0f3c-0a5b-4aaf-64d9d2e62943@intel.com> Date: Tue, 6 Sep 2022 12:28:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <7f661266-757d-3913-851c-96559229e553@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662438551; a=rsa-sha256; cv=none; b=uTDYav6XsstmyIUzf0is5Wtp3DSmNAjOWQU/vXvw4jlj1XHXBF7vHmiIFf382VjYfMUO3S IU2RKJVLHaC9AbkvT63+7s4glIFoHJTxdIa+BdCDxuZnb6SzqxD8+NHnduUZZpR6YpxxXE aR7Scch8s7vfQtZXkZ+FzLioAAYB1mo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=eJAthH6F; spf=softfail (imf14.hostedemail.com: 134.134.136.100 is neither permitted nor denied by domain of rong.a.chen@intel.com) smtp.mailfrom=rong.a.chen@intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662438551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N7oBTDNx/1tw1Ow4fHbHMXO9t+vT5ltyqdE6SMXHeag=; b=5iRsE31F0m8wE+XP68r3rCkOHSIrCEm5eiucf9X58nJu3AaPP0jhrEjlV3+n4IFSL/bGv1 faX/3K+1bQEv/IEJfzYQbiSabOY7kOD0h4bT8gyh8bq/A6EQbOh9FbVoV9mVyH75LS/aFE KwVfcbJKtsSWOYbZ7aqpvbYnLB+ZDQ8= X-Stat-Signature: miy6y3njnj13r4q3bmo46mz4xuorktt7 X-Rspamd-Queue-Id: DCBBC100065 Authentication-Results: imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=eJAthH6F; spf=softfail (imf14.hostedemail.com: 134.134.136.100 is neither permitted nor denied by domain of rong.a.chen@intel.com) smtp.mailfrom=rong.a.chen@intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1662438550-341793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/6/2022 8:53 AM, Marek Vasut wrote: > On 9/5/22 04:54, Chen, Rong A wrote: >> >> >> On 9/3/2022 10:31 PM, Marek Vasut wrote: >>> On 9/3/22 01:21, kernel test robot wrote: >>>> tree: >>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>>> master >>>> head:   e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 >>>> commit: 822a6200734c94ccbfc9ae7acc5da5505b991515 [2262/4736] extcon: >>>> usbc-tusb320: Add USB TYPE-C support >>>> config: x86_64-randconfig-a003 >>>> (https://download.01.org/0day-ci/archive/20220903/202209030755.eB4SkwGE-lkp@intel.com/config) >>>> >>>> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project >>>> f28c006a5895fc0e329fe15fead81e37457cb1d1) >>>> reproduce (this is a W=1 build): >>>>          wget >>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >>>> -O ~/bin/make.cross >>>>          chmod +x ~/bin/make.cross >>>>          # >>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=822a6200734c94ccbfc9ae7acc5da5505b991515 >>>> >>>>          git remote add linux-next >>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>>>          git fetch --no-tags linux-next master >>>>          git checkout 822a6200734c94ccbfc9ae7acc5da5505b991515 >>>>          # save the config file >>>>          mkdir build_dir && cp config build_dir/.config >>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >>>> W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/extcon/ >>>> >>>> If you fix the issue, kindly add following tag where applicable >>>> Reported-by: kernel test robot >>>> >>>> All warnings (new ones prefixed by >>): >>>> >>>>>> drivers/extcon/extcon-usbc-tusb320.c:19: warning: expecting >>>>>> prototype for drivers/extcon/extcon-tusb320.c(). Prototype was for >>>>>> TUSB320_REG8() instead >>>> >>>> >>>> vim +19 drivers/extcon/extcon-usbc-tusb320.c >>>> >>>>      18 >>>>    > 19    #define TUSB320_REG8                0x8 >>>>      20    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE    GENMASK(7, 6) >>>>      21    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_USB    0x0 >>>>      22    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_15A    0x1 >>>>      23    #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_30A    0x2 >>>>      24    #define TUSB320_REG8_CURRENT_MODE_DETECT    GENMASK(5, 4) >>>>      25    #define TUSB320_REG8_CURRENT_MODE_DETECT_DEF    0x0 >>>>      26    #define TUSB320_REG8_CURRENT_MODE_DETECT_MED    0x1 >>>>      27    #define TUSB320_REG8_CURRENT_MODE_DETECT_ACC    0x2 >>>>      28    #define TUSB320_REG8_CURRENT_MODE_DETECT_HI    0x3 >>>>      29    #define TUSB320_REG8_ACCESSORY_CONNECTED    GENMASK(3, 2) >>>>      30    #define TUSB320_REG8_ACCESSORY_CONNECTED_NONE    0x0 >>>>      31    #define TUSB320_REG8_ACCESSORY_CONNECTED_AUDIO    0x4 >>>>      32    #define TUSB320_REG8_ACCESSORY_CONNECTED_ACC    0x5 >>>>      33    #define TUSB320_REG8_ACCESSORY_CONNECTED_DEBUG    0x6 >>>>      34    #define TUSB320_REG8_ACTIVE_CABLE_DETECTION    BIT(0) >>>>      35 >>> >>> I still believe this is a false positive, is it not ? >> >> Hi Marek, >> >> Thanks for your reply, the issue is not introduced by this commit, it >> should be related to '/**' in the head of this file: >> >> diff --git a/drivers/extcon/extcon-usbc-tusb320.c >> b/drivers/extcon/extcon-usbc-tusb320.c >> index edb8c3f997c9..41041ff0fadb 100644 >> --- a/drivers/extcon/extcon-usbc-tusb320.c >> +++ b/drivers/extcon/extcon-usbc-tusb320.c >> @@ -1,5 +1,5 @@ >>   // SPDX-License-Identifier: GPL-2.0 >> -/** >> +/* >>    * drivers/extcon/extcon-tusb320.c - TUSB320 extcon driver >>    * >>    * Copyright (C) 2020 National Instruments Corporation > > Uh, OK, I wouldn't have thought of that based on the output above. > > The change above is obviously correct, can you submit a patch ? Hi Marek, Thanks for the review, I have submitted it: https://lore.kernel.org/lkml/20220906040430.35896-1-rong.a.chen@intel.com/T/#u Best Regards, Rong Chen > > Thanks ! > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org