From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49592ECE579 for ; Mon, 9 Sep 2024 17:11:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1FF86B00C2; Mon, 9 Sep 2024 13:11:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCF8B6B00CB; Mon, 9 Sep 2024 13:11:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B97326B00CC; Mon, 9 Sep 2024 13:11:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B29B6B00C2 for ; Mon, 9 Sep 2024 13:11:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 49A461C15BB for ; Mon, 9 Sep 2024 17:11:52 +0000 (UTC) X-FDA: 82545842064.19.9E77CE1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 696ED20011 for ; Mon, 9 Sep 2024 17:11:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a5gysSbS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725901797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sPmyMHMjUgK4J6uH/6k3HGCVCNeoH/3DSKZDu28dDeM=; b=QDu2s/EVBM2gKcU1lC/kE6T6uYtIFLLXV/UZbVBSKv+aXMzVwwEzU7jm1AtV7gsJpc4Xa0 iOPhV/XoLQa8GuCMpYupcs9Seb0jUUvfhUbDpWe0Qt6FdfzJJVvJ+RFRmfvgM6k87BBAVc rgB0FMg9vA8H4lnu2E5VNPSJSaN4aWY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725901797; a=rsa-sha256; cv=none; b=dYox5n3RCha7x1eqGRsFqtMTaY53hJWOwkgsDPcWvdxwUcvASULxZJZdYQgKCsTH+1XvsL 0MEYX8D7RkgoeiothwxNfq+a32uCnYhkt4GcI5PfHwtcCDaoVPOgSe5F/0TI+5njxPc/mv 2+MvyJmQJsmi+GW8NdniwyljCzHEhQk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a5gysSbS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725901909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPmyMHMjUgK4J6uH/6k3HGCVCNeoH/3DSKZDu28dDeM=; b=a5gysSbS9PoN1HVtXquMRkmiM7DArxjMj259MvAgwPXevEbXSAbvh8bY53wb08g1HUn8bI nlw97vj8iwlARBg71GL6hbI5bGJzWvt2RCnw42PuDmeIzN/NoVST5ly3bY0TZn1Z2wpcQ2 48RSI9qeHCuYUQerrsEQP5CJqbz3mR8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-ZqL4uUw_MMKYOfI5xKuowA-1; Mon, 09 Sep 2024 13:11:46 -0400 X-MC-Unique: ZqL4uUw_MMKYOfI5xKuowA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B98AC19560AE; Mon, 9 Sep 2024 17:11:43 +0000 (UTC) Received: from [10.2.16.126] (unknown [10.2.16.126]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CBEA81956048; Mon, 9 Sep 2024 17:11:40 +0000 (UTC) Message-ID: <8d1440af-bf06-43e9-b7c3-10b2ce8ce7d2@redhat.com> Date: Mon, 9 Sep 2024 13:11:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] cgroup: Do not report unavailable v1 controllers in /proc/cgroups To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Tejun Heo , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Chen Ridong References: <20240909163223.3693529-1-mkoutny@suse.com> <20240909163223.3693529-5-mkoutny@suse.com> Content-Language: en-US From: Waiman Long In-Reply-To: <20240909163223.3693529-5-mkoutny@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 696ED20011 X-Stat-Signature: cjeh3nny81g7dixqgzeuhowrxptz3me5 X-Rspam-User: X-HE-Tag: 1725901910-749919 X-HE-Meta: U2FsdGVkX19F8eZfTb8Yi3YunQO62qePQwz4KhGx0cSD6bfq4hvA1p2SyrqSwc0C51RAr7DawK+r9I3pJwb0mnNBm2N0lEPqQ6n+ZUoJh0Ab7HAVLf918aDoU2kFIFRTCmhVUg9FSPHnv5VEUuQ+2/Ia5UcmI5kqe1HkE2OGYgcjnvkDGiLaOI3WukTyPsjvmk5Gd6lFQJoGlaK1ZKXTGIdcELk8IjNOCWYDg+MgGAouexMPRfOdFfX1VZk66XvLmBj/acPDpn8PszXrxBdTNV4q3KYlWxWWR2gJqs1BkHZv3dTgIYeWZVsGVdJLNS7JhM9rSZkIW/immjN5dU50JnKM8fZC0ocPjgu/Sez4bOoGE4c0P7nnKqwo9KXIzcD7s/JgA6G2IkJc3w7hDfY2qBeyjMFaq/d4agJJ/pFvBe4ZnCZFY2ht6a/KiBiligdsaIKJbeH1fPWRnYCtWmKCJy5iqS8qnXG3MtLB+9L5GVwRT2Hgr+AQNJ/socjGoWCmpC1QHsLqjQ6bP2X8gvsigNtRXvfRd1Mc8FFlYcukSWteS/c8bNvqCA3teEvSzSDB4Szhw+OlKb061svvVcD7RpCtfOSl1ckHKecWtb/nmt0xXPw7xFM/gGF+hwaxbme1Pb0SOZ4pz6l5jd3MHnnbJiwwkZNgsk5NTtFNt4YIJvzkir6yDfZL46PpuShHLQarIIKWEFCNoNOM7V04nmggMHpXtU7+SvL5N+3xMjiuL6lvGTDJkpOD8pX1XKIAK4xWRR3UqbMY9e8IQ+kJSqs9ovf5C6wBy9wQgoUXjHSKZwuegtXGZqsXqJ2og7bUrKsnvLgzSdVMlL6K3aiHZfjbQP1QFIOy0X3VmP/a+gDhGount6+u4ls5sfghza1F95R21yQeGNui2yY7RYW8DmcJ7m7uoeSCDDYJ1HuxbnuyV1YHW76qHVjsRQxK1xl1JcmkmBHquuikvevwd/6UXfu MIhbklTA lrZoEQPBN6HRr4kEpGJAM3XlxM+8kWTJqqXlOus0p2G1b2eO2pfQxYgXgZtJomVGGG/jCLqG3mayhpx4n5tQCnaNKIx9n3fmxEt+49Jn1b/Lcrhx2ceMiCd2zqJm4Dv4PXPxjc4bIm92XOEJkGgLyLfCGhLzu3JqZeSH4EzXFzAkR5l8vz8ptezCJQFQAV3HS6W1enspsqNBF2RY4ExufqKr3DUkfcoeV8eBeq809tAonSCQW93pcNu/Pqp8mDdh6dJ+nlAeRFQDP0S4KD8Th2bR2T1Vh+EliJEX/85DBp73PTqbZ3mgGK1P/Pv/ME5Goxk3bI4jg/coAe8YejzzgTV6sVoUwIhsCq1g2F963pe99OAhfRMvS5NrwO4F7BdCm6xpWqcQDPvIv5O5Dp6APGZUN4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/9/24 12:32, Michal Koutný wrote: > This is a followup to CONFIG-urability of cpuset and memory controllers > for v1 hierarchies. Make the output in /proc/cgroups reflect that > !CONFIG_CPUSETS_V1 is like !CONFIG_CPUSETS and > !CONFIG_MEMCG_V1 is like !CONFIG_MEMCG. > > The intended effect is that hiding the unavailable controllers will hint > users not to try mounting them on v1. > > Signed-off-by: Michal Koutný > --- > kernel/cgroup/cgroup-v1.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c > index 784337694a4be..e28d5f0d20ed0 100644 > --- a/kernel/cgroup/cgroup-v1.c > +++ b/kernel/cgroup/cgroup-v1.c > @@ -681,11 +681,14 @@ int proc_cgroupstats_show(struct seq_file *m, void *v) > * cgroup_mutex contention. > */ > > - for_each_subsys(ss, i) > + for_each_subsys(ss, i) { > + if (cgroup1_subsys_absent(ss)) > + continue; > seq_printf(m, "%s\t%d\t%d\t%d\n", > ss->legacy_name, ss->root->hierarchy_id, > atomic_read(&ss->root->nr_cgrps), > cgroup_ssid_enabled(i)); > + } > > return 0; > } Reviewed-by: Waiman Long