From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D9DC388F7 for ; Thu, 22 Oct 2020 13:04:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C50C222E9 for ; Thu, 22 Oct 2020 13:04:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eRDdONDH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C50C222E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E0BFA6B0071; Thu, 22 Oct 2020 09:04:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBAFA6B0072; Thu, 22 Oct 2020 09:04:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85F76B0073; Thu, 22 Oct 2020 09:04:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 97EC96B0071 for ; Thu, 22 Oct 2020 09:04:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 34AC780A5EB3 for ; Thu, 22 Oct 2020 13:04:26 +0000 (UTC) X-FDA: 77399580132.04.team15_5307a3b27251 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 0FEF9800AD0F for ; Thu, 22 Oct 2020 13:04:26 +0000 (UTC) X-HE-Tag: team15_5307a3b27251 X-Filterd-Recvd-Size: 3546 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 13:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603371865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=As8qSTErnVD2tPL9urI7UfqQPyUFFU57lklVowYpQ9w=; b=eRDdONDH1wNscfOG4i32TAao7k8LLNDMSEw2TnE2maxQfCqdhpOKdpDqQ/4ODFuR9OUgs+ 0l7qbLozukvSc1XR3WaZgVD7gnp24lEVwHIUvMm9+H0O1PSz4/0pLpyRsT2BFOswLOXLdf O5ZVIgIGUPFWoclG2ZecsvWcDR8X6jw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-PrXWF3dhPVahEzLf-PxVNw-1; Thu, 22 Oct 2020 09:04:23 -0400 X-MC-Unique: PrXWF3dhPVahEzLf-PxVNw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58A6D10E21A6; Thu, 22 Oct 2020 13:04:02 +0000 (UTC) Received: from [10.36.113.152] (ovpn-113-152.ams2.redhat.com [10.36.113.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28A0F19C4F; Thu, 22 Oct 2020 13:04:01 +0000 (UTC) Subject: Re: [RFC PATCH 1/3] mm,memory_hotplug: Introduce MHP_MEMMAP_ON_MEMORY To: Oscar Salvador Cc: mhocko@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, pasha.tatashin@soleen.com References: <20201022125835.26396-1-osalvador@suse.de> <20201022125835.26396-2-osalvador@suse.de> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <8cf48839-1813-8992-ad87-f0fd195ab107@redhat.com> Date: Thu, 22 Oct 2020 15:04:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201022125835.26396-2-osalvador@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.10.20 14:58, Oscar Salvador wrote: > MHP_MEMMAP_ON_MEMORY tells the system that we want the memmap > pagetables to be built from the hot-added range. > > Signed-off-by: Oscar Salvador > --- > include/linux/memory_hotplug.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index d65c6fdc5cfc..dda2d0e5d1ba 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -70,6 +70,14 @@ typedef int __bitwise mhp_t; > */ > #define MEMHP_MERGE_RESOURCE ((__force mhp_t)BIT(0)) BTW, I messed that one up, I already have a patch lying around here to tun that properly into "MHP_MERGE_RESOURCE" > > +/* > + * We want memmap (struct page array) to be self contained. > + * To do so, we will use the beginning of the hot-added range to build > + * the page tables for the memmap array that describes the entire range. > + * Only selected architectures support it with SPARSE_VMEMMAP. > + */ > +#define MEMHP_MEMMAP_ON_MEMORY ((__force mhp_t)BIT(1)) So this should be MHP_MEMMAP_ON_MEMORY. -- Thanks, David / dhildenb