From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3356C46467 for ; Tue, 10 Jan 2023 15:27:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F4F38E0005; Tue, 10 Jan 2023 10:27:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67DAC8E0001; Tue, 10 Jan 2023 10:27:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F7FD8E0005; Tue, 10 Jan 2023 10:27:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3D2148E0001 for ; Tue, 10 Jan 2023 10:27:59 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 155FE401FC for ; Tue, 10 Jan 2023 15:27:59 +0000 (UTC) X-FDA: 80339269878.05.2884FD9 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf01.hostedemail.com (Postfix) with ESMTP id 5177540006 for ; Tue, 10 Jan 2023 15:27:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="BLX9ry/7"; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673364477; a=rsa-sha256; cv=none; b=dELF07YITJ+8jlofLZT783gtsE285Fg0f9GkbToSLj/Y81qzKCs1cuO9KGoekYeaGo8DBM KI3/cPB9YDgvLtLiWDGxNP5XZj5VeUsV+rYVgkftov6xwMGIGSW9wL5XeiXv1Y9yzluJFy dBD7sgjM9/1hoeLT9KsEYc23NXvFkK4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="BLX9ry/7"; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673364477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Am0Tp9HLuqkqysR0wBqMIuaQhk45x9nTKJpzR92A6w=; b=io/JlvCbOFcMsQclHwoAqTIs7o7TzyI1V/ixvjGxLXoOlmKjS91i7Ubm1Vamnp5P0myMgD Kl1XNPPhaJNV8kP5WRWrG+m6+FXKTBj08buLGRbme4amJcdMgwfJ465AaqVRporPevdJND aEmZlxZr3cnzQy+hpAvtHW0Era8Brec= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673364476; x=1704900476; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4Am0Tp9HLuqkqysR0wBqMIuaQhk45x9nTKJpzR92A6w=; b=BLX9ry/7XJMioOBKygLzUhFsdgeqrDj9str1Gz+/eTZz2kjsc+smEJut ge17G5cCEoKidELZ31EZyD1lFzqjd9UFpn0xXT+EdX5dMGYQJbP7BpncE TLDOb9VSTeophD/echbHtGmf0J5vPUhXyETvk59Iodx/70bUL6yI11BF8 V6VQNLIAyA7hZFcdc0F2i0z8b5ZKQzvJoVtUxaSq5/usrnCdM1qQFpK57 urxW5gnpvQBkw1GTLeExHmDw7JQ3UozyTaGRhT26Y7+sUSphuzoNbXrnq pe7g8AYlBcftlPRTWnwFvNfEWJU2Bk3xu+WW/Wk6djQ52p5f2lD6fw2dI g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="324407488" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="324407488" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 07:17:31 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="781093858" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="781093858" Received: from svenka7-mobl1.amr.corp.intel.com (HELO [10.209.63.27]) ([10.209.63.27]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 07:17:29 -0800 Message-ID: <8cf4755b-2592-02fb-46a1-8c32be94ebcf@intel.com> Date: Tue, 10 Jan 2023 07:17:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 11/16] x86/virt/tdx: Designate reserved areas for all TDMRs Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "tglx@linutronix.de" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "peterz@infradead.org" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <27dcd2781a450b3f77a2aec833de6a3669bc0fb8.1670566861.git.kai.huang@intel.com> <2d7d2824-7aa7-5f96-d79b-b44ff7fe2ef9@intel.com> <5f7891ebecb8dbe71b9e2c67332df716f0b9a8e0.camel@intel.com> From: Dave Hansen In-Reply-To: <5f7891ebecb8dbe71b9e2c67332df716f0b9a8e0.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5177540006 X-Stat-Signature: 89gdtfrwmaj4q14eckoqtmuq9ndrsbdt X-HE-Tag: 1673364475-21556 X-HE-Meta: U2FsdGVkX1+JbCmfwT+TKMp6Qy8Lu/g2qBqvHWHk382SQ3N5QJ7vsss2WQ6wlf7KFZm7XXEFCS24b26qYormJz8+hXxfAf9xwq/N+0Rt1X33mdRb+G56oTrChloevzBbZG0nOpSXOJBk/qZ14B5D4YZ1affIl61B3C+U0HiILYKuWc7M1PUc4Yn6pN6kbw1FqJeT0zWN8aj/w+lya0O7JYYDVtz45j5WlsZ6v+gSR4Kf/LwgOATEo+9TbNjlIrNvDiW9LnwizwbuEzce2PNQFb1yduC0SCTlvs7NZ2UCn9/EMoMyNGWa+gW9ZU6Vh7Sa8dAYrvvAxMzZuJ4wyccTTYLLw8c86DwtmVnm5TSaPFtFRyc/9rx5AzgcOb74PmFF74Qp1J6CB4fjKPyJixGyNRdYGDinceOaYZYY4ezuEjP4Uucs1EngnYUWNnulzJkfmJmVGOfowMtTLZF+lf56IWPCn69O9igWEbCfaQA4XgN0qbw4aYxKdFYPsxyCjyUjA3V5iuIzdu2nj9AICioWlFyi8DRxrv/5n+dscfyOS+fRmyfBcBGcelNN2bhzFU6Ir4HgOGM0xqLdTqsY/1+qISgyRoRNNeA3HyCE4L3P2lHjvhcv2falfux1WODFEFEZz+zUhMJWNedjIL/EfefjfEhoojPe0yBxRP+x6UsaBzrwx/xI3NvQh2ZA3r1WbcsnI0QdKuCb4QL1AluZKRtmhv2GK88hKJYa6v/bOEklyyCH+800uWMereZLqCYODDvWafYp54zJ1IOBxy3fOmc9s65mZyDIa3nJyKGtlTEHHx7trged4VpVZnF862c7KYeTgrkFWuJvKzQk2sBN2nCrrUCHUuJgOSxQSHCMbBesg4u/7Ci5sZikSvHLu70QowonXdj9IIJsFEtO17u/drB2ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/10/23 03:01, Huang, Kai wrote: > On Tue, 2023-01-10 at 01:19 +0000, Huang, Kai wrote: >>> I think the -E2BIG is also wrong.  It should be ENOSPC.  I'd also add a >>> pr_warn() there.  Especially with how lazy this whole thing is, I can >>> start to see how the reserved areas might be exhausted.  Let's be kind >>> to our future selves and make the error (and the fix) easier to find. >> Yes agreed.  Will change to -ENOSPC and add pr_warn(). > Btw, in patch ("x86/virt/tdx: Fill out TDMRs to cover all TDX memory regions"), > when there are too many TDMRs, I suppose I should also return -ENOSPC instead of > -E2BIG? Yes.