From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE5DC433EF for ; Mon, 27 Jun 2022 05:27:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8863E8E0001; Mon, 27 Jun 2022 01:27:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 835C86B0072; Mon, 27 Jun 2022 01:27:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FE118E0001; Mon, 27 Jun 2022 01:27:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5DF616B0071 for ; Mon, 27 Jun 2022 01:27:48 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3097B60FE7 for ; Mon, 27 Jun 2022 05:27:48 +0000 (UTC) X-FDA: 79622883816.11.A1126B5 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf13.hostedemail.com (Postfix) with ESMTP id B0C7620025 for ; Mon, 27 Jun 2022 05:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656307665; x=1687843665; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=2D93qOLka+Gpjz16jAW/W1nPcGyL/5WlDEew9HTSVUs=; b=SKAegz3Vn/NU69aBlx7zrrnHvgkMJCsngOOMx5IOYbflfxkapJSC/kbk YIu5rg1V8J9utBPCotMECaMXj5wUUZ+Ad5N9ilVRwokgSkHVopW+3U+tI n/+NNF9D1kSQeZ3q8nvr2B8kwrpkeAylv22F8OGYBgMnWqkkVetwWg0SO dlkMEskV8VVBHW4Ohy9rojSnk5Zr2hnUpFAM5Hb24Br6hzt+9IUljfJ1B qGBzWZ/c0RMVBpyG1BnbfRyZET+xVobR1hZMfClzkl6Uvca/Y6FKNryvV xIiGHG3+lMMaoPN60T+2thu9GdPzqPaR29grfw6gSEAYn2yeEgeP4kQ56 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="264404884" X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="264404884" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2022 22:27:42 -0700 X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="539986307" Received: from fzaeni-mobl1.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.212.88.6]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2022 22:27:38 -0700 Message-ID: <8ce8bd5792f44348e5e7384c93389bd0be5336b1.camel@intel.com> Subject: Re: [PATCH v5 05/22] x86/virt/tdx: Prevent hot-add driver managed memory From: Kai Huang To: Dave Hansen , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com, rafael.j.wysocki@intel.com, reinette.chatre@intel.com, dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com, kirill.shutemov@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, isaku.yamahata@intel.com, akpm@linux-foundation.org Date: Mon, 27 Jun 2022 17:27:36 +1200 In-Reply-To: <9a4ff92a-1d79-d91e-0dbc-a1cbde215184@intel.com> References: <173e1f9b2348f29e5f7d939855b8dd98625bcb35.1655894131.git.kai.huang@intel.com> <9a4ff92a-1d79-d91e-0dbc-a1cbde215184@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656307667; a=rsa-sha256; cv=none; b=E6y4TiGUt37mjSNP8PtLDsRyZWwQv4hLlPbEA7hjNPmBSxO5iTXPd617pzeqsswlzgZip7 k+Hw+fLvVJPPZ8r5Kq2nNwCAHHMfDtwgyGEw4CJn0Zb0UfqJY5werH438fvm0FRYQoGj8M LpEHwQ0VWBb6+QmkN4Hh1HmlNuAVWUM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SKAegz3V; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf13.hostedemail.com: domain of kai.huang@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=kai.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656307667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=juDs5OB5H2oTJLg+ldvqkIdbgBf0K4pUlvuVV1yFG2s=; b=4mpiFJWRHJox4H1b6je4GqUV5ryjWpjSq72GOir7MMPncXbunLSAX8Ox5C5cR2nXVQyR9P L2p3bRSV4xk6QU8WrBQs0ZnLc0UqFtiCHunjOWburEt7Tok7WAX+tPKnfk52Qioo2RKHwp OzTavociYP9i7EQ9gCTZdmxF/m9ngm8= X-Stat-Signature: cba41frbu65mm89a1joopoe5pizemb1q X-Rspamd-Queue-Id: B0C7620025 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SKAegz3V; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf13.hostedemail.com: domain of kai.huang@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=kai.huang@intel.com X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1656307665-922799 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2022-06-24 at 12:01 -0700, Dave Hansen wrote: > On 6/22/22 04:16, Kai Huang wrote: > > @@ -1319,6 +1330,10 @@ int __ref add_memory_resource(int nid, struct re= source *res, mhp_t mhp_flags) > > if (ret) > > return ret; > > =20 > > + ret =3D arch_memory_add_precheck(nid, start, size, mhp_flags); > > + if (ret) > > + return ret; >=20 > Shouldn't a patch that claims to be only for "driver managed memory" be > patching add_memory_driver_managed()? Right given the ACPI memory hotplug is handled in a separate patch. Will m= ove to add_memory_driver_managed(). --=20 Thanks, -Kai