From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B449C02181 for ; Wed, 22 Jan 2025 11:04:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C330280001; Wed, 22 Jan 2025 06:04:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 271FB6B0088; Wed, 22 Jan 2025 06:04:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1130D280001; Wed, 22 Jan 2025 06:04:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E14146B0085 for ; Wed, 22 Jan 2025 06:04:46 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 63E4F1A153C for ; Wed, 22 Jan 2025 11:04:24 +0000 (UTC) X-FDA: 83034804048.27.7FA974D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id E149F100018 for ; Wed, 22 Jan 2025 11:04:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FpgZ6czd; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737543862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uTqitveeYlfoww2vqV+7jR6IMLB1zWZnQqVH8QPKPjo=; b=sfCMuH6cHDYYSigG1Xx69xy+b3LHpASv0qdrYG9t38nesimSbW+zbKjXzQFcL+xXBaF4IE 4WQtBTBT/kZrUnMl8QhoSub2VHx4oXhxd4DU1x8ic4Q7uAZ5cfE0Y3nc9Lpr583hVMVr4m V9XpW2N8bq/dvTdQ07ZIcZl7pl7zh+s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FpgZ6czd; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737543862; a=rsa-sha256; cv=none; b=M3AC8CT5qbMgC45gTK2bFCO7/IeypZ/5JnVC9bb76o6t+evN06/e+hpTGh+ZlMFNxykoF4 ZX1wND9bJW+JLx245A1wkBSml9VZo/Pkec7m5lAe30ZBP5+OgJUmuD7VLhXLaIhJNiijms ozdUmTmLxlVXrBZGZNvPo2dnFyu7igg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737543861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uTqitveeYlfoww2vqV+7jR6IMLB1zWZnQqVH8QPKPjo=; b=FpgZ6czdmzO/q2hQ6iF1DounFeThGfiyqmm2BZ4FyqlYDeEsyvo/LGfENOol0VTthOa+7L TBQiQw78x4RMOY+d/1xswnuP26YJgJIF4D3ByXSJw0A1Z1ZDUZRQxowZW3qTjinHej1Mw4 6WXmTpSbpSL4pf1FYfDsaCJW3kYuGzU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-CzM4gi2bMG2Yfx08qmNMRA-1; Wed, 22 Jan 2025 06:04:19 -0500 X-MC-Unique: CzM4gi2bMG2Yfx08qmNMRA-1 X-Mimecast-MFC-AGG-ID: CzM4gi2bMG2Yfx08qmNMRA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43582d49dacso49704975e9.2 for ; Wed, 22 Jan 2025 03:04:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737543858; x=1738148658; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uTqitveeYlfoww2vqV+7jR6IMLB1zWZnQqVH8QPKPjo=; b=AQg1vChj8HBCAOB9A4zin0JaN0utWsJBuA/G9CCVunGfMbOQZqmMpuYa5XTFCObYwc hZiqsWr29DpO4qy1txuEGY2ZwZtujUDGOaq7sjpTGedRec/YcJs7gAjXrbAz+aFqbb1v xiT12kiTHgrPFbdIN6AFEf9m2HljTKJ6XIeoxLOyoZHOt/MdEhcK/hIlUmVRqFOj0foQ QCRHlmBTYQK/3LxPApKFwkvpMpJxpguFdJL9B+ox1rNKI64AbsnlnxgM0+UqxwPi98c1 0M8D5ZAY2/QaJg/MCO5rW9NurWiNOxh4xFISovveTvkTopoJ8zLyrFMOl12mPNHfBasS hcaQ== X-Forwarded-Encrypted: i=1; AJvYcCWwR8cGK25q1usoXGdCdXUUlUzAKRirVSiRDMhm7im9otoe85lJNt6mjudwjaOncqg+wFQWVt+c5A==@kvack.org X-Gm-Message-State: AOJu0Ywkez3VNqMbXOWvv9T+IC/Jheh1t8c7j9sQcc8wQMDMoYfuoYSC SaHxzGOlR6PQegSNWH7WwxFRRajEtkX//P/1ru4/uL6W+e1QPpaAPCOHFlgx8f+Rw6N3bR+dV1N P5zn6H/5l1ZweAKRtVEWS0fZxNmuzqzEgqAbWIe07c2M9oAXM X-Gm-Gg: ASbGncsWM/g2dMRWpPN2NKmTZGmm8VBzGEalB1zmXD1tI3ZAIcg3sEwLEGh4cgU8XCP DTQbc4nMhn5JNJwe9t12hC0H1JfNN3bsHy5z2kydCNFqQ2L36h4yhGvpRcSz8syuK3wgDLuDNAA Hmhw6ufkQNUtyqpkg6JUmbRH9cYgNt1hteRCfQqdNTeT/R63oMa7V3/mFtott3r0YysmyVAkfa+ GBhQsiw5RfWjQvk5Aji9YX155CWn2Y4GW9+7DkNjgGDaqVnPH5vj3AO4NifCkixMPMSyLBr78c7 H1B9dxtTV7vrNpFJw9aK4ZLd0QamxH4o1sVWYWyLRGoO4xNmyO3uv7qumJ04roG2oXKMbOG40PO 9y/EJp3Ru8KTdN4VPBrz+/w== X-Received: by 2002:a05:600c:458a:b0:436:faeb:2a18 with SMTP id 5b1f17b1804b1-438913bed3fmr182960315e9.6.1737543858608; Wed, 22 Jan 2025 03:04:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsRkn+FvjORJINfwL5Is025kiWBlebLqOLOmadtyAukyoYou9FEM2uALjzd4rA+Zadgnh58Q== X-Received: by 2002:a05:600c:458a:b0:436:faeb:2a18 with SMTP id 5b1f17b1804b1-438913bed3fmr182959985e9.6.1737543858264; Wed, 22 Jan 2025 03:04:18 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:db00:724d:8b0c:110e:3713? (p200300cbc70bdb00724d8b0c110e3713.dip0.t-ipconnect.de. [2003:cb:c70b:db00:724d:8b0c:110e:3713]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b319e2e4sm20349145e9.9.2025.01.22.03.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 03:04:17 -0800 (PST) Message-ID: <8ce0a203-00bc-48e0-9cfb-f28a1ec78dfd@redhat.com> Date: Wed, 22 Jan 2025 12:04:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drivers/base/memory: simplify outputting of valid_zones_show() To: Shiyang Ruan , linux-mm@kvack.org, osalvador@suse.de, rafael@kernel.org, "akpm@linux-foundation.org" References: <20250107100941.1169222-1-ruansy.fnst@fujitsu.com> <20250108015223.1522887-1-ruansy.fnst@fujitsu.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pDeDdbg14z1GMMtbG_8uYJxRezDt1-mPd8KBTlEEv8A_1737543859 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E149F100018 X-Stat-Signature: k14cedgm3sj1ego7yz4ndhzb6npdihz6 X-Rspam-User: X-HE-Tag: 1737543861-749436 X-HE-Meta: U2FsdGVkX193LwTqolwZvk/8nmkv9GNVWvdMLGNYOCQFCC6z9v92jffWs6LQpFwK0GPBjb7BzhICNn5qPOxyn2OWwotc9qHYj97AqyxgH2Bw5M1JNLERuSQ1g30b6IT6+vSUzsZ53gjHzzyFpCbMSZRnuq0XsR84z3VeSK9nX9P+iqfqS8bwF/wvpvzh8QEorF2vGAOmvGoHnHha2WJcLSLDUMawygy+lMBfoAIjGSA7zit1AqKSOG51v6sHaSPYGTVX76nmHWHDHjpryO+9H5re1tN2Ij4c3w2yc3DW1F7IO89xtn4daYc4SaM8L/v3XYftP9AaLr3VJaZDN/uCkAMbNSJK3DiPoDc5WFhuSySgQ7501KB/xoC5XNvFfjzpJHaiNVYS/5CWSjKcbnAPiPvCpcj5qWasrQLS7oAYG3oA0XsDRNUmefERuoXd4QTddU58nqiQl/ixCtq3vETxYiTNgjiJybKmWyxTB394IwbnBzage2EZT5FKScKcTOd0L26fD+VZb1Oj98aHKo/qgxf7MRw9q3sgnDXHZTyh5Y85mkQOsXhqzQYxlnwVfRTqMYHE2+qKMDhacei5jGsAK5N1V7skJdX2dNszLYozxqc2zkYgIfeV/S20l1FLL4ttG8nVAkJ0UhS/WL6YVNuSz+iK8rJufSPIHXqGEOb+V8d0T5E5DYZxAIW3NNTiBSH/2ABCMJHQDV4REQJFK9BQLZlbQA1bLQU2JzYYP9Aq6Y02NeefMbxIKofgwk15Da0FZa2TO8j7UmGjo802e0fWx+OwhezE2P4Du0JHrzX1i6np/GbIF1B1Sm/fQrI/c9jAjHe706uRcKOC45rYhcTM+PxilaYLbB8lj9kn3skEJmChJ7AjIMnX+UDCvW6t0Z3sqBNSr2IuMHN9LJ9d1ayz6HbhG4WgiMLj4tA89QTrPYFfLOaZdLNfoHcjOKcEM1dcG1KTt3wAMrC8TI6fPcr WbEsBdoi Z/euIodrxnt1TVl2mjMcdiMElYDJ8S1Zpr53fvxLcD0j4M/++/Z2uUd4inuyaDi4DfHPfYQA3ogJ8cUF4kQUUEs9QYFTy7eZhztgMtp0L+aeqp24Y2MyexzmqvPoE4qzO2wdgsUVbZa+y6Ebc62L+vJEWhn3frpNibOiYrMmtZeYksdurCK19lt/5tHmWcaWqJ1erjH27awUDnDfdjSL/ppA1+YQ7quP7mBrJHx/6nlZZL5MBneNYp0OOk4zylRFKR2ZD5jqOmUaUlHF2yPUdVWp5pLSp/O2+Y5q3eKd+g7PpAAiRNXzvBPmq8a5b/52+/R+FToy5RhAxtnYBY/oAC36ccObzvDl7A6yjWykBKOaAehiOKYffINcBIPh1+fR2da9eScvHjRa2wKu685j5xrSxWo1rQlR75MdPSaTopRykPCypUucmYujKMtfplwsYvuc7Vs7SchYh7TZaCvPcptyRp7K56mKlh7gK7URSMUBFHEvboFcGG5s5+Lh/gqzIq1a6c0AZ3GFYePo/WC4Dm8lS6ArN/2iXOmWjkOGE4OmolAo5SsXAqvKqW7sywZ6qUApr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.25 11:14, Shiyang Ruan wrote: > Hi, > > ping~ > Any other comments? Thanks. > Hi, you should always CC Andrew. @Andrew: https://lkml.kernel.org/r/20250108015223.1522887-1-ruansy.fnst@fujitsu.com > > 在 2025/1/8 9:52, Shiyang Ruan 写道: >> No need to specific position at the first writing to the buf because the >> @len is always 0 at this time. Use sysfs_emit() instead to simplify it. >> Also avoid setting/checking default_zone with a conditional operator. >> >> Signed-off-by: Shiyang Ruan >> Acked-by: David Hildenbrand >> --- >> drivers/base/memory.c | 12 ++++-------- >> 1 file changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >> index 67858eeb92ed..92e6bc6eb21e 100644 >> --- a/drivers/base/memory.c >> +++ b/drivers/base/memory.c >> @@ -455,7 +455,7 @@ static ssize_t valid_zones_show(struct device *dev, >> struct memory_group *group = mem->group; >> struct zone *default_zone; >> int nid = mem->nid; >> - int len = 0; >> + int len; >> >> /* >> * Check the existing zone. Make sure that we do that only on the >> @@ -466,22 +466,18 @@ static ssize_t valid_zones_show(struct device *dev, >> * If !mem->zone, the memory block spans multiple zones and >> * cannot get offlined. >> */ >> - default_zone = mem->zone; >> - if (!default_zone) >> - return sysfs_emit(buf, "%s\n", "none"); >> - len += sysfs_emit_at(buf, len, "%s", default_zone->name); >> - goto out; >> + return sysfs_emit(buf, "%s\n", >> + mem->zone ? mem->zone->name : "none"); >> } >> >> default_zone = zone_for_pfn_range(MMOP_ONLINE, nid, group, >> start_pfn, nr_pages); >> >> - len += sysfs_emit_at(buf, len, "%s", default_zone->name); >> + len = sysfs_emit(buf, "%s", default_zone->name); >> len += print_allowed_zone(buf, len, nid, group, start_pfn, nr_pages, >> MMOP_ONLINE_KERNEL, default_zone); >> len += print_allowed_zone(buf, len, nid, group, start_pfn, nr_pages, >> MMOP_ONLINE_MOVABLE, default_zone); >> -out: >> len += sysfs_emit_at(buf, len, "\n"); >> return len; >> } > -- Cheers, David / dhildenb