From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614B6C001E0 for ; Fri, 28 Jul 2023 10:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D312D8D0001; Fri, 28 Jul 2023 06:30:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE1066B0074; Fri, 28 Jul 2023 06:30:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5B4E8D0001; Fri, 28 Jul 2023 06:30:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A3C6B6B0072 for ; Fri, 28 Jul 2023 06:30:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1887A41181 for ; Fri, 28 Jul 2023 10:30:51 +0000 (UTC) X-FDA: 81060652302.04.A785FB6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id E18684000D for ; Fri, 28 Jul 2023 10:30:48 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QMJwmg+j; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690540249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AeRW9S4IraEiSRP3XajTqTj5LA28qNkl4E7pfpLeXl0=; b=8m/PWLkdA3KJQBlaKYk/adPFXpj810dezgVsNN1yJDcdGnD18QJKLky4BNg5B8hcgmZWSv 5c/lZkUgQ1g5GDesRieMLwn5237/8kduQdqXhOjm3I5/ySUBq+tpzj6L7kSy/EvGypjV75 d385n86tn2fDadQ1U5KXRFNuwIaxWGc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690540249; a=rsa-sha256; cv=none; b=3T/vhMHKZ4bdJdp2GIl06kIBV1FNUm33xvIxGyljO/TflkU6oy/P5MpT2YiOIFQbGTmiu9 AcpmfxiCO+TKVhBgMrw9tfTQIE87TFlm/ANJXE3S49gm771AuyfRav0dpyZ3iV2WPCAp9R +uXjRyCMTZ+Gh+l5kxqIFacm2rtMnzQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QMJwmg+j; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690540248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AeRW9S4IraEiSRP3XajTqTj5LA28qNkl4E7pfpLeXl0=; b=QMJwmg+jmH1P+uRRl0WUw0HBykEQHY6nJKCX1Dk91uInbE0ZI2bZIhMrDuRqmtiUoO2OMj rZTT5LYSQwyICObD1zOnXRolofWtqyjcXp4XsIrZ6jnSZWk6OfZSEZYJu60MinhXJ5y68M 938PcjpJrqj2CIhIsocUUT5m+UumR2w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-v9ZBn5b2O8-Zt4iBxK4pmg-1; Fri, 28 Jul 2023 06:30:43 -0400 X-MC-Unique: v9ZBn5b2O8-Zt4iBxK4pmg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fbb0fdd060so11654695e9.0 for ; Fri, 28 Jul 2023 03:30:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690540242; x=1691145042; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AeRW9S4IraEiSRP3XajTqTj5LA28qNkl4E7pfpLeXl0=; b=gS4yBzn0Q1SExDWkyZvGDgkDYahlRZba/+m2e6hSfaK6lmDNRPndCDRCYscbCwrwaW mysEI/8x25eRcgqmSfFs/lX7z4eJ+C+/pyA139ZXUs/KOT5M64+caYJNSdljFFpx6M0K j4x9JXHWUUsvfrpyCYyIB87hvfplfelRlaLdzOmMrYcngcsKnRpbsCxwifHb7sAI/qTP 682mg7St3eLedxFaxuJUnPx+Vzb42glAs4DIW4k6YKs/EZK5qdRwjX6oyQzZnfEPBgRZ Bk+wcRfJYY5TLwoWkvyl1Dy8fEhQ6x8fNY2RZ2lUZ2PjToB9UNEXPz3JzLiB0HsDXkYB qySA== X-Gm-Message-State: ABy/qLbOijB/gvOvMdMPAlgAfhBTKEBd5PPAXf4icUCTsdgGiZ1XSBUZ DylqYZRzOs08bgQjz2lK0dfHQGtFsQ0E2O+nu5j/RaATXvIbO7D9Vlr2ZzrAhUW4er+7lfoARQk pGVHtAcIKyVI= X-Received: by 2002:a7b:cb8d:0:b0:3fb:b832:d79a with SMTP id m13-20020a7bcb8d000000b003fbb832d79amr1378735wmi.38.1690540242292; Fri, 28 Jul 2023 03:30:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlEoXD6cie/e0g+FZfl/wau6ivG28fFLQHzaxWPXoeYCcCxN2yY836fF7KtjbhYj0CWvH+LoLg== X-Received: by 2002:a7b:cb8d:0:b0:3fb:b832:d79a with SMTP id m13-20020a7bcb8d000000b003fbb832d79amr1378719wmi.38.1690540241930; Fri, 28 Jul 2023 03:30:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id y17-20020a05600c20d100b003fba6709c68sm3816733wmm.47.2023.07.28.03.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 03:30:41 -0700 (PDT) Message-ID: <8c9977ea-a6d5-893b-cb00-66e6007d0935@redhat.com> Date: Fri, 28 Jul 2023 12:30:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 7/8] mm/compaction: remove unnecessary return for void function To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-8-shikemeng@huaweicloud.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230728171037.2219226-8-shikemeng@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E18684000D X-Rspam-User: X-Stat-Signature: mmyos53hufcb4ouh1qqk63nbmmay1dii X-Rspamd-Server: rspam03 X-HE-Tag: 1690540248-782696 X-HE-Meta: U2FsdGVkX1+Yxg6uBtie8pGARLpJg2Tgp6aM/+g0R8+ko/IYoPCBxC1k44GihdPEc4gP/sw2cwPuEQ8y6A2vc1H2+iRVHxWI4mC1MkR0uPSTiAryaX4yxPPeOFBUK+U6SlOX/sdUvYpzQzM1CjpIyp+lXFeur+06MIb0J6i75iT9SoqMcJOHyGkkPBxxNHR7PwYwzsl66h/tRqUQdVUBL5o7vMXKKJPLwB+QH5jk1QE6AkPoU8QWhpL1Z7Bm3PpqzIrITvcmuqqNH9R4rqShMNSKGHHjKzd0Kw2hLSXLTJFTa+MkQTF7ZhNiO3GLrBRNuqUwZiP9JObgL05C6GUs2NGrUBqzIyUYu2pDFSpUrjP89tFWGB1ERREadJKq5A/HQL6lp4R5JP4d7UngPv2lQMNkcDWJDkZj44MQL6tJQ38v5E/xsCaRzJybeOmy8fdc2xlPPWlfneTB0JaX6cSAquUpUrhUd+DR0QmBBTyRADmeDvzQGQEVxKudeaKfGvCPT95qy1rL1W/d9/gJtZv4IucwF5Wrjnh8UdWuM4AAhg/nSbXwO7V7EWcpiPAL+hrRrse9A858PJiN5N+ognoFpdMXSwsLoccHn4kWXS13Dgaauxj+5/59/qR02iZ2yVnEpz+Edf3ZR17iK3ZWLETYlLz8shax/Rb1gFc7ACtmOw97tchL+8i8xkcEh7Qn4pZSIdqTsKFF+Db6K0EILIb/5H848v7cxvWbRpfRDIHt4IHxAu2IfpZQJUnaAGsmt//rrvOO0lnrYAeBtSgQolYoN27srUvD0Tx1LnoU2j5oDHfXgZfmd1i/lhMnEsw6MIoKS57k7lxmh+a7IV8j+KKbsTJnYDru2HxmNvc4slLvAaD7HV54lWZ9GuTzwoV5XnXX2v/Ux7lW3uN+KeyrsIm9nOwvqbayuIlNBStyUwKECxWJ8gkasOy5o6FTDpG09jvP1CU0uETKS4pIzWJEkkp eofBts5l vCLpF0eZQP/tieY02yP2rgi4kgqX3dM9holRfAY1ZgvefpvkgRefZHPY//TBKgOU+glIKuPvc4HMwLHskbWgOL3yjwYWwYOT/eYFvoV9djrvKMGv1M7zoEuE2ME+OWFBK9sMJNiwzlyIYnew0YHd70W0OMqMQYiMb7e4efTuoBAJDPAna/utqY3Ug/OSqwsvd0VKM2x/nq/yHKx+xKdTeFDuzP85BxmeGsqbn1Z9tY/jUyACs6pWBpP1vJ/7jqZJS4ZSM4Z7vWnmu7Zexk9/vhGIbv2KGWgPbUgsgnkZLCp6Z+ts2ADhGisAp4D8Td4bESI9yckj6eV0SUObkWXJv9PPqZJKL3CZuWUEIaKAKzC3xyeQUbQUwDdyis/HgJf86LqKZoKd5bT+2/JfQOYX9jLxHhxvZD/2xWE3eeRIqrmS7b3Rq4xxfuzQTyM16D5uEBpZn26HLeVyYzR1L/iZkU1ASDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.23 19:10, Kemeng Shi wrote: > Remove unnecessary return for void function > > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 6052cb519de1..188d610eb3b6 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1420,8 +1420,6 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > /* Skip this pageblock in the future as it's full or nearly full */ > if (start_pfn == end_pfn) > set_pageblock_skip(page); > - > - return; > } > > /* Search orders in round-robin fashion */ > @@ -2863,7 +2861,7 @@ int compaction_register_node(struct node *node) > > void compaction_unregister_node(struct node *node) > { > - return device_remove_file(&node->dev, &dev_attr_compact); > + device_remove_file(&node->dev, &dev_attr_compact); > } > #endif /* CONFIG_SYSFS && CONFIG_NUMA */ > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb