From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0946C636CC for ; Sat, 4 Feb 2023 18:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F7DE6B0074; Sat, 4 Feb 2023 13:18:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 181936B0075; Sat, 4 Feb 2023 13:18:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3D0E6B0078; Sat, 4 Feb 2023 13:18:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E02436B0074 for ; Sat, 4 Feb 2023 13:18:47 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AE68580465 for ; Sat, 4 Feb 2023 18:18:47 +0000 (UTC) X-FDA: 80430420294.03.29CB60F Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by imf11.hostedemail.com (Postfix) with ESMTP id B1F3040005 for ; Sat, 4 Feb 2023 18:18:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="VXyIw/Bk"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf11.hostedemail.com: domain of Raghavendra.KodsaraThimmappa@amd.com designates 40.107.223.59 as permitted sender) smtp.mailfrom=Raghavendra.KodsaraThimmappa@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675534724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sBZnJalvHyzHJRDshibTlSQLRzyAyAcRgSc9ut2Onl0=; b=whN27VgcUzwbNflSowTObrjr20Bf90sN1Ja/buZ2h4VJY9EXr9aDZDYzci4eHp7EzSEbA2 f8l2m2b9rR/IgUJwopKtcwzBcJuPebp9zNT4pL47EpeMdB/EGamgILHP7fTUWs1DX73wN0 kSljSYYXhOVJi9CbybmJ0CShzFkqjAY= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="VXyIw/Bk"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf11.hostedemail.com: domain of Raghavendra.KodsaraThimmappa@amd.com designates 40.107.223.59 as permitted sender) smtp.mailfrom=Raghavendra.KodsaraThimmappa@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675534724; a=rsa-sha256; cv=pass; b=PqB73jVfZ36uirWD0PTz49tj6tRJjmdVtfk1S9C1iQz3WDszFqBCd/RHRdB8ENUJBM88EN NYWGCu4WsydCfE6RsDIDyLd/M/z8EOlib7zTvJwqJW1kYyS+lUk/3t2oFWs2xpMgOBCph5 X0UaZv0dWrV+6yD7d7imefxSC09FED8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KErvDkBoN0LLuXcXK6HQApUVVwUQeKi4n1378/KYpyLcsAPqMkGd2iVjZm7ZaVHX3IzhGM7fWKn1Dwi/Y3DEeaf0Z/vSyBSB+sav7OEp5behY56105W0ZjRt6CexFqhYCL6Cvi6dtCO5C/cplEt3Bjkskx5Vhl8aoSXJdK5b1CsFxKbszHaA73OmQs+c+aN3IjcBs+t4Vpl9AbKcFAjUw+E5RshTQHW4lOazvEp8zIj+YLakbE7FNzMEinNvCi6Lz0Va8SmwZKHmL2ADa540/8JZu7VC/B7MddGWZl3Vtzb9+3x4M1e2P15q+SQtSe7D5vLnil7yKdvIm4fmFkK1lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sBZnJalvHyzHJRDshibTlSQLRzyAyAcRgSc9ut2Onl0=; b=VpH0eSHZhK18SCqXN3HH36kWMzL4T1mlcj3gO2mKrAkXRbsSdChRbUiNSwwsSEHdfbLC3Rvgk3Kv9NVEpmaq2Y7renIQ7Jy3hRQYkjRu3btBI13tNTTmsS9Cwpn/XN1P73t/vZ280P/ZQ8UCtwfNwE/EQkfFT3vW62PfB9jvclcSsmGIv6SIkjwoJ1AC2SSvUeKUfsj28rg34yAceVJmN9J1sMz8SXXLePcJW1ojwIoccClqgk21qWh+zh3Mv4Qf5ZgoF19CQZ/umUs/w+T50I+kPRxWj/GEmPFCgiXyCrQE6ptftXwrlqWVi56tgPxc+2K85NDcEv6LZ3FjZvV2RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sBZnJalvHyzHJRDshibTlSQLRzyAyAcRgSc9ut2Onl0=; b=VXyIw/Bkg0H3+TVFiE/7VRsaWMCBF2O2uKI+SP4KLLl/O0DQt5di2xp5QMx/9BLl6S8qEah5VVgnofYJlj2vkS5ENXotkctWNjTvzN0PGUjOmXKIkscSjhH3YKbtWrYknyFa6negXFFo15g0Xl8Aonvewh498bWXycz3mS2iK78= Received: from MN2PR12MB3008.namprd12.prod.outlook.com (2603:10b6:208:c8::17) by BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Sat, 4 Feb 2023 18:18:42 +0000 Received: from MN2PR12MB3008.namprd12.prod.outlook.com ([fe80::f9e8:ee48:6cf9:afdc]) by MN2PR12MB3008.namprd12.prod.outlook.com ([fe80::f9e8:ee48:6cf9:afdc%7]) with mapi id 15.20.6043.022; Sat, 4 Feb 2023 18:18:41 +0000 Message-ID: <8c8f82c3-1296-ca28-0a21-6c5467ac2e3e@amd.com> Date: Sat, 4 Feb 2023 23:48:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH V2 2/3] sched/numa: Enhance vma scanning logic Content-Language: en-US To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Mel Gorman , Andrew Morton , David Hildenbrand , rppt@kernel.org, Bharata B Rao , Disha Talreja References: <5f0872657ddb164aa047a2231f8dc1086fe6adf6.1675159422.git.raghavendra.kt@amd.com> From: Raghavendra K T In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0212.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:ea::11) To MN2PR12MB3008.namprd12.prod.outlook.com (2603:10b6:208:c8::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3008:EE_|BN9PR12MB5273:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ce77d0e-029f-45bf-4ffb-08db06dc3e8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9fouyqkSIeB38XdIgjMKuJdrsxezl/tBC6IVY0UEidmNGta7BBoohvLHYCv+/F0G9BfeydPCPsXYTAklZpcGGf1hp05M7nWmWweRjxjwAf3qa3fCoczZKl37cjhjLAanxL/SENQlR4BAuXGwUrRKGInq10QopRCfc2Us18WUdA5cRI1rwosidETGe0azjgT8j0FypPsE2wD+UHg/+BAWVeuGzbF2IsiWTj6V2w9NzGfz1/G9ms7FydKYkc7NbOqVT0FJfPx8mLdNAA987eufSqOuL/BffxcDWzPTnyiEVKOQq+sxqvC4fYU7B9LJpwcXfsrGy7cQDJI+2XfDoe/HpO70wHf8wQ05XkXx158C7YhbUL/s+iLVK4EoZWhRYRua0/hRL12LwTEfSfYRz8vpWsPgDpfBSBIOEax27d7Mc/LT99/0+R+QBX5oPeKgl8LNcvQtX/9vPfjT2Th/5tXLEdIuzR7VBc9JQAlPIPcq5bU5dOhfB4+poz4bVJfCQfhIz+Z37A0TuNOQw/lqcah0mh/L3KwDPN6PXyafHdkIA9POuM7fOCHpeHHEyoipwDKaZe52zOXT+aTSCh5TP0Ta1xsy+KyNFEEEGbpso7H3x3vhgmQvFzYfOWPhQxOvzubNe7qanPp/SuV06h7AXjcscKxZWE6R4IAEAkjV5Yp+JiXF+He7Hqj8F73iWT2H8E44Z2xjx5aPROyT/8SrH4hXKhZbnLCjNKUslUaVLOR7jYc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3008.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199018)(38100700002)(54906003)(6666004)(83380400001)(6506007)(53546011)(2616005)(26005)(186003)(6512007)(2906002)(31696002)(36756003)(6486002)(478600001)(66946007)(8936002)(31686004)(8676002)(41300700001)(66556008)(66476007)(6916009)(4326008)(5660300002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QStFVVVYOXBYSUNOY3FCQ3VZRmdteVNXOXFjRVRMSm1pU25DcE1uL0tCVEFs?= =?utf-8?B?SjZFWFV2NUI1RTJjQzZEeWpTcENiS0Y1ckMwUmg1Sk5nSDAveXgxbG90d2xU?= =?utf-8?B?d2xiOXh2YXprTS8xaGhtT0x3Yncvb2twTzRSakVPYncvY25Fek0vQTZORzJU?= =?utf-8?B?ZUVSbmJWWHNsYjBPbDl0c1FLVGVOWlpXZVQvUmZOeitmWEIvL2FwT1owcGhp?= =?utf-8?B?aFUyVXErQzIreFJuTlRtb3RFNUUwYTV5dlpIUzV0bUpkNU9FZ0dOZjlrU1cr?= =?utf-8?B?VnpmSjJabDVxaEhDMEJwZHQzOGJIa0wyUml1YnFmTGJqL2dsRHhrK3ZtbXRM?= =?utf-8?B?ay9SQmcxRnlaTytZakkrY2VzaXBFYVFFbVpwREdtbTgwNjN1MWYwa25zSk1t?= =?utf-8?B?dGtvVFdMTHA5bEJhN0FCckM0aU93THdoWTJoUUJjYS9aYmpabm9QNFJPdERa?= =?utf-8?B?VGdPNHF5L0UyVUZQQXRMNHNablljTVBPNmxNcURhaFVhTUdxeVBiWTl0cm41?= =?utf-8?B?akJVUkd2aWpVQXZ6NVduV0tJZHR0YTd4ZEZHRGE2eVhyZUpsd2dTRlJrNERh?= =?utf-8?B?c3d1alF1aGs2Z2I3VjhYWnFJeVVsUFI3ejlETC9xWlJ4eUQvdi9nbXRsQk02?= =?utf-8?B?c0cxNmcxN0FoK2RWRUsrcGV0MkoyVUI5RXU2TzY2QjdadkVNKzRxdjFiYXVk?= =?utf-8?B?dmUrMkdKbFRLOTIyK0VjK3JQc09JRExSbHEzR1NtWE1oSXVZaEpzUS9LSldU?= =?utf-8?B?MWYyUWI3YUxHNzZqRVFEUDR0NVFrNmg4Z2ZrUHd3Mnl5UUxTYTlpbG1uRk4y?= =?utf-8?B?S25NUFF0dllSN3FOc0ZrYUluSjZ3WlIyUEF6Uldsd0VmZWNxa3BNMkkwUjFi?= =?utf-8?B?dUZCZ2R0NDN4cnlMWTlYRU5Ia0VyWGsrbzdLRmhpU0VPdXR3VGZrL3JJdlNO?= =?utf-8?B?M1pwSUIzeTl1UzhKb1d0ZnA0ek1IVkMrdlhYUFZpaGw5cGpoYVhYbEx6OHhw?= =?utf-8?B?b2MwdVFIZ3pxR1hUTmtmc2hqT3I1ZFJobjh1ZzNpU21yVkcySTh6TE41cG9o?= =?utf-8?B?WjhGT2lYWXEyUzRwRno3MlJxTHBOWU43MDdkSGpYd2swZ1FFRms3MHdiQkxZ?= =?utf-8?B?dys2OFFQV1YxckI4eTlCT0s2S0wwZEh4ZSt1ZURtOWU2Wk1pRVJNUzBiVlcw?= =?utf-8?B?dHR5UDNIaWhrc0tiSDYwelVoblFFNWtMOE1sUHJici9RK2VJTEdwZjRHNEEr?= =?utf-8?B?N3pjUDJVWFEzMFM2UXFXTUZoNVBZNndwM1FSOC83L2diSmpEamhQeldFeFJ2?= =?utf-8?B?NGVaVXBubGpGa2lyQnR4cXB6SWY0RGMyVXRBakxmc1VNWG5oYk80V09TM0E5?= =?utf-8?B?Vmw0cHRENFlRbUVSbTFRWW0wTER5a3piY0tObVFrWVdTK25zSEVQd3dhSmM1?= =?utf-8?B?NTNzQy9ydGg5Y0IzZlJMQmVFZXdXRlFJWEE1cWtJNzY2dlhCQi8xM3NlN2ZB?= =?utf-8?B?cTF6a1ozbVVxU09rWFJxQ2VpSmJHSlpRM2hTM2tpTjFJUFZLODl6UnFTMW1T?= =?utf-8?B?d2RDUWZ5OEkvREtqV0dXRG8ralZNeGFqNi9Jci9SMS83REp0TURzWURwOThy?= =?utf-8?B?cFVXSjBuQzVPMHRSMWY3MUV2NnlQOHBjYkJFc1loTlUwMThtclZ4WnFpVkZq?= =?utf-8?B?cUx4QWVvVXQ2YldKUjNudVErdExNLzIwSTNQUlAvTndoc2lXWEliUElxeStD?= =?utf-8?B?c0RyaTZpUCtlVGdSWExGMndReTJwR2tPdkQ3Tzhnc281VDBOQTcyd1JjUHNN?= =?utf-8?B?KzJBVGY3bDRHSHBEck5DZHhhTExzaXIwOEZpSExBMHlWU3ZlTTJYM0ZzUGsy?= =?utf-8?B?OGdqMTlNZmE1cmJ1d2UwV3lrRktOa0tjWlptOE4wSXk4TEpTaVAvOHU2OVRp?= =?utf-8?B?dkZ2NkhUWnRnNHc0MlZqRWZPMXZyQ0RqZkZJdzByanE2WktuYmFBNU9nSkhW?= =?utf-8?B?b3ZEd0FzZ1VFN3d4d1ZkZ1dLc2FvVC9vT3Jxb3J6amwxY0VTKzF2QnR1Rjlh?= =?utf-8?B?SVZHb2RZY1BMMkpEZm9lNEdPRk16WHFjaGtiM1hXaHpBMUJSVGc0OEVGMVZz?= =?utf-8?Q?C7R6XtlMgqpWqxaPucqw0fK2Z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce77d0e-029f-45bf-4ffb-08db06dc3e8b X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3008.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 18:18:41.8383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hplapq9OlQfIkken7qfEy722iAHSFX/7S9qwN4M87S4p6Fpz6aAz7UUj/+KexpyWdMvkmhrigd7/siHM7ASFoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5273 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: hp4j8txjn7i1yb59mraea9auw5tczmhu X-Rspamd-Queue-Id: B1F3040005 X-HE-Tag: 1675534724-458689 X-HE-Meta: U2FsdGVkX1+j9U/WOIGIX6u/TVtpZvYrtts9DHzlZZJFYrFn5st0jM1JWuMyMY8VvddRkQYIV1k04CGEP9Bj3O1tQEJUxh7jXBSm3HMblO/IquZ5GtjwdwqXZO1J9GyklTArM2ropjyMmoq1eThxZOU4W7Nk8f8EsfACCNg6QmG2lUv1NeiRUcLPL8KOR9d/wbhINNvNB8PM552n6fiMEyqA5advwqV33scIgt7iHnxqWcbJS84e537FB5nyK1lSP4SiFMExU557W8YeDMOhMfDuKEK5b3nDdMYY233eWO3RcTcGZhlhZCrJ+HJL++OcLNScrDMyI3dFJ+e/MhG9yP0+uQQwJHXFQCGJxwBNg//17YR7Edpu6O4F5rD/Tm/DJPw4bCSvh+33xPZBHE32xuDj4oz1ZnRA7uJZUCf7DiwapHXeAO+nitcGB4R27KcD0tvuGp/W2MXL5lfAbljEAGpMyrsomKBnTn445/Dr5th/afGmE/VAqCdCa3TsjwNvP3Q9HqKcI6KvsAf/zIDAwXts+0owcY3IZiPcBu6+ngdT5q7fFMyPfr+3JQBW+Q5cOGuiU77GOkADOnDtdAjbe0EPLA29ZPCtWkmuxSWdwzrcbEFLXTkRYommtjBEe19nBokaAMWfW11XkdMovyaGDWZbsODVpvFR0WesPCwGqezVg/vOX52Ek14s02R16Ql5No0K6QEEx4fxTGI4sJx/EW5SLbVWtDDoVj+khpJPmL9+9JN/vwNf70Nm4C93oGyJXcj7Zkdh2lPO8AtusonKdOT9H6W7EttDnnyQ9P3Loc2IY/m1V7sXOT2QfyAPjUXuj/PdgA1Bl1NxXbfPI4GfEw3hsg18LCI5gJziK59LDP/u3r7a8452yHxBb7+3l21DX1koZ23gw5s5m1dQSZJXf9If0Met2k2O/K/jIUb57T6d59MpHoOyWMT26HVWUOdwSoFclEOk9uJZlS7CyCm 73NS6zbF IB48yV+C/iX9fnAiKsqdA6zP0C/lZCTHggPJUlL7gcIwapRqx19l/7TWbKOrVkInfx+y/t10Xr3FYAMnxlwWscrRurRbb/AmcXd32dR/eZzqvugxfP6AH1eCwEnDUAvi56bP3BYm3pJ9iR+8ohHpNZu7OB52FsX6HmtsVAQ6KU6VuQhucbCmE6ihO4JSPXfjzuOJ3TfQ4bbuf2OI38IZqtLf0kyT0c2YDbq9T94Yka3P630+93GrNoqAB9NX0ljeTW/m3umrwPposD8mXeoPC0lfMRvOJEsP3sDlaOOvByptNkDXeuDw1zURSjbp2fVkwzDnLP8Ky+OnZNn2VK7l5Jj+UZb356lSkEceViEiqbHHWi8ihgOr3WhaGMu75quDnKySzaMoBs4IeFNwtWwNZP+gXuGbt3IAw5JrT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/3/2023 4:57 PM, Peter Zijlstra wrote: > On Fri, Feb 03, 2023 at 12:15:48PM +0100, Peter Zijlstra wrote: > >>> +static inline void vma_set_active_pid_bit(struct vm_area_struct *vma) >>> +{ >>> + unsigned int active_pid_bit; >>> + >>> + if (vma->numab) { >>> + active_pid_bit = current->pid % BITS_PER_LONG; >>> + vma->numab->accessing_pids |= 1UL << active_pid_bit; >>> + } >>> +} >> >> Perhaps: >> >> if (vma->numab) >> __set_bit(current->pid % BITS_PER_LONG, &vma->numab->pids); >> >> ? >> >> Or maybe even: >> >> bit = current->pid % BITS_PER_LONG; >> if (vma->numab && !__test_bit(bit, &vma->numab->pids)) >> __set_bit(bit, &vma->numab->pids); >> > > The alternative to just taking the low n bits is to use: > > hash_32(current->pid, BITS_PER_LONG) > > That mixes things up a bit. Good idea, when we have workloads that creates lesser number of threads faster, current solution might have been simpler, but with thread creation that happens over period of time hash function mixes and avoids collision. will experiment with this option.