From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48F7C7EE23 for ; Mon, 22 May 2023 07:27:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B7D900002; Mon, 22 May 2023 03:27:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BA386B0075; Mon, 22 May 2023 03:27:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 582AD900002; Mon, 22 May 2023 03:27:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45DE66B0074 for ; Mon, 22 May 2023 03:27:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0E2B8A02E1 for ; Mon, 22 May 2023 07:27:21 +0000 (UTC) X-FDA: 80817060282.15.9BEF5F0 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf17.hostedemail.com (Postfix) with ESMTP id 093FA40015 for ; Mon, 22 May 2023 07:27:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="fM+/hnIJ"; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684740438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ye1aYEuIFNfv2NxsNvtn+fUja3/DYESm+lSDId7JG3g=; b=b8T9jPHGB9mzaGqRTbdhKYO9tEuaaHARzkBeDwQLMenDv4SxIK69zZenpIhxDqwSiANsor sSdK6mShbGuPVORMSN00EhIvT1zTLYsdBa9VWiKIUvw6xZ3vSQdi/9mOniYlQ/GUzwPMoM rQsLpPGJjcVcTIWLN6cMJFL0AMEh8CY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="fM+/hnIJ"; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684740438; a=rsa-sha256; cv=none; b=Yax+SBqvCUgpZpmODLGfxN7PFEKv/NAeE4jiuIVm9bzdjbiaUoqzJePs0gwDi6jNadWzQM a8+lLfy01JqC8qtf7HnLY96/76+Lq6clZmSdrob7jfUJdDSmTN/dNAWjmQXvs6UqkVjuTz w6XOY0NWt9mbaR3M8+rGXpdLrm2OPYU= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3f427118644so56399515e9.0 for ; Mon, 22 May 2023 00:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684740436; x=1687332436; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ye1aYEuIFNfv2NxsNvtn+fUja3/DYESm+lSDId7JG3g=; b=fM+/hnIJV7bCdtGbRxg5kYbtSIChX4OadVUC2pc9Vd1xRAXocmoKtL8t9SU6mj/vXu S/6kvYBACzXDB8A8oYwQ7Ulcs2IoWyGAEIjqyJctkLyqAk/K/zkpi2sQejz9TajVUr1r N6ugp3qec7BJKWublpUzBBUDQVeV16x537tY0LmSjmfMjrPKjGV454r0r0fNuvwV04UJ SPNp0I5ZsRiL/nIsLY2KzzqXkl8LTr06dnqvhzn9INcjsQ3+54WT5Kvygel32cSoJFM0 tHt0BsQ4hBlyctoORNxqGqoMZE8zN8ghGfE218GBOZvyM2Kg+LnX2evBrRecEOfmx1HB 0TNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684740436; x=1687332436; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ye1aYEuIFNfv2NxsNvtn+fUja3/DYESm+lSDId7JG3g=; b=SJLGokegEtvXEqgnFHHs06w7zxNR0INfSutpBVUilHt+hq2Rgm29/mKEHd3o2odHM1 bkoSNlO8qkj7FQD3K1myGAe1t3RLI/N0khbiEtkxkJfN5Pawg8rDWLi+JSezp7pQgtE7 iqXnW0vuFJ0/2XYyiV3kkv1U0VRLE69TmvkR+cP+4XmkHDew0eHa5sFcu4qlOOZNt6aJ maZMbRUUqevT6VHSjpt3SVxsLJrvNFOzDOeGHxjcfwEpNukELvKaogARKq1dt11NMFJD Sow5XD6ISmBwQIj5BcDp87se7gKhSPuDXbeIch8ey4Bbbx3VgFlI1BpFfDPTrjfCOO1F LmnA== X-Gm-Message-State: AC+VfDys0pxEyvLGytVJOv/QO8vRgfCPN3JUKs5fsP0HeIjEw3Oe029r RiprfnCbdOKRFAPYmYo6x50= X-Google-Smtp-Source: ACHHUZ4SbtkKO/UwJfOigndDknmL2Qog0yMPkICRdcXrohQLWFSR7FqbX38hgEnibAap2Ylw9zWmow== X-Received: by 2002:a1c:4b08:0:b0:3f5:bc8:e398 with SMTP id y8-20020a1c4b08000000b003f50bc8e398mr6850864wma.13.1684740436168; Mon, 22 May 2023 00:27:16 -0700 (PDT) Received: from localhost (host81-154-179-160.range81-154.btcentralplus.com. [81.154.179.160]) by smtp.gmail.com with ESMTPSA id m17-20020a7bcb91000000b003f6050d35c9sm1742602wmi.20.2023.05.22.00.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 00:27:14 -0700 (PDT) Date: Mon, 22 May 2023 08:27:14 +0100 From: Lorenzo Stoakes To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 12/31] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: <8c744725-5f58-4656-823b-997a302085f6@lucifer.local> References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 093FA40015 X-Rspam-User: X-Stat-Signature: 4aqy3b9jdsb9uoon8zho9co71oxcwadf X-Rspamd-Server: rspam01 X-HE-Tag: 1684740437-579352 X-HE-Meta: U2FsdGVkX1/JtoRAjkEfjextqz/JdxiqelxSLBqo4SED8iIaLdidkwD8G0/V0Zc5ZyTjZnHfAS5t4lP3Qq2MOUfLQbGY4Z3p2OSCUrla+BGvbWTs8Q3Ps1J5t8Ga4mWA/65TchCbmAm9FhQCmod/KP6hIZW8DuXgOajqbAIynCkGpN4RKW4NYfRlBDrfr9XjGdVcc1YwBPSVkXSz2oX/W3/hxMsdGGGrCsIs/9PsHXQxQAZoYoHM7xgY+BPZBpJr8Zt+81qY0/T9cZrkRtoUqUqRUrLjoXrslSktEO811iCUzBSaED1pKDV2Easvf4H5pRAzsFhzs7ECLQRexB+vEj1i1z7o0gGbi1vye5aWJX2vMv06K1SaLX5+l5qzzEuJrsOgwkXTjvoZDXUZkAgcqD2jAE0eMaGAV1tkpFK9wo3cImpUxRk7U/1sAp1TXb1gmTQyeLyAtCQj1TWtrcC0UGKvBMrmYDZnSqGh5lJ5KFI82ZxgZSSYmTuqKN062jpcj4idLMVlzb0ErRKOflh6unjwUmtqfy5kh9i1z47RqPq3I/McUhAF5/l83m6geZPV2pasxsu57Oo7lLODFjKbJLvsZnm/wFyWVlpf24+dOfj3+xOnW6vS8LhC3zSsKtYYPr4eduC0Ho7c03QtNenA/jh07nVGTEthymr0GlX54FPdPQ/U+V3RHeXOiBhlerq8SKDcd80SH4Afy3q2sNfmK1EyQSVEm3dY2Oq5I5imFzJXXYCgwSijeY9uk181THPmiKfEizYgoxsTDWRQroQVuIj1pTYdE3VcXsd/YsibjIc4tIVJ8rpuUYpidPaFQlSpEgxLQ20OuNGYHsiQBuFmvgxjXiIKdIDYdhh0NIde6pfCPdESGXePcg0oHsQ4mf8a83r2n/RT5K0xN8UdrQCMtjDI1ooedOmwQtvySmszP35n05aiKPejaDJe+DSuiDvnH7QpTw3GMqg9vZ1y0Gz Jg9AbmlK YxNc22ZiFqX7zCvcqHOj0JEIMarb07z8Syxst9jkkA3IX+RUUgDN/VUWM0rqQl8wvFlYTCU6raiwH1nkeIqwWfj+Ud0bttoq8xFmcC6ggx6DudB03cdgyAHGOxtF5yEuRkpXILbMdeoHmmq1D7T+3AVTvN1pEN7zV/5Dvt1p4IH5+ZWtidvLhhP34GE22JMYocVpXsgIYd8xqhMQ8uKXdDxFtmv4kBKBCJpjNhngtAF6r4kTDD8kxyLZ1RWStzcFgP38q6RtglXut3f7jUbEh0svHpLFk4+2SyuNEhy3W4vAcLclTj0RrHu57MiWGGXacxccdy7w/05AR8R7RnGnJkvgCAsUEyYH08ucuuGtCvaQPNo15S09FwfK4sLMg5dhjp8idIrz8WRFfMguNqTB/XVZid7gZyMolTxH8PZiRkbHJuBpWmz5ezbCyn+yJxFmhqTFqZ83VAflXmtgWfaywusX7iJ4vLc6LMYYUjcsjbmXzDVE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 21, 2023 at 10:04:07PM -0700, Hugh Dickins wrote: > vmalloc_to_page() was using pte_offset_map() (followed by pte_unmap()), > but it's intended for userspace page tables: prefer pte_offset_kernel(). > > Signed-off-by: Hugh Dickins > --- > mm/vmalloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 9683573f1225..741722d247d5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -703,11 +703,10 @@ struct page *vmalloc_to_page(const void *vmalloc_addr) > if (WARN_ON_ONCE(pmd_bad(*pmd))) > return NULL; > > - ptep = pte_offset_map(pmd, addr); > + ptep = pte_offset_kernel(pmd, addr); > pte = *ptep; > if (pte_present(pte)) > page = pte_page(pte); > - pte_unmap(ptep); > > return page; > } > -- > 2.35.3 > Looks good to me, Reviewed-by: Lorenzo Stoakes