From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80AFFC433EF for ; Mon, 30 May 2022 06:55:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B57A78D0003; Mon, 30 May 2022 02:54:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B03018D0001; Mon, 30 May 2022 02:54:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F1BB8D0003; Mon, 30 May 2022 02:54:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 911728D0001 for ; Mon, 30 May 2022 02:54:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 4F6F180DDC for ; Mon, 30 May 2022 06:54:59 +0000 (UTC) X-FDA: 79521497118.26.D1D1088 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 068E3C0044 for ; Mon, 30 May 2022 06:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653893697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cW5xo99K8NrpbNwecJUSYiEDfaIs12UK7aKWMx8Wt/A=; b=LVd39jHsGx6mo6IJOjkDDwkiwIRsrL9zmaKVVMrYVvbA4/sxQIvDu4UMv1faiZrxA+Jalm PPdVylsSg4kOkiqGXywwW14wtAVEX3oFYeBLCdmZolvNMKp9faqWvbK6w4aGjJhgK4TqFb U2MT4aqzeKfkPFNID0VgoeV6HwAVhk4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-399-mvqRq46KORu4rCFNatubkg-1; Mon, 30 May 2022 02:54:56 -0400 X-MC-Unique: mvqRq46KORu4rCFNatubkg-1 Received: by mail-wr1-f70.google.com with SMTP id e6-20020adfef06000000b0020d08e465e2so1375779wro.3 for ; Sun, 29 May 2022 23:54:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=cW5xo99K8NrpbNwecJUSYiEDfaIs12UK7aKWMx8Wt/A=; b=8QdGpOZoQ/5PIcZiDkXFSRbUDOrravZLtUeAThX7TowvQ8+lVywCZZsWy0EUerP6Cd v5GUjZCXDAPcZXXfCAgh4b7+mBoHOH1VWQSQqjHSF6B01wI23+RCWKD87d1KY9eCvjhd 9uQcEDd1Ydp5CyJx64NIYWbCP1jor0NYLS3eTa3dhOxgndhw3L2s37SjtZdpB0QiBSlZ 32JxQ+VZTCjrQz503riGKfH9tjTwCHnSW2U031heIfC62hxzGHOQtEu57c9CVGiHzvXi 01N1o8j17PHB5jcca3A8ifiFF1eqwRwd2Eu+MJTN0ObXiQ8pZdlkq4rAkA4A1Ll/XT6+ bTDA== X-Gm-Message-State: AOAM532eddSR5TAy+jUNQGPLfo28x97oZFV/QZf+yufRtmdaiMtqWj5Y k7lNrNCqeW9oX0CRbnN/hhqQylq6vO45YjYQp9PptoGbFF0agkoJXnvpdvR7k77Df83xR4Rt3nb HFeKdPAJWVTo= X-Received: by 2002:a05:6000:348:b0:210:323c:769a with SMTP id e8-20020a056000034800b00210323c769amr3647049wre.411.1653893694923; Sun, 29 May 2022 23:54:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyICxlknhx3Jy2L9ApC8AN3s3zIcSZThNHOhs6y6eptBkQeGBfv0C8nT+vtfVHYxEDjG14G0g== X-Received: by 2002:a05:6000:348:b0:210:323c:769a with SMTP id e8-20020a056000034800b00210323c769amr3647039wre.411.1653893694715; Sun, 29 May 2022 23:54:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:7c00:aaa9:2ce5:5aa0:f736? (p200300cbc7047c00aaa92ce55aa0f736.dip0.t-ipconnect.de. [2003:cb:c704:7c00:aaa9:2ce5:5aa0:f736]) by smtp.gmail.com with ESMTPSA id m19-20020a7bca53000000b003942a244ee6sm9038107wml.43.2022.05.29.23.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 23:54:54 -0700 (PDT) Message-ID: <8c5c5bd6-fea6-4c27-9a84-4b9c937068d7@redhat.com> Date: Mon, 30 May 2022 08:54:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V2] mm/memory_hotplug: Drop 'reason' argument from check_pfn_span() To: Anshuman Khandual , linux-mm@kvack.org Cc: Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org References: <20220526021258.4030749-1-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220526021258.4030749-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 068E3C0044 X-Stat-Signature: nwohmp9nwcdymjfe47qe74gzk5exdjm4 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LVd39jHs; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam09 X-HE-Tag: 1653893660-833493 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.05.22 04:12, Anshuman Khandual wrote: > In check_pfn_span(), a 'reason' string is being used to recreate the caller > function name, while printing the warning message. It is really unnecessary > as the warning message could just be printed inside the caller depending on > the return code. Currently there are just two callers for check_pfn_span() > i.e __add_pages() and __remove_pages(). Let's clean this up. > > Cc: Oscar Salvador > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > Changes in V2: > > - Fixed typo in commit message > - Dropped using 'ret' to capture check_pfn_span() return value in __add_pages() > > Changes in V1: > > https://lore.kernel.org/all/20220525033910.3781764-1-anshuman.khandual@arm.com/ > > mm/memory_hotplug.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 416b38ca8def..3b24386e9276 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -220,8 +220,7 @@ static void release_memory_resource(struct resource *res) > kfree(res); > } > > -static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > - const char *reason) > +static int check_pfn_span(unsigned long pfn, unsigned long nr_pages) > { > /* > * Disallow all operations smaller than a sub-section and only > @@ -238,12 +237,8 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > min_align = PAGES_PER_SUBSECTION; > else > min_align = PAGES_PER_SECTION; > - if (!IS_ALIGNED(pfn, min_align) > - || !IS_ALIGNED(nr_pages, min_align)) { > - WARN(1, "Misaligned __%s_pages start: %#lx end: #%lx\n", > - reason, pfn, pfn + nr_pages - 1); > + if (!IS_ALIGNED(pfn, min_align) || !IS_ALIGNED(nr_pages, min_align)) We could do if (!IS_ALIGNED(pfn | nr_pages, min_align)) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb