From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2ED7C433E2 for ; Tue, 14 Jul 2020 03:57:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5752621927 for ; Tue, 14 Jul 2020 03:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5752621927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8DF5F8D0003; Mon, 13 Jul 2020 23:57:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88FCD8D0001; Mon, 13 Jul 2020 23:57:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A5888D0003; Mon, 13 Jul 2020 23:57:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 65E7C8D0001 for ; Mon, 13 Jul 2020 23:57:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D43552DFA for ; Tue, 14 Jul 2020 03:57:01 +0000 (UTC) X-FDA: 77035320642.01.plant82_570849226eed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id BA768200036F8B54 for ; Tue, 14 Jul 2020 03:57:01 +0000 (UTC) X-HE-Tag: plant82_570849226eed X-Filterd-Recvd-Size: 2393 Received: from huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 03:57:00 +0000 (UTC) Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id C12B550CB0D45E4271B0; Tue, 14 Jul 2020 11:56:57 +0800 (CST) Received: from dggeme701-chm.china.huawei.com (10.1.199.97) by DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 14 Jul 2020 11:55:57 +0800 Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme701-chm.china.huawei.com (10.1.199.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Tue, 14 Jul 2020 11:55:57 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Tue, 14 Jul 2020 11:55:57 +0800 From: linmiaohe To: Andrew Morton CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm: mmap: Merge vma after call_mmap() if possible Thread-Topic: [PATCH] mm: mmap: Merge vma after call_mmap() if possible Thread-Index: AdZZkbhDr0LDae6gQR+szjsfPzuWPw== Date: Tue, 14 Jul 2020 03:55:56 +0000 Message-ID: <8c56c567495149fdba97c7931ac4492d@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.109] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BA768200036F8B54 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton wrote: > On Tue, 14 Jul 2020 11:07:44 +0800 linmiaohe wrote= : > >> The vm_flags may be changed after call_mmap() because drivers may set=20 >> some flags for their own purpose. As a result, we failed to merge the=20 >> adjacent vma due to the different vm_flags as userspace can't pass in th= e same one. >> Try to merge vma after call_mmap() to fix this issue. > >Which drivers do this? I searched the code and I see many drivers change the vm_flags, such as aio= _ring_mmap set VM_DONTEXPAND and amdgpu_mmap , binder_mmap also change the vm_flags , and = so on... Thanks.