From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5DBC5479D for ; Tue, 10 Jan 2023 03:03:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DFF68E0003; Mon, 9 Jan 2023 22:03:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28FED8E0001; Mon, 9 Jan 2023 22:03:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 157BB8E0003; Mon, 9 Jan 2023 22:03:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 079BD8E0001 for ; Mon, 9 Jan 2023 22:03:40 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CC69BADCD5 for ; Tue, 10 Jan 2023 03:03:39 +0000 (UTC) X-FDA: 80337394158.03.52D6017 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf25.hostedemail.com (Postfix) with ESMTP id 10CC6A000A for ; Tue, 10 Jan 2023 03:03:37 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hMJOr7gx; spf=pass (imf25.hostedemail.com: domain of jiangqi903@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=jiangqi903@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673319818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ie+rQH3mw2D5QoODuQ+CCdhtheNQpe0s3cmjyE1gSeQ=; b=MUM4rWM4qrDHOE+tjjV2KhBcBkvvGZfuxHsElnQ5Hw5zc+NolWNaERVdeQMeWMHyYckSIc 5i9Y0ysIAV4RWUREyDh6nxWt+ZkTwz+ppYVYMT6fR5Wr4tNOWx6HdUyYi5Uinr+n3JrtVL TpCLml2tT9QBHsMjBY1R3kd7CvQJgxg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hMJOr7gx; spf=pass (imf25.hostedemail.com: domain of jiangqi903@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=jiangqi903@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673319818; a=rsa-sha256; cv=none; b=hMUJbLt33FbpBOIOSzWYqSARhh+Z6ucFnnslo21YAmnQhBgkBj7F7NbvOxscCDmOdUzzUs 7AjAZRw3RuRziY4S3jjcCPO9u8IoTDBfxguJNrMDpbtfAj5JnPTe8u5pk09w1dJE+XVd5Q AJyngVXzPYvx2I2JaLHhxLyQHNZr5yY= Received: by mail-pf1-f171.google.com with SMTP id c26so3307914pfp.10 for ; Mon, 09 Jan 2023 19:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ie+rQH3mw2D5QoODuQ+CCdhtheNQpe0s3cmjyE1gSeQ=; b=hMJOr7gxNfRVXvptQWjnS8gggJmoU39dG01sMuSVgD+06ybLXZxq90y4dy3c96NbGF 4ZT28Zq5UNherNLr00lPvH90N3EtrGwKCZ5w+s+Nk7G+2SJ6ZKT+sq5tu3EE3ULu3Kzw Tm1vipafgC4nL3i2C3ESwkGPiXyNWjk+DYNU5oYqzgFvUp2yw2WsLbuNqo2V0DWUVU/R 4Q3HdEc6KdveDXPof/4iD/sv+HhtzWh5llcfA936NmkiAVO0yiQADoU9L8RAKYAkCMXx OowkMMJOMwmhX7BhL3tGmOP0dsjKWzhGNwVwtSMWuQP00OtD1lRZF8xUGLuC3jp0h/rG Im3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ie+rQH3mw2D5QoODuQ+CCdhtheNQpe0s3cmjyE1gSeQ=; b=aAPPibvx2y8rR5rOktA9IMj3XjNftKNrTCLVV4PoyCoZgc/zU07gZNIdZSajT2AIno 4WyUFs6a1vhosn5II5hSrzCL4f8wRFkpkAS78/oJVKiz/t/w1264Tr57GT8Bp/vf5Zf0 1QqbunGL3ipHVdqpT5652x9eveoB1A9K9acMGkK6c69deGlJexxfZFac2sNX/PKqL5MY VLUrJSmyasQwnZgLID0T4GKi77d5ZuIEehujoUuTjhKJSxOXIpEjker/Hm70v4X2uhyh Qa5wjpsRCPiW7piV6cJv4fGA+O1FhWa8wHnYw3dSokZLQ8XGmTqMOjLSvsXOs8vsQs9m +0CQ== X-Gm-Message-State: AFqh2koDxvfm25QJJ2a7SvuLCVczKzUHcmfYWrScGehFDwhxta8Te174 MRxbD3zS+cblmr9kwzdwovg= X-Google-Smtp-Source: AMrXdXvJDNVJzGLOc0X2GvVwdFjI8RfAavc5gUlJ2WeGpNuCy2JjwDpIY0RBpj1yDjgL50FOUueSBQ== X-Received: by 2002:a05:6a00:2281:b0:581:a8dc:8f95 with SMTP id f1-20020a056a00228100b00581a8dc8f95mr53203339pfe.12.1673319816855; Mon, 09 Jan 2023 19:03:36 -0800 (PST) Received: from [30.221.133.30] ([47.246.101.62]) by smtp.gmail.com with ESMTPSA id y12-20020a62640c000000b005819313269csm6749208pfb.124.2023.01.09.19.03.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 19:03:36 -0800 (PST) Message-ID: <8c4cbb93-cba5-82b4-74c5-0ff1dcc214a1@gmail.com> Date: Tue, 10 Jan 2023 11:03:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Ocfs2-devel] [PATCH 6/7] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Content-Language: en-US To: Christoph Hellwig , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-7-hch@lst.de> From: Joseph Qi In-Reply-To: <20230108165645.381077-7-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 10CC6A000A X-Stat-Signature: 5pbtodni8dbbeypjqj441eytj6wyz4cj X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673319817-818439 X-HE-Meta: U2FsdGVkX19R4BKdqwOJZGB2c8NNLcZQygb3Tau/24KFKEAj/oc8/dfaiEMsrP3UA/AJ1/OBuaeq3mXa844gRL+vjv5ZL9qgdWSLDpvGHQxlDoxpeFQZFxi8T8OStvhccSFof6NkV0UqHoTbSKXvYiyMPm6nQAtDgzHSMPvj3iSU7ErjTZJFr8OGT6xWnCLSRsX/OWrsqlthsQeUnCsb/YlpOjashBXqO3hj2eE6E15oRNsm3oJ4s7kiNVpBf3Pgu15Xv5VLid6MnVB1JpmO5kdA/pBVogNTh05cnkWdYR0Ga5jC3IzH8uFVeNZkYY4v9TD5E2IyZJj8jN9HLVDyx/27BpTusDHoMtRIpA2DTSy85kbnbd3RXPZGwXB4NLpW7Xv9OZPzCduQgCPmStk5YQ0XqHFjcG/IV2VZro5l0mC4hlNyblezw5JD5HJxzPqwKUBP3r/GkZcNawhWV9SfB5PduiojgEcIe+2r4IF6i2jMiNLnJ5RBU077g8BLn2zFXrFYHNK8+2qy9Dk/5A1hReduqLKgaVKlz+ljD3yOhw2obF53fcpiSEeLqZc0ohcFC2jY/m7A9wTIfs8y0dLVwMvf9NAwQoEpyuOqd8ZpppEcdQ1sHsu5F31pfXqjXaaq8dVErmvzFAuL5nT2wndmEh1zhnGM3rt+N3yrV2Rk4t3MlTUsNNL7p8dl91UMIboRyqlhw4PYoNHBq8wOfnOvCaIdVcEOppHOedAUns6jUQ6Oj+1UvZnoMYNTA2eXIgLGWaz+y3df9BeDmlaRwYvcbJX7hIsaAa8viJEr0ZcSkSjiZ4AJ9hK2CYlD2D31n86y64elDC+0/WOL7/t3UDoJpT5K30oCpyCIbH1MwggEqQYaJojkfNkXLeHIHYY7Kw1scdSHutKlZp8RfMxaoC+bff2m2qJRy9fOrXd5EbEoVZXj7Me+I3g++bdqOEK+fXOuOYgHv+2paDN3EB5Fe7C SpWEAXKj +qhP3IwXtYiVDikj3wde7s/2qlmmOoHEgvKdQBBwnGX/dO1E3SRG4bz98Hqsev16MOQ7T5qLP8rqr3+/eliX2Cjts7MW0bXzozDKYp+/nKF0fVFgmT3RYdXZMzFeAfDjcV2dSSet32Bog7rs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/9/23 12:56 AM, Christoph Hellwig via Ocfs2-devel wrote: > Use filemap_write_and_wait_range to write back the range of the dirty > page instead of write_one_page in preparation of removing write_one_page > and eventually ->writepage. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Joseph Qi > --- > fs/ocfs2/refcounttree.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c > index 623db358b1efa8..4a73405962ec4f 100644 > --- a/fs/ocfs2/refcounttree.c > +++ b/fs/ocfs2/refcounttree.c > @@ -2952,10 +2952,11 @@ int ocfs2_duplicate_clusters_by_page(handle_t *handle, > */ > if (PAGE_SIZE <= OCFS2_SB(sb)->s_clustersize) { > if (PageDirty(page)) { > - /* > - * write_on_page will unlock the page on return > - */ > - ret = write_one_page(page); > + unlock_page(page); > + put_page(page); > + > + ret = filemap_write_and_wait_range(mapping, > + offset, map_end - 1); > goto retry; > } > }