From: David Hildenbrand <david@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
Kyle Meyer <kyle.meyer@hpe.com>,
akpm@linux-foundation.org, corbet@lwn.net, linmiaohe@huawei.com,
shuah@kernel.org, tony.luck@intel.com, jane.chu@oracle.com,
jiaqiyan@google.com
Cc: Liam.Howlett@oracle.com, bp@alien8.de, hannes@cmpxchg.org,
jack@suse.cz, joel.granados@kernel.org, laoar.shao@gmail.com,
lorenzo.stoakes@oracle.com, mclapinski@google.com,
mhocko@suse.com, nao.horiguchi@gmail.com, osalvador@suse.de,
rafael.j.wysocki@intel.com, rppt@kernel.org,
russ.anderson@hpe.com, shawn.fan@intel.com, surenb@google.com,
vbabka@suse.cz, linux-acpi@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/memory-failure: Support disabling soft offline for HugeTLB pages
Date: Wed, 17 Sep 2025 09:02:55 +0200 [thread overview]
Message-ID: <8c3188da-7078-4099-973a-1d0d74db2720@redhat.com> (raw)
In-Reply-To: <a99eb11f-a7ac-48a3-a671-c5f0f6b5b491@arm.com>
>> +
>> + 0 - Enable soft offline
>> + 1 - Disable soft offline for HugeTLB pages
>> +
>> +Supported values::
>> +
>> + 0 - Soft offline is disabled
>> + 1 - Soft offline is enabled
>> + 3 - Soft offline is enabled (disabled for HugeTLB pages)
>
> This looks very adhoc even though existing behavior is preserved.
>
> - Are HugeTLB pages the only page types to be considered ?
> - How the remaining bits here are going to be used later ?
>
What I proposed (that could be better documented here) is that all other
bits except the first one will be a disable mask when bit 0 is set.
2 - ... but yet disabled for hugetlb
4 - ... but yet disabled for $WHATEVER
8 - ... but yet disabled for $WHATEVERELSE
> Also without a bit-wise usage roadmap, is not changing a procfs
> interface (ABI) bit problematic ?
For now we failed setting it to values that are neither 0 or 1, IIUC
set_enable_soft_offline() correctly?
So there should not be any problem, or which scenario do you have in mind?
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-17 7:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 0:27 Kyle Meyer
2025-09-16 3:16 ` Andrew Morton
2025-09-16 7:14 ` Kyle Meyer
2025-09-16 15:20 ` Luck, Tony
2025-09-16 17:59 ` Kyle Meyer
2025-09-16 18:08 ` Luck, Tony
2025-09-17 6:35 ` Fan, Shawn
2025-09-17 18:59 ` Kyle Meyer
2025-09-18 8:34 ` Shuai Xue
2025-09-18 15:48 ` Jiaqi Yan
2025-09-16 10:12 ` Anshuman Khandual
2025-09-17 7:02 ` David Hildenbrand [this message]
2025-09-17 18:51 ` Kyle Meyer
2025-09-17 19:05 ` David Hildenbrand
2025-09-17 19:32 ` Jiaqi Yan
2025-09-17 19:54 ` Luck, Tony
2025-09-17 21:39 ` Kyle Meyer
2025-09-17 22:15 ` Jiaqi Yan
2025-09-21 11:36 ` Anshuman Khandual
2025-09-23 6:03 ` Kyle Meyer
2025-09-21 11:25 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c3188da-7078-4099-973a-1d0d74db2720@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jane.chu@oracle.com \
--cc=jiaqiyan@google.com \
--cc=joel.granados@kernel.org \
--cc=kyle.meyer@hpe.com \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mclapinski@google.com \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=rafael.j.wysocki@intel.com \
--cc=rppt@kernel.org \
--cc=russ.anderson@hpe.com \
--cc=shawn.fan@intel.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox