Re: [patch 13/15] mm/page_owner: align with pageblock_nr pages

[Vlastimil Babka <vbabka@suse.cz>]

On 11/30/2017 11:15 PM, akpm@linux-foundation.org wrote:
> From: zhong jiang <zhongjiang@huawei.com>
> Subject: mm/page_owner: align with pageblock_nr pages
> 
> When pfn_valid(pfn) returns false, pfn should be aligned with
> pageblock_nr_pages other than MAX_ORDER_NR_PAGES in init_pages_in_zone,
> because the skipped 2M may be valid pfn, as a result, early allocated
> count will not be accurate.
> 
> Link: http://lkml.kernel.org/r/1468938136-24228-1-git-send-email-zhongjiang@huawei.com
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

The author never responded and Michal Hocko basically NAKed it in
https://lkml.kernel.org/r/<20160812130727.GI3639@dhcp22.suse.cz>
I think we should drop it.

> ---
> 
>  mm/page_owner.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN mm/page_owner.c~mm-page_owner-align-with-pageblock_nr-pages mm/page_owner.c
> --- a/mm/page_owner.c~mm-page_owner-align-with-pageblock_nr-pages
> +++ a/mm/page_owner.c
> @@ -544,7 +544,7 @@ static void init_pages_in_zone(pg_data_t
>  	 */
>  	for (; pfn < end_pfn; ) {
>  		if (!pfn_valid(pfn)) {
> -			pfn = ALIGN(pfn + 1, MAX_ORDER_NR_PAGES);
> +			pfn = ALIGN(pfn + 1, pageblock_nr_pages);
>  			continue;
>  		}
>  
> _
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>