From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD33C433F5 for ; Fri, 10 Dec 2021 19:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89A066B0073; Fri, 10 Dec 2021 14:20:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8490C6B0074; Fri, 10 Dec 2021 14:20:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7112A6B0075; Fri, 10 Dec 2021 14:20:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay034.a.hostedemail.com [64.99.140.34]) by kanga.kvack.org (Postfix) with ESMTP id 62E796B0073 for ; Fri, 10 Dec 2021 14:20:38 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E1967D3 for ; Fri, 10 Dec 2021 19:20:28 +0000 (UTC) X-FDA: 78902850936.01.6E3C2A7 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf21.hostedemail.com (Postfix) with ESMTP id 2DF751C0008 for ; Fri, 10 Dec 2021 19:20:25 +0000 (UTC) Received: from fraeml704-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4J9ggb1zQSz67MYc; Sat, 11 Dec 2021 03:19:07 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml704-chm.china.huawei.com (10.206.15.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Fri, 10 Dec 2021 20:20:22 +0100 Received: from [10.47.93.58] (10.47.93.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 10 Dec 2021 19:20:22 +0000 Subject: Re: [PATCH v2 01/11] iommu/iova: Fix race between FQ timeout and teardown To: Robin Murphy , , CC: , , , , Xiongfeng Wang References: <03cbd9c4-0f11-895b-8eb5-1b75bb74d37c@huawei.com> <80145652-b9ca-57b5-ad95-ca12d6a25eea@arm.com> From: John Garry Message-ID: <8c29534f-ac90-6998-afd7-37b94a3ad3c2@huawei.com> Date: Fri, 10 Dec 2021 19:19:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <80145652-b9ca-57b5-ad95-ca12d6a25eea@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.47.93.58] X-ClientProxiedBy: lhreml723-chm.china.huawei.com (10.201.108.74) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2DF751C0008 X-Stat-Signature: spncb1mze1hh577d81o8iz5dx7rwtsdi Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com X-HE-Tag: 1639164025-489730 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/2021 18:13, Robin Murphy wrote: >>> possible for the timeout to expire just*before*  the del_timer() call >> >> super nit: "just*before*  the" - needs a whitespace before "before" :) > > Weird... the original patch file here and the copy received by lore via > linux-iommu look fine, gremlins in your MUA or delivery path perhaps? Right, apologies for that. I did receive it ok, but my replying seemed to mangle it. Not sure why.. Thanks, John