From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8AEC001DF for ; Tue, 1 Aug 2023 03:02:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADB822800D3; Mon, 31 Jul 2023 23:02:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8BEF2800C8; Mon, 31 Jul 2023 23:02:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A1AF2800D3; Mon, 31 Jul 2023 23:02:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E85B2800C8 for ; Mon, 31 Jul 2023 23:02:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 691661A0495 for ; Tue, 1 Aug 2023 03:02:58 +0000 (UTC) X-FDA: 81074038836.25.07C0F5A Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf11.hostedemail.com (Postfix) with ESMTP id D193D40019 for ; Tue, 1 Aug 2023 03:02:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690858976; a=rsa-sha256; cv=none; b=WRa9uxirvUuDMKYZV68Wq3WdZuhp1FfQP8xNCUk5gvV5GuzliqZ/vN4I0Qz4r/Zd7NPAlT Fg4Jgx7gwa+IIQ9wHwh2gj/SU0ng+eeUKShyrG+RfLyUgjvZSYfLWx9UexSKwhG4WYFFr5 /vkj+NHYHtLPmYGw+tqIQKeTnudPJq0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690858976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TEVVuCFQ42QfVoeFFOGaLMeULJPgHYM0xSkEd3rBSSI=; b=HWLhKZNSJhpsbwFRWkfJLfMHMBpZT7Y27SwF5fbmPAx1k99yBqfoa82HHzHbl4IDWfU+5B xrA/im3JWBSbRwu9z4BFsSuTCB4VZcRKh1696wyy7GP8lP3S1K5mbI8iG/A4ywT+2TKHDP DUR6lDYeCCbEpZVcevHMk6jzOczQGOU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VojZ4od_1690858938; Received: from 30.97.48.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VojZ4od_1690858938) by smtp.aliyun-inc.com; Tue, 01 Aug 2023 11:02:19 +0800 Message-ID: <8c265e65-10b0-1a81-fe9c-ae334162346e@linux.alibaba.com> Date: Tue, 1 Aug 2023 11:02:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-9-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230728171037.2219226-9-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D193D40019 X-Stat-Signature: ju3wr5pnqywkts8qjix51198kes4woa7 X-Rspam-User: X-HE-Tag: 1690858973-816435 X-HE-Meta: U2FsdGVkX1+t/vb2/FwbF88GW0kZQaEIfMsrZSrjmqPmJ6273VpNRn+c7v1+H60r0tEdgFE9kS3G03ARAsbb6UiIDq9ZrKpMjNG530grYO5j45XMHGDyHqaDGX9OtGAzn2mziH3VlYmyIKJF7Kra3oVs84nAPa2yiJ542y8HRKfrI46DTnb8+15R3En0csRQZzBndvvKk08hlCacaYtUWxVPTYfEq7gENYJ60u6/MZaUOJUGY2Wc5AEf4gYjIkdFDlPITd6b+V6UoininzEhtisDh57gouEIRgHugjp8gqrStAE/UTpnRqgWOfmzFPy66DqRGyA0BPzH19K+yIt5Jcu0T+OVuATUkmvk7IPljgreUqSIPCVSexsiNqfY/vK1Vnoz2DLS7k5CPvo2AoErUFeXwW36jOzjX+U+na3oDjKp23BI1j5RF1Ejtc1M2F1v7wSTxx/AltLO1BQ5C8QpfXj1yhVkfbmHlaxrc64TSkmu5FqqTQZqLbXGS3j9THryHI6H2a8/vSB0wmMmJeI7ZJVfKmtlMrBETNRAU3DeAA9vefACcTwZiL+64rSVmWycVIusrWLugD40nCMk9fepreLwSkNlAxx41R498owF3fx9mdD6vwTQkW+PF8y0rF5S0ChxWxD5tzgzqNtAArA3GYuZ7r+RO+76QYqkDtnYoTYCB/JLkLHkEPlWuIAR2o1NtXM0ZXfr3Wy96hotYkA2Xt+HQpncYzoa250hokDhvILT8vvYZG2VOCbHmqreH0VYV5xp0UGtYUb836e5ygYyObtTqeDFq0KI+rYbsif5nalXMnAdsGw0wpptFsdNZCxzbnCkckPt0PFylb5EShXIHCdZIxWFWHCdGtkmHgb0V9IAI9Cce3lWNPR9R0ilF+Ec3+G3c546TAJx6I6Y4j/R6Vnf4iFWSUuQGFOfnIV5De5YSOg2mopFmRwPQtL4IuGWPlYZYSyKDc+w9sJeDm8 BsfO2Yvc HQmSo38umHmwSUzcnywMqPKe7aAi9aKj/dDGmo+YwO9QdM0jWQ2h62FsvdWlinbau545d0ijy93+Z3zqpBTYIlxQ9ZOOswmIGHiBZTdV+Mb27ezEBVTNLd7cuKli7bXTmHmohsTlGDFlZmx4iKRnMtc4GHFL9XLb4ZuTe0IOQlUQKrETgqFTC7jTiW7N3/Id4cQD1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/29/2023 1:10 AM, Kemeng Shi wrote: > Keep the same logic as update_pageblock_skip, only set skip if > no_set_skip_hint is false which is more reasonable. Um, the fast_find_migrateblock() and fast_isolate_freepages() will rely on the skip flag and ignore the cc->no_set_skip_hint. So not sure it is helpful. Let's see if Mel has some input. > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 188d610eb3b6..6841c0496223 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1418,7 +1418,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); > > /* Skip this pageblock in the future as it's full or nearly full */ > - if (start_pfn == end_pfn) > + if (start_pfn == end_pfn && !cc->no_set_skip_hint) > set_pageblock_skip(page); > } >