From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6EDC433F5 for ; Fri, 13 May 2022 01:19:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A349A6B0073; Thu, 12 May 2022 21:19:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BA1D6B0075; Thu, 12 May 2022 21:19:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85BAE6B0078; Thu, 12 May 2022 21:19:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 73CC86B0073 for ; Thu, 12 May 2022 21:19:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4776820FCD for ; Fri, 13 May 2022 01:19:23 +0000 (UTC) X-FDA: 79458961806.09.8A3CAE0 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf19.hostedemail.com (Postfix) with ESMTP id 442881A00A9 for ; Fri, 13 May 2022 01:19:09 +0000 (UTC) Received: from [10.20.42.170] (unknown [10.20.42.170]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxGtgMsn1iyoQTAA--.10240S3; Fri, 13 May 2022 09:19:08 +0800 (CST) Message-ID: <8c1fc6d4-7d3a-85dd-ebd9-fc8e221f1878@loongson.cn> Date: Fri, 13 May 2022 09:19:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page Content-Language: en-US To: Andrew Morton , Peter Xu Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi References: <20220317065024.2635069-1-maobibo@loongson.cn> <3a441789-b3e4-236e-2e44-e7a1c7258a94@redhat.com> <20220512173620.2f5175c7a321e6ccea6e58e9@linux-foundation.org> From: maobibo In-Reply-To: <20220512173620.2f5175c7a321e6ccea6e58e9@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf9AxGtgMsn1iyoQTAA--.10240S3 X-Coremail-Antispam: 1UD129KBjvJXoW7tFyUAFWDtr1UZr1xXr1fJFb_yoW8XF43pF W8ta1UKF4DJFyrGwn2vw1DZryxt393trWDXw15J347Cr98ZryaqFWfA3yYka9rGrn3GF4q yrWYqF93Aw1avaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvab7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjc xK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG 64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r 1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vI Y487MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s 026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_ JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20x vEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyT uYvjxUqEoXUUUUU X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Rspamd-Queue-Id: 442881A00A9 X-Stat-Signature: qbtwx118grt17ftoztu4bigf8at598un Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652404749-996396 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/5/13 08:36, Andrew Morton 写道: > On Thu, 28 Apr 2022 12:34:07 -0400 Peter Xu wrote: > >> On Thu, Apr 28, 2022 at 05:17:07PM +0200, David Hildenbrand wrote: >>> On 17.03.22 07:50, Bibo Mao wrote: >>>> collapse huge page will copy huge page from general small pages, >>>> dest node is calculated from most one of source pages, however >>>> THP daemon is not scheduled on dest node. The performance may be >>>> poor since huge page copying across nodes, also cache is not used >>>> for target node. With this patch, khugepaged daemon switches to >>>> the same numa node with huge page. It saves copying time and makes >>>> use of local cache better. >>>> >>>> With this patch, specint 2006 base performance is improved with 6% >>>> on Loongson 3C5000L platform with 32 cores and 8 numa nodes. >>> >>> If it helps, that's nice as long as it doesn't hurt other cases. >>> > > Quite a bit of doubtful feedback and we have yet to hear from the > author. I'll drop the patch. > > Bibo, please resend at a later time if you feel the patch remains > desirable. Please attempt to address the feedback via code changes > and/or changelogging. Sorry for the late response, the mail is filtered and I did not notice that. The result is not so obvious after bandwidth is improved between nodes, it is only about 1% improvement for specint2006 for 32 core on my box. Now I do not see negative effective about this patch unless user wants to keep some cores separated from khugepaged daemon process. regards bibo,mao