From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 370A9C83F37 for ; Thu, 31 Aug 2023 18:27:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB64E8D001E; Thu, 31 Aug 2023 14:27:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A67708D0002; Thu, 31 Aug 2023 14:27:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955728D001E; Thu, 31 Aug 2023 14:27:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 864EA8D0002 for ; Thu, 31 Aug 2023 14:27:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 63843B2DEB for ; Thu, 31 Aug 2023 18:27:40 +0000 (UTC) X-FDA: 81185233080.07.240FDF4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id A7C4818001A for ; Thu, 31 Aug 2023 18:27:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693506458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Id7dCbh+xzweIUhTw+crDAkkHd+Ow7WznOg6w+YgXI0=; b=i9tuS6keF7Wp2mQRF4RNxD5HKcbHbVLw+AKGpJwf86iceMLUfKVO63oT8y3djhiIOVPuP0 aFy5osH0frBYSy5Z8MiQHOgBWdeUIX13ZSQHFOcCHXCFtsWbMYiZxQ5Qy+aZDRc9U4iIux boTWTZLSKVmRaFu2X2mM+aShYFAt53g= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693506458; a=rsa-sha256; cv=none; b=dv8r1+kXyvSDFd4dpxcE077H0TUhXX9Ur3UwxzUm0Yttpza3W1enXz8ssSDpn4zFw0PeBX uLaNVG9e8hTOYl5N0wxcr4Q+WbiWGWzpg5UyD+ovEJk/+ttl4+kbKwuevVdfqpqIzC3o7U xOfQrHhV0X/VYZA0/DtMnQZMRk1KA+w= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD1DCC15; Thu, 31 Aug 2023 11:28:16 -0700 (PDT) Received: from [10.57.65.16] (unknown [10.57.65.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 210F03FBD2; Thu, 31 Aug 2023 11:27:36 -0700 (PDT) Message-ID: <8c18a11a-0bc1-4bf4-93be-3d6a5f772808@arm.com> Date: Thu, 31 Aug 2023 19:27:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 14/14] mm: Remove free_unref_page_list() Content-Language: en-GB To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-15-willy@infradead.org> From: Ryan Roberts In-Reply-To: <20230825135918.4164671-15-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A7C4818001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ray9nt4764a1akhqwt96awtqoqum8ifi X-HE-Tag: 1693506458-4351 X-HE-Meta: U2FsdGVkX18tl20ABFIkzu1tTMPvXVJb9BCU16pf71IAniyWWBIDKAdOpbihjgm5OxHFSlX3ECDs6+5RfoF3v9mxA+Z6SgLrToIFnJJ2yTWLhqKGNm8hJzfdvUm3khxDT0xq4GmvZOJNnvqixa6XeRFvnR6RSHZIz3jyOuzT9aJeQegs3XB/5E5QiS803rGAmD6FYKU6Kl/AvpZvNJ7gXlEfAXAXwTgoDjNAutJPodCkpy+DDIhXJz+hS5SxBPo31X6VDPNHrw/dd6qAE0/ZC09Lw1sFfeQO/kTuT9nznQqGZJ5Xja8Xj8FCb83rMO9FgMddCaIVIZ4t5ostvONY05JS13YDRMBnXgsy+iEAT4zlcGQiMlerALP+dS3zLBnoFUE00eHKnnMlmZiUZW7tBR6duclmpXDIqvmnJSj86+qzVTKO69nSVEX/LVAn2tbSXSi81StDMWYF+duo3Mqh4b2SrAmNoBfF+kaAvQk7B+LEtZF+9prIzDreGYdYilLFQAu0UdRE2KlunFLa0/vzjeyc7w7I4mIJ0nHMEv0dY08zy+Ylc5wjo587Ys4oefbsy47g9eaHDNbJphuQw/FabCBiJfVnMHDmNxziddOv6MlHePxGjWEN7LGOKcalHA5V/sn1PUVcqwBb1bvD4Z7O4VDBFZ5c2f1gRa3ovE2mw2Zb9vlCoR9Knga3w/XuIncH5vkjyX2CY2v5fGXUc7FvZt3fDw4mocFEN/mHEEv8wjlfyDPmElNw2BCJjhBhi0Rik0oQf+UrglGTRrIX64UiA5s5+zKhEFt6BE5J77i0k1jj9swrek6dgsO5tv6DSBmvdGoWywXPlWzl0HgNQhRpop7cizBHUIOAon6UV5appK50yLZEQnlkzG8POuIZphi5QaVXMEiZtYTuMh+v8zzp12SbecdwS223I0bOo7WSsuCQh/O5t6j9MOTXEwukGAm0npY0QutWWojM7m0oS4Q 0ymFo81t tCYxz3IwhxWwOyKbVg69Oso+APE0mFtqZshwxnPnAXSjGt4B9CxbG3GxSGwS/vuOGt7ytJ+n4Epu0rZaQ60AKBQ9SmeY2nlxSGexuPgGiQ49LgaRi/s3ImjNRfj13GdTI8EThjH8jj2Xy9iyBo03vt3JYAILpjB/siz03iwGnwZhukIqm/pSerIvzqe3zADP24VFs7PmF68qW0wVlMPOVgx3m8LXoptTqcHwhNE2WNdxCr6VFdQ51XqhGySIQvTl9qR2B3cPuesiiNYE2UUllqX7tC1v3p3mPP9uVRkiOWRYD/R1OPkVb6euK2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: > All callers now use free_unref_folios() so we can delete this function. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Ryan Roberts > --- > mm/internal.h | 1 - > mm/page_alloc.c | 18 ------------------ > 2 files changed, 19 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 5c6a53371aeb..42feb3f59ee5 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -443,7 +443,6 @@ extern int user_min_free_kbytes; > > void free_unref_page(struct page *page, unsigned int order); > void free_unref_folios(struct folio_batch *fbatch); > -void free_unref_page_list(struct list_head *list); > > extern void zone_pcp_reset(struct zone *zone); > extern void zone_pcp_disable(struct zone *zone); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e586d17fb7f2..496304014ec0 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2554,24 +2554,6 @@ void free_unref_folios(struct folio_batch *folios) > folios->nr = 0; > } > > -void free_unref_page_list(struct list_head *list) > -{ > - struct folio_batch fbatch; > - > - folio_batch_init(&fbatch); > - while (!list_empty(list)) { > - struct folio *folio = list_first_entry(list, struct folio, lru); > - > - list_del(&folio->lru); > - if (folio_batch_add(&fbatch, folio) > 0) > - continue; > - free_unref_folios(&fbatch); > - } > - > - if (fbatch.nr) > - free_unref_folios(&fbatch); > -} > - > /* > * split_page takes a non-compound higher-order page, and splits it into > * n (1<