From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C63C2BD09 for ; Wed, 3 Jul 2024 07:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAF2D6B0088; Wed, 3 Jul 2024 03:34:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5E706B0089; Wed, 3 Jul 2024 03:34:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C26996B008A; Wed, 3 Jul 2024 03:34:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A227A6B0088 for ; Wed, 3 Jul 2024 03:34:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5431CC099C for ; Wed, 3 Jul 2024 07:34:06 +0000 (UTC) X-FDA: 82297627692.09.792FD66 Received: from out0-221.mail.aliyun.com (out0-221.mail.aliyun.com [140.205.0.221]) by imf08.hostedemail.com (Postfix) with ESMTP id 01E54160022 for ; Wed, 3 Jul 2024 07:34:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=IEh6EHTg; dmarc=pass (policy=quarantine) header.from=antgroup.com; spf=pass (imf08.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.221 as permitted sender) smtp.mailfrom=libang.li@antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719992027; a=rsa-sha256; cv=none; b=zpigmx7YE81rYs9Lfe3zg1MAHhB7sntJ8gOFd062/tL/Nx78oZrDe+SebC79fFLnC0Z9RD 3kOE53lBtxXwRRZzj8YYdSStibJ3J1QvL6DNsWQMPJiU2juO4fhBvAePDM4MLz1m+gso2J 1JHKmUNJYjFLZW2mK2cV8bDI1TOnDck= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=IEh6EHTg; dmarc=pass (policy=quarantine) header.from=antgroup.com; spf=pass (imf08.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.221 as permitted sender) smtp.mailfrom=libang.li@antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719992027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=At4jqwGgXuRCLFY8vsxvY7PK8hFvTuOAH0C17po1+xg=; b=CsGV9K3amy7Y53Jeg2Xzh3ITz7D3y7kOxDW7FYgwgH2qdXWr8gQ/Iksa/41PLQEi+Qd0BT V3yhsj7P5wl9dhvFGKGJRc8Jl3hTGGUq52ZtOQsd4fx7yG8xyxTobanwvubn2vqmlEQDoD J+6Gl3t0Fhn7574NW9JPJynLsGL/FnA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1719992041; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=At4jqwGgXuRCLFY8vsxvY7PK8hFvTuOAH0C17po1+xg=; b=IEh6EHTgN5tAbFWVuMnw7/y6phywi8TqtQdqhjKzkDJ6urRM46z5Qgu/ETeUc85gICDkAUH6eJ8//R1dmihEUr5Com1twROnNkGmL8/DVTvAVV8rQrOGu3Nu8l5VnvnVFgQgjNsqNNyB3KEI4JLJF+olPkdWs4+OyN6elPaxRis= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R631e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033032065106;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---.YGEkpij_1719992039; Received: from 30.230.88.238(mailfrom:libang.li@antgroup.com fp:SMTPD_---.YGEkpij_1719992039) by smtp.aliyun-inc.com; Wed, 03 Jul 2024 15:34:00 +0800 Message-ID: <8c018e06-74f1-46e9-bc32-b3870342cdc1@antgroup.com> Date: Wed, 03 Jul 2024 15:33:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem To: Ryan Roberts , ughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, wangkefeng.wang@huawei.com, baolin.wang@linux.alibaba.com, ioworker0@gmail.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240702023401.41553-1-libang.li@antgroup.com> <507da6d0-77c5-46ca-8351-53b405ecb131@arm.com> Content-Language: en-US From: "Bang Li" In-Reply-To: <507da6d0-77c5-46ca-8351-53b405ecb131@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 01E54160022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: zpyw4gkmo1hag8xsidwcz6do5uourh5k X-HE-Tag: 1719992043-826934 X-HE-Meta: U2FsdGVkX1+8FPcSm9ikeQm62fER4qjMfnPcZiXKvbwslslwy4N6ICcs24AMmp2vP3XzqXyr4coBz+6Co+oLq7I8SGR3vVAdRNfU9XNUaBkbhZT+Q6ny3tms/M58qSTQZeY8fOXvRN8S2DCAWfO4wKnFDxIpBcn8rD3GNktWS9r8DVf3TtenyYndyXvbdrdM8TL1L6RkwetFZdNguBp8gAcvjH2JiB8WaVUDoDqOd2JxU3GQMe9PCIEp2UHpEpxz9BdlqLTFIT9YXzkaQ/hrBWVH/dDhSGDF4jTaPqRDPC8nEC1t1TuhpZtGeLYQ9i4eLd7WWZA4RaCWBYSVTdCSG8Kn4xy2PK/9Aza8W/w6Q2V0V1zMfdf0SfbgEOQIaVdohlcxNcdMgEdP6UYUB176/8fwKJxwSMLaJFG7wEy5sWAVzsycm0wTrSfY+S+enB+hI7iq/mFo6Jo4a7e3SQIRQfANio6WsbutLvx5iezmTyErQWFZYD/Qmytp2rZox9dE8x6smO1ZIrpaBLlIrwpY+OQxbfe8U64APpamzulZPtR3IIAaLWmw9yvjliOBmEA7dfj2AHqM8JYgKOSZ6v6MJni8XhQ000wbJ+FLjEt+hMNEpnc45URtVWLbFQn7m4vzfX5m/SYSxg2ZEOlJEM5Llp7NK41D1q7ZIsWGak1GGp0kP1WuVzQUW3+purXgpRWjlIyDhXcCIaC6tZDUwVRDHwb9W5SULjEDCgKj+eQdTiiiyl1b2Yz5pLyXvbmW8a7ThnOTWnPkDM8XFt8qvRxuoQbNNkPBS0zhzSyUEp2r0WNbATfbbeZAdGkIddYfmORmXUbSZGD/cjrvKaGcx90ZVsQgoTT/rrSOsG1m21EwGXdrgsdTpLB7oVwaXlrPcRwJeRUs3JR81LlE9kFeg6OAT9fZ6qehKTbZonpWPDzNkf9jZo8PTzO05aWDhv72n/rYzmyfrU5+8SsNlSol2h5 55+TbJGs h0PQ8U6kMxK597/JdA9F/8jskbNu1H57IHoMeWZ7XCLnGh//svlWRnAMZ1WtSaE0h9g/AfFrJHuCwlIFwsqHmPcG10un1aKNBeHc3Fo63y/kVePNOQegpsj8D0jBLltB7VIscwKAhHzHyAaodae1kC780YD4M/w3gG9ilwK10BEHQEV/23tDhduUrAxgeTmaEfPOv0m7fx+yjN1VM/fud5l80qmRxPT9QARvM6qQz6a5yGN+WI7E7s9JnZClsDFxXe0VoolVNZZiWxV7PUwOvlFYrCmqWXASdNaSI/fe9AshXFTKiFqDLBi4qyJ2wHozOy7N/QBHime2hSSvyCFW9pguWPdQesZTrnvnsL1a71ggLJqggHJguz40KjDmMg6MKAZ0U6AuYtUU3wRE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ryan, Thanks for the review! On 2024/7/2 16:18, Ryan Roberts wrote: > On 02/07/2024 03:34, Bang Li wrote: >> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >> anonymous shmem"), we can configure different policies through >> the multi-size THP sysfs interface for anonymous shmem. But >> currently "THPeligible" indicates only whether the mapping is >> eligible for allocating THP-pages as well as the THP is PMD >> mappable or not for anonymous shmem, we need to support semantics >> for mTHP with anonymous shmem similar to those for mTHP with >> anonymous memory. >> >> Signed-off-by: Bang Li >> --- >> Changes since v1 [1]: >> - Put anonymous shmem mthp related logic into >> thp_vma_allowable_orders() (per David) >> >> [1] https://lore.kernel.org/linux-mm/20240628104926.34209-1-libang.li@antgroup.com/ >> --- >> include/linux/huge_mm.h | 11 +++++++++++ >> mm/huge_memory.c | 13 +++++++++---- >> mm/shmem.c | 9 +-------- >> 3 files changed, 21 insertions(+), 12 deletions(-) >> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 212cca384d7e..f87136f38aa1 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -267,6 +267,10 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, >> return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, orders); >> } >> >> +unsigned long shmem_allowable_huge_orders(struct inode *inode, >> + struct vm_area_struct *vma, pgoff_t index, >> + bool global_huge); >> + >> struct thpsize { >> struct kobject kobj; >> struct list_head node; >> @@ -460,6 +464,13 @@ static inline unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, >> return 0; >> } >> >> +static inline unsigned long shmem_allowable_huge_orders(struct inode *inode, >> + struct vm_area_struct *vma, pgoff_t index, >> + bool global_huge) >> +{ >> + return 0; >> +} >> + >> #define transparent_hugepage_flags 0UL >> >> #define thp_get_unmapped_area NULL >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index c7ce28f6b7f3..ea377bb4af91 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -151,10 +151,15 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, >> * Must be done before hugepage flags check since shmem has its >> * own flags. >> */ >> - if (!in_pf && shmem_file(vma->vm_file)) >> - return shmem_is_huge(file_inode(vma->vm_file), vma->vm_pgoff, >> - !enforce_sysfs, vma->vm_mm, vm_flags) >> - ? orders : 0; >> + if (!in_pf && shmem_file(vma->vm_file)) { >> + bool global_huge = shmem_is_huge(file_inode(vma->vm_file), vma->vm_pgoff, >> + !enforce_sysfs, vma->vm_mm, vm_flags); >> + >> + if (!vma_is_anon_shmem(vma)) >> + return global_huge? orders : 0; > > nit: missing space before '?' Yes, thanks. > >> + return shmem_allowable_huge_orders(file_inode(vma->vm_file), >> + vma, vma->vm_pgoff, global_huge); > > What's the rationale for splitting these functions into shmem_is_huge() and > shmem_allowable_huge_orders()? Why not just have a single > shmem_allowable_huge_orders() that tells you the answer? > Currently, shmem_is_huge() is used for all shmem implementations to determine whether the conditions for using THP are met. And shmem_allowable_huge_orders() is currently mainly used for anonymous shmem's mTHP to obtain all orders that meet the conditions. In my opinion, there is no problem in separating these two functions. In the future, when mTHP of other shmem types is also implemented, will shmem_is_huge() be unnecessary? Thanks, Bang >> + } >> >> if (!vma_is_anonymous(vma)) { >> /* >> diff --git a/mm/shmem.c b/mm/shmem.c >> index d495c0701a83..aa85df9c662a 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) >> } >> >> #ifdef CONFIG_TRANSPARENT_HUGEPAGE >> -static unsigned long shmem_allowable_huge_orders(struct inode *inode, >> +unsigned long shmem_allowable_huge_orders(struct inode *inode, >> struct vm_area_struct *vma, pgoff_t index, >> bool global_huge) >> { >> @@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault >> return orders; >> } >> #else >> -static unsigned long shmem_allowable_huge_orders(struct inode *inode, >> - struct vm_area_struct *vma, pgoff_t index, >> - bool global_huge) >> -{ >> - return 0; >> -} >> - >> static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault *vmf, >> struct address_space *mapping, pgoff_t index, >> unsigned long orders)