From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E1CEB64D9 for ; Wed, 28 Jun 2023 02:21:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3BB8D0002; Tue, 27 Jun 2023 22:21:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 764478D0001; Tue, 27 Jun 2023 22:21:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DCB28D0002; Tue, 27 Jun 2023 22:21:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4F2E18D0001 for ; Tue, 27 Jun 2023 22:21:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2A881A0A7C for ; Wed, 28 Jun 2023 02:21:14 +0000 (UTC) X-FDA: 80950554468.22.DC6C91A Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf18.hostedemail.com (Postfix) with ESMTP id 7640F1C0018 for ; Wed, 28 Jun 2023 02:21:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Npa8i8m3; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687918870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=alQsyAcgxMxydAdfquhQioZPpfGdKoQ8/u5AJlIuVuE=; b=o69AlGi/iwMYQJaYpLBS2+U6mx4KPRgH0R9pT2X2vCVSM4Srbzf7AJbq/y9N65P2QiEDzr UuEt2cuYeUEn7kJumqywPqWiD13aTpKreIWwq9Oza+avBB639pLJje+5yDC9ZMSJekBW9a jIBpJybHSv8JxbaeJLIbeBNJdSEK1oA= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Npa8i8m3; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1687918870; a=rsa-sha256; cv=fail; b=OTVJiN3ViRLg4j6kO8SGT7xpy83bMh/GT6FzumWfTwddvwjYhHARLh3FNVijXLPM7o6+jV 6p7lKkKTq7CsMNASC7KjqpLf0WB7XtK/QWQz4t9jp4XSRliCYu2oECj0nZMnU/WcD/dLxH IdVgTJ5SShQXJv8j2GvkjL5t4ladU6Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687918870; x=1719454870; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=8N+GO04oUUb9Vu0V3+FhmDkPsBK0sdwhgnaJBb29+Kk=; b=Npa8i8m3iB6/Yyq9bMRffNRR60+LngAszXMTtuStuuhL4KuKBJqwtA4y Q09JmPfAMqBTG2LfEpH+5FzBRfuHsRdhJC63Tl6NCpCgYLE65GjEDfVQi DuCRBj+xDnHf44mFP43FNr8aT/AtBC6bvAnVBiYYEOGMUMB5aCr3+clb2 LVaayvH6F//qEL0M8fSBu3e8GeLPKMxkwc+uOe73oPd5wgOPMM8anquIC e3/ME+1mhzUqo/Bzsz2VKcowXWLTXx+8dnKUQ9E5fE2bZpi6oPTZHcqy8 elfxzfe5kzInH72nJGyMRTbroB7EARIcVhbypqt0reqUkgJdXf0hFipAl w==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="448114408" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="448114408" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 19:21:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="782091391" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="782091391" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 27 Jun 2023 19:21:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 19:21:06 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 27 Jun 2023 19:21:06 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 27 Jun 2023 19:21:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gAIJYi7yC9Dl2QGSXFw/ya/EUQm4fHVE1qSGRqqECuBe4u2L/2w78wKcw0hD+RdwVHYFvgEWT5di7/7GcAB84o7PvYUmXksHztcVbU50urpg/deyxX8K9wM+Ba4IYEVJoLOfhU0UxkgHz3sPFz0UvAiCWR+YynqdbBIFcj3Z3YOq8k6VM/SRsSLjVE1kam07DnlbAvGqjBYdjRM45GC/InJ6HN76E4z+tOX/DMCveqcmV54poflp8Cwyfv6CzQwu2UZ1n0xFlUvRifI2GQcBbkd30O2yQAUo/sPZiTUEOQb+Av0J06il4L4YAJxd6FPz4M870dlXS+HtC0Aao9Hgew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alQsyAcgxMxydAdfquhQioZPpfGdKoQ8/u5AJlIuVuE=; b=Zr/KEQ0mtyG808m6HDBXbmKkVpNMTSIFNT6DHF4UkrEwdeF1532CzwZcXs3TPvWvDayWA44Xy3PnHLyugTnd3IflQPxGfAluXyKSbYwNWYGmWqRwbreZJaYrjG8NnjNMIkPBQjd2TzJh5rLsRouanDZ15XOxqEA8ieR3F5Q4mz/epldahenXlyGul3HUGWG86DgrYNuLURVaOz1tSyvpSxoYQMZ9hVlZkbCjbQIpTR7LFVpsWpBunkEqGKWQDuN/arIYydbCFgD3wMtQscoTTw/9mf/ibUngY1yOeM+JLESte+sJB6Rsg79F+v3dzViKs+W+o2lNGUs8tvzQHssx+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ0PR11MB4927.namprd11.prod.outlook.com (2603:10b6:a03:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Wed, 28 Jun 2023 02:21:01 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::e6c7:a86d:68d6:f2f3]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::e6c7:a86d:68d6:f2f3%5]) with mapi id 15.20.6521.026; Wed, 28 Jun 2023 02:21:01 +0000 Message-ID: <8c01486f-3c1a-e50d-544e-502eadbddf05@intel.com> Date: Wed, 28 Jun 2023 10:20:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() Content-Language: en-US To: Ryan Roberts , Yu Zhao CC: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Dave Hansen , "H. Peter Anvin" , , , , , , , References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI1PR02CA0020.apcprd02.prod.outlook.com (2603:1096:4:1f4::9) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|SJ0PR11MB4927:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f36b5a7-1cb2-4794-be8b-08db777e50f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I8KfzFVDlboc3R9MSLYgxA2FJrBSSZU9p4gDWs2AzwwiYqcGN9HYaIWcGzSGVAWq4aGSNgSvnIU0A2nilWV6vCluy+wvuRPwQRJzcIuFWw/F/3erHgoLG24bCEuAonHaziqPbtrrigjL90shVnn8LjYyMfAFT6+JKWOgSDo1sKvQmkEW4GpDdpMoweUN52dMZjNy+1tUlmt1zVmBpgbkqD4wjJcSYCQrFj68OJS1bIx0WJeG8ugBj/Q/ybB4nfu0tNBwxa30IW6wxI1W2qNJxMzrnoZUDjZmm0/pWG01CWLnOeHBvLQlpZKwJS91l7OwMFHQf1h88++HUKYKf+UUFzSe5hpKfjmS2SAQfi0PXIV1naIzr3g7EsKcfCkV+5TbB9SDsESFKZdK/1hqZqiwM/vyvoHa4XyvUMZmpN6cZ61tY44YIrINgW3mq6pnDa7a9OwhMUyrQYTsbRjkTIPAOO5JngBzwRupL7sFBrtpHKTvZAn0to1j8WCaIJ0Th1M1pXFBSZKU8eOjzp0enBIITI7y2ey7NCioVxJ/wRzpX1QWCSpw1sGrxPVVm83nvWR5R2OYPVEQeRY7QcP9tAFMBG8NvETjyXJ9ihpEjj2dMWVCogzF2oVEqS8NAIIxKqjU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(346002)(366004)(136003)(376002)(451199021)(86362001)(31696002)(36756003)(54906003)(110136005)(66556008)(66476007)(66946007)(26005)(6666004)(4326008)(478600001)(2616005)(2906002)(5660300002)(7416002)(966005)(82960400001)(6486002)(38100700002)(6506007)(8936002)(316002)(186003)(41300700001)(83380400001)(53546011)(6512007)(8676002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE5zM25KSm5qRVVNalo5ellqbUJkYzdlSkxMRnRNelVMTEhKNnJYT3RvN2xV?= =?utf-8?B?OXR4NWkzdUVFNm9FVkhNa0R3V0FmeUpGbGxMQnFpckR4eVovdm1CVVRGZHpz?= =?utf-8?B?eXlTMk81OGxGeUsyMnhJSmI5eGlpcjBxTEtVbm9ENHFNdW0zOGpjVmpTUGFr?= =?utf-8?B?blNXclFNN3lpcVB3ZUFUKzdEUEYzMldDRU1LUWZyUm52K0RPU2hiRG9PaWkw?= =?utf-8?B?N0ZOVTJSdlpock5ydWwyVGNhZC9LdHUvOFZtTnIxMDBndmhlcFI2Y3N1SUZE?= =?utf-8?B?bGtsanRKUFBSbjBwSE5aZXhzelBBVCtCbi9vY2NIK0dHTW53eHN2eis3N1Iz?= =?utf-8?B?UXZ1TDJTbE8rMEF1b08wOW1NdEtQcXlzMGozc0RpeU02RE1RaWhWSzg2a1VJ?= =?utf-8?B?QVFUNm9lTGU1TGRIMXRxSEYrYWdqeVlBSmN3eDRJZmNpaDNEem1UcERhTm9Q?= =?utf-8?B?aFZjdysrRExjSGtFS2dFUTJ6UjVZczdsN0hlTUh3VnVCMi9EUFVEWmFYeGRW?= =?utf-8?B?aHVZNENpakVKODVBS0pMdmF5OURGMDFlb080YzVkRDFCZkJzMlRJRWl5eUN4?= =?utf-8?B?SGpoWDNHeFdtZjkydmhPNmdwMmN2dWVoOEUxQm1sQk9uSkVsdEdzaXEwS3Bx?= =?utf-8?B?blQ5T1FLYm5QaXVKNE1nRlZWaEtsMU5iZ1hzcTVIRDJ2Vm9iaktUeG5GOWZL?= =?utf-8?B?K0p4dnFPNnN1YnRCSlhLc3lCZFFKVVdsd1JaM1FnN21tVTZPSkhFalZJME1l?= =?utf-8?B?Q1FpTWNSRStlSE9mUFRxdnAzMHFKSWNMQTdqUUJwL05zdDd2YnpaR0VNYmtB?= =?utf-8?B?WUNXN0hmR3l3YmxRRnB0bUNRcWFiTWhlYjZzbVphT3dOV0NDVXRJRnJPejFH?= =?utf-8?B?MVNmN3I4Si83dCszUFpNanRqdTZCSVQvR25JK0M1SWYzWlhuWExFNVBCdHk3?= =?utf-8?B?b0svQXcza2ltMk02b2NqSDI0cUQyQVdDTlZuRkVQcFRUSUJ2SWpmNDhvdWh4?= =?utf-8?B?eGFoWVhwaWR1SmlqR0JWNVVNK3dDNjlYb2dxQld2ZFRYWGcvRlk0RU1BYnJ0?= =?utf-8?B?bEgvNnhQSHhlT1ZDVFhJWldUQ3JKS2VwbFUwb3FtUEt3dVlSRDBLbHM0M25Z?= =?utf-8?B?am4zUWZqZnZOR25hTHVrWVdzaG5IMlhCU1lLaHMzSkpwTi85eUxFOXFtdnV2?= =?utf-8?B?aGVXUXduK1MvT0V5ZXY3ZXFYL0UwR1l2Q0dDbENjOUZ0bmtZVDlST3R0bTVF?= =?utf-8?B?TldPUnc0QVkvbHlNWHpuTGVBaGtWYzhqZlJJM2M5cFZzaXBJa3ZWU1UxbXBL?= =?utf-8?B?ejNmRjc1TklQV1N5ckUxWDR5QVQ2OVJrQ0FSdVlKK1M3QW5ZTE42dWswWkhX?= =?utf-8?B?bXNPSlZjd25LVUtzRDNPRXMwUGV2dFpoOXY2cVBDc1NNR0J4dElHM0dMeUlL?= =?utf-8?B?Y0RBNHNSOU1jYU5iZHRhVlcwVEFZSDdQNTV0Z3FIeFZNSWlORjAvV28xcS9V?= =?utf-8?B?V0l2SU4veWxRUUZqMmZIdHN3REYvMVNFdzBlWjMvZkVTMkFrMlRBdlFpNFpj?= =?utf-8?B?OForS1NWYS9RYUp4d29zcWI5YlN2VE5sMDlwZklLK0tVTlNWcW9vUENZd1I4?= =?utf-8?B?OWd1SXhkdkxNTERYTkgzTmVNNnNGVlVTOEZ1bjh6TjZJL0RCQSsxd2hhVzF3?= =?utf-8?B?alJjTUQ4bUZBR2tIR0ZrenY2Zit0bFBTV2dGL3FGelhaNnBvQjMrRGdJZWRu?= =?utf-8?B?TkRVVktKNVJBWGJvR0ZEZWM4YXZkQ3R2SFJlMTl1VDlSaEtrUFBmakhCTVJx?= =?utf-8?B?Nks3ZXV6a3Q2cHNMcjlmSWU0cU9wZ1dWRld4YTVaZ0k2eWgrYXg2R2NYQWRr?= =?utf-8?B?Nnh5U2drQXUxLzBHTjR3WGRlbHQxbU8rc3lVYkhKTzM5eWhic0dRZmJLMFpi?= =?utf-8?B?WEJ3Qk80WW91UGUxT29kOUs1NU83OXd1QytQYk83MjlQWmFGQVQ2dUxZVmdS?= =?utf-8?B?Y0dDZTk1WjVjQUV4UW1EaDlvcHpIZnVweHJRUzA5YW9IV0x3SEwzOG9CMnNM?= =?utf-8?B?b1UxaTA0RHhlRkw4L2JpMWZ6WTJOU2Iwd2FVS01OM2NhL2ZudnRvQ0krTFNw?= =?utf-8?Q?tmaJhJi/ykwdJjlcWSaca2pLp?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f36b5a7-1cb2-4794-be8b-08db777e50f6 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 02:21:01.3722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VWu6Y7oufiF1IkJNewl2mmDIfN6c/fwgaahFyGQ0yujO5ceeZJAXhuupGMwCeCbJ0mh1ZZbdIW0m02fYt/Yo1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4927 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7640F1C0018 X-Stat-Signature: 9f451epcnca9n3yb3b7tg9za165k1e1b X-HE-Tag: 1687918870-527192 X-HE-Meta: U2FsdGVkX19TclpFIYnoWuduLbpN1CTWw0Y7ttGwrQtAVUMW/ObX5alMovB0rSWRKZfx35Dlqtsc6/hJoQ503j3GO3H9fqriJ/IVvsKerDz+eNozOyIea5aSQWGNh5wjCQUzO3B5dy/EEoqTe000IAIxtaDNJ3tEZaMbH8+785PPSR92ReRfVxLeZFxa9umjUj1uhKUqaTaiBsCEbbL6R1X7hmMkf8nhG3TWv9gMc10Yg1yaSm5ZR6OPH/D8Hpd0+6zzGz5Ygq26NdN6eB58bxUgcSBIv6uR/c7scurJi7OoQ4mGpIfR+BDjWNY8zfH1YmgFy+et7kEurKAF3MqCX0n/3IdQF8UZau1x5k6KozPK+I5CTbnGscqbKg8NRXKsIlAHTLDqUDgbMdreeBXu2+4evqx6qIKPoQ9AdwUEqcjT2CeW9SRQPEyuTR3GGq5Eyxa66SPTZpdll5ox4FNf65iJ/9kPr9CRAzLHklFkWOemrZMxodHD8dOL3PS5sRP/ncDz+yQsTwgrDOmqpU/I6BloZuuZIdImMmUZTL2zd8K7yPg402tya41ADXc+zAWbRq/AS2hxNost4X7kIj2SBsUpq+JuRUk6nSU4HyIbFMMxCmcup0MXT/PsfRsE/NC2J8zg3cdLNYY8opxSvqvcegHcgTe3Dxk1AQDQgw7E4wliGCa8IUn/uL/DvLaLkLqD8VNTWgG+5+BVwHKIMUZIS9Qwy51RY7kqqpQnE7PU0Qn8GErCev160CKzqQmKOYdH+QAjluPq1llujwOXc6s6Hn+5J1cA5rUnC9RpTxTf61QNHPfBD//h+O/cXe3pNEFpi2bLQ2aJOsrdPMGwg4DVf3Fden8qIfq7vYKwAKGdhuXmCfkHYq7BUErOUbSEtceP0hNrg4P4NLWZQcfXkYYh+m3BN5bHWzcU0YH9QmxMFn6+Kr+9Oeyxz6dBm9t0vphE/7mphLHUaarzzOepn93 Q3354Ymt FATlIcj96KLCvHUZcF/CzTWQhgzUFz83qmfz7/q/0m2eBu/dsFuTiiQM5N5Ox1USAHNTqZGkawPZ+e8cJP0skiupNOHQOFbg+2e+iDzIKfoMkPh1HZQGUdmvT7jnawEUcFqLZzMXn57++BDFTB8zhS0gACtkZ/xmvDhhyj57EY6OuAhAk1pEHbLI+A5VtuoOglPmRRCqBHQfb+vw1JJK/Rid0dTjIBcmaYBpYALfRM7OIyp1nDokMAfydgblpnDgoUwFrFQXHY/BrqgiuMQESPgeNIQ+ZswX69EXZAtl9sqtrcfKBwQ/R3CYhchFK2n9pCLllDDqnwi4nJi7W8SOZLpj8L8HWD/eYwK57qDXGyUQ29vT1tvdzWBpwtzU/umVbvT4q80cCaPyD34TfILFdshPxecK8kPT8AWmutR+XmOvYo8RlkiHLA7gwrgNP3alsxY+F117mDnJp+KCODUyrgGYjeMuRYN5WASXv01HkqBkOsOMb0oliURQ+Atpot8OGTXeK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/27/23 16:09, Ryan Roberts wrote: > On 27/06/2023 08:08, Yu Zhao wrote: >> On Mon, Jun 26, 2023 at 11:14 AM Ryan Roberts wrote: >>> >>> Like folio_add_new_anon_rmap() but batch-rmaps a range of pages >>> belonging to a folio, for effciency savings. All pages are accounted as >>> small pages. >>> >>> Signed-off-by: Ryan Roberts >>> --- >>> include/linux/rmap.h | 2 ++ >>> mm/rmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 45 insertions(+) >>> >>> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >>> index a3825ce81102..15433a3d0cbf 100644 >>> --- a/include/linux/rmap.h >>> +++ b/include/linux/rmap.h >>> @@ -196,6 +196,8 @@ void page_add_new_anon_rmap(struct page *, struct vm_area_struct *, >>> unsigned long address); >>> void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, >>> unsigned long address); >>> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *page, >>> + int nr, struct vm_area_struct *vma, unsigned long address); >> >> We should update folio_add_new_anon_rmap() to support large() && >> !folio_test_pmd_mappable() folios instead. >> >> I double checked all places currently using folio_add_new_anon_rmap(), >> and as expected, none actually allocates large() && >> !folio_test_pmd_mappable() and maps it one by one, which makes the >> cases simpler, i.e., >> if (!large()) >> // the existing basepage case >> else if (!folio_test_pmd_mappable()) >> // our new case >> else >> // the existing THP case > > I don't have a strong opinion either way. Happy to go with this suggestion. But > the reason I did it as a new function was because I was following the pattern in > [1] which adds a new folio_add_file_rmap_range() function. > > [1] https://lore.kernel.org/linux-mm/20230315051444.3229621-35-willy@infradead.org/ Oh. There is different here: For page cache, large folio could be created by previous file access. But later file access by other process just need map partial large folio. In this case, we need _range for filemap. But for anonymous, I suppose we always map whole folio in. So I agree with Yu. We don't need _range for folio_add_new_anon_rmap(). Thanks. Regards Yin, Fengwei > > >> >>> void page_add_file_rmap(struct page *, struct vm_area_struct *, >>> bool compound); >>> void folio_add_file_rmap_range(struct folio *, struct page *, unsigned int nr, >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index 1d8369549424..4050bcea7ae7 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1305,6 +1305,49 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, >>> __page_set_anon_rmap(folio, &folio->page, vma, address, 1); >>> } >>> >>> +/** >>> + * folio_add_new_anon_rmap_range - Add mapping to a set of pages within a new >>> + * anonymous potentially large folio. >>> + * @folio: The folio containing the pages to be mapped >>> + * @page: First page in the folio to be mapped >>> + * @nr: Number of pages to be mapped >>> + * @vma: the vm area in which the mapping is added >>> + * @address: the user virtual address of the first page to be mapped >>> + * >>> + * Like folio_add_new_anon_rmap() but batch-maps a range of pages within a folio >>> + * using non-THP accounting. Like folio_add_new_anon_rmap(), the inc-and-test is >>> + * bypassed and the folio does not have to be locked. All pages in the folio are >>> + * individually accounted. >>> + * >>> + * As the folio is new, it's assumed to be mapped exclusively by a single >>> + * process. >>> + */ >>> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *page, >>> + int nr, struct vm_area_struct *vma, unsigned long address) >>> +{ >>> + int i; >>> + >>> + VM_BUG_ON_VMA(address < vma->vm_start || >>> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); >> >> BTW, VM_BUG_ON* shouldn't be used in new code: >> Documentation/process/coding-style.rst > > Thanks, sorry about that. Was copy-pasting from folio_add_new_anon_rmap(). >