From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64450E7F13B for ; Tue, 26 Sep 2023 21:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61B1A8D0052; Tue, 26 Sep 2023 17:58:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A4B28D0002; Tue, 26 Sep 2023 17:58:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41D708D0052; Tue, 26 Sep 2023 17:58:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2F5CF8D0002 for ; Tue, 26 Sep 2023 17:58:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 02CACC016E for ; Tue, 26 Sep 2023 21:58:30 +0000 (UTC) X-FDA: 81280113222.27.352E7E1 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf15.hostedemail.com (Postfix) with ESMTP id 36D21A0035 for ; Tue, 26 Sep 2023 21:58:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qlF8UnW5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of hughd@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695765509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C6kFfoWUpW/8kB893AEctkntP41wPPc2fMMmzCd25kM=; b=W8/KJMTr5w527BpnoMOY1ch8nWPLILKPxq7AvWb1ZLF7qH8jdaSjMI1StH5Dy7FRQUHQ3w C3Gc+1OoNbaudh9IM3Z8QibUBknWlOViIwv7uBi2qlIEc88Dp7diHcOuZoN96sXx+kpQhN WdCyJWRTXKPBQODhvCJk0TFN0XR4/Gg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qlF8UnW5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of hughd@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695765509; a=rsa-sha256; cv=none; b=0ZyqfwZwjQwZ/IdMII4tq6weNFrS2gK0dGI6zfFRgcj0ex0vJgxeUkr7G61yRSj6UtOPlf OKlBQAucOoR+hCdcrlgPG5MhWsr2jfI741vk+p+LrBcFOjBjnVcwnlfQ6f3+qxEvOnfNqz TtcxolescdKiZYRBRr0yg0Z+8HMu6zs= Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-d865854ef96so8438524276.2 for ; Tue, 26 Sep 2023 14:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695765508; x=1696370308; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=C6kFfoWUpW/8kB893AEctkntP41wPPc2fMMmzCd25kM=; b=qlF8UnW5rszFTE873IA62X4TKmV9sbREcn6BNrSHMukvvkRTwFDEUF2efBUMCH1oL6 N1cHiXJ9ClA3GnfIkhp86OxfWdNC+SeyAypn2N7+/VHLwI4aI7su5Ko9pfzJH7q/TjTO 5B25d6n+v7jgi2s8TYWxNBxbgy1M00pXHlCbJosWGE4TV7gudkEFN17kJ7u1EsxbZyCP MESm2iFqc1+DCzjaGVfggbQ3YaLIln2/E8os/PdisGAj/C2pjufbEMZxNT87bM+ed1lw Lh81/IQGy3xSdAnzCFZa5sxF5TQgA9nzokNC5grCgDF9a8LbeLpFVQZiCU2PD0GUlA96 8xzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695765508; x=1696370308; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C6kFfoWUpW/8kB893AEctkntP41wPPc2fMMmzCd25kM=; b=JA70YjS6hPWkEGKQdfj4vJoKDbZPZYT4o9ydjqUbMrJjgd/EhO/nFPE4gvudmeIyLB rh9bgi3jISX93M/BNE7+G+0ombrGFDsRbeEMtKojXtIdfbW7Nur/Bz/oNY16Z0iw6nts /3aFnuVx0USceR78Uz07RoqoP8gTYa+mEXcKqEyXiv3tqJQ8DtbYxGpN2Jd34APkIqoi XdHQCEJa1vu87vDWBqN10CqQXryBvYJviY5vrqGeLCRdVtzIt5k5Eap+zN9JpQEXJIp/ GmW2nH2vc378/DuMKGKVt/lxYga2ZGUWYIu/wjpd/Yg0x4Ut1Ur2XIfAE3tHr+J05djL /KTg== X-Gm-Message-State: AOJu0YxK8wqdygpiEQ4v4U7XA8BzDDOArqp1+RGUbu/7js4pIuCulXOd 0P60suOqie+lU90AAuRULrOYag== X-Google-Smtp-Source: AGHT+IF1lC9gZTVPKEK6v5XtwRFX9u+Q/KPjl3ek/67xFlemq2bGgHxn41G26C6x9G8iwO4SwapdLA== X-Received: by 2002:a25:c590:0:b0:d81:5240:679f with SMTP id v138-20020a25c590000000b00d815240679fmr220291ybe.16.1695765508147; Tue, 26 Sep 2023 14:58:28 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id i137-20020a25d18f000000b00d81425266c1sm2981515ybg.42.2023.09.26.14.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 14:58:27 -0700 (PDT) Date: Tue, 26 Sep 2023 14:58:24 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Andi Kleen , Christoph Lameter , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/12] mm: add page_rmappable_folio() wrapper In-Reply-To: Message-ID: <8bfe25ca-def2-f33d-fdba-8ce5fbb5efd0@google.com> References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 36D21A0035 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8dg3811gwb3eq3ajuc56inmsx8g878ek X-HE-Tag: 1695765509-341164 X-HE-Meta: U2FsdGVkX1/C2SLGLwwgbaGmJ+YtHKwyi/FfPdrMx+0reFIcsKAIJtM/zF9P/Cjmm1W+F/rsjNcHHub/BmmtCuEXjomJodx+ViplTC1DTsxa1omYUta/v6/+H0X18Tu6k0h19O4Kd/NTHn6yhSOa/d1KtdtKBoQFay6F1XJMHCf7uCcX+F3W1ZYig7FyRtT1ITzDg403UraHMQGG0xhwRkZ98l6UypGtKKC+v/7naSMaxEaa4cwhL0Tw9+AnrMWqMrfmD7sGnJqWD6oIWWfrYPr1VlmaaofShJfRuHt+2N+Z473f8OQpRN12Q9TbkEI3zIq1Vzwr2XdnscoDtuKzu4IDMc3Hd13n/zIm+us8EDNLcbJKEmW2LN0XxEFGvYInOpzfQi1nUliZWVklB2nPdmP8HgURMb6QCix5fUJaKeIWFIoOnOU7JT5BEfwFFMB4zuGlVRwCtS5+U3uXMYeWlOdlFO7FeNIa15IqHNsxM7cqRigFGzpzo0bzIk7eQxrxSKUAIBvJ9/XO/3Assp+RkO1u/es8rEx+gyzGh9Ye9ngXwVpuIf4mRD3Ts155FrECVxrnJSLuEyZgdWwR6oOGSYu3bw5zryQRkIaPheN+JAKzZbN0lVblLskhLsSUYCIuFNEMp4T4ilPEhrbRdFAbp4SdRlsS4MXSCqGNx3YgwVutvaVMI9wbpb5wchAI5ctP06RmyHSj2jCr6ghyiqEGSTINcAMb1OnKksBIUwf3TEWbcbQbGgDy5mDtCKapnfotTBKBVzM2YHAeqOVfa/n/hNQTwG2+ofGG9dQIYE5/UGBJIjyB5nLvwi/8stUUzk31EC1YL7wPwrXndVTjjn9SGp5WfyDUKQ71Y7uejn5wBl/QdTVNduWe21NDRBWawo6F6b8w8VRCRbARzcm9znq9oa+PRNyoWvppcY/auBDOWhR5tJt9lYs3re7q1wfhA5zBp+ncEsLYqE8pRvq3Dl7 gv2lCF4b Nq142Pp4fAvJ9F3IaIJERABVK0grZKcbKrC6l25BUTtbORAKz4UvBu7CdPSIc1nsD6OGLFNSqD9G5FjwAB1j7f0oWCf/r+Az9g2snytftQB+ZVO/V/SCFsfCJa/VPlugFAdKcQHzYCMfMhsAcU4ZZ/DIR7toI2wJu9k/ifvJBgcJNHYnKH++NKD/pbHoC55NGOB9ZqzcMGt5dWEXfcOcDtUE2uLyaEAADvzePFThTiAoTHoWWR1lf7jWwNWF0PP3cP3iO7whvBWhOYdQEeXsvAbFXuTPepaemTi4rpL1sqAqXnWBhN34OOfPkWyfAzCe+qyfhUJxUh49toI0uUn4KSyirncVq0TcNzFhrQSKWRkUEmDZQ/M2i6iZ0ArHyRX9y/onS4MnxLTYUUFHeaTNIIslHS3VQ3ptmaNgjyn1O/xnJFrIt7d/qFACYFzV6alUT/CnxDliLU8hRf/F9qS1/45GlBnZdcye5P1dO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Sep 2023, Matthew Wilcox wrote: > On Mon, Sep 25, 2023 at 01:32:02AM -0700, Hugh Dickins wrote: > > { > > struct page *page = __alloc_pages(gfp | __GFP_COMP, order, > > - preferred_nid, nodemask); > > + preferred_nid, nodemask); > > I really prefer not to do this "align arguments with opening bracket" > style. As long as they're indented enough to make them visually distinct > from indentation-for-if-blocks, I find it annoying when functions get > renamed to something with a different length and somebody then wastes > time reindenting all the arguments to match. Okay, I don't care much about inserting spaces to align with the bracket, but didn't like those continuation args leftward of function name above. I'll adjust in v2, and eventually we reach a compromise. > > > + return page_rmappable_folio(page); > > I don't particularly object to the main thrust of this patch. I'm not > sure I like it in huge_mm.h though. Maybe in mm/internal.h? I > wouldn't want anyone outside mm/ calling it. I was expecting more resistance :) Right, I put it in huge_mm.h to be next to your folio_prep_large_rmappable() declaration, but it doesn't have to be there. Ooh, there's a folio_undo_large_rmappable() in mm/internal.h, I'll move page_rmappable_folio() next to that. Hugh