From: David Hildenbrand <david@redhat.com>
To: Alistair Popple <apopple@nvidia.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Cc: Haiyue Wang <haiyuewa@163.com>, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH] cramfs: Fix incorrect physical page address calculation
Date: Tue, 23 Sep 2025 09:38:27 +0200 [thread overview]
Message-ID: <8bef63c3-f424-4b53-9165-b9ad789f1ada@redhat.com> (raw)
In-Reply-To: <20250923005333.3165032-1-apopple@nvidia.com>
On 23.09.25 02:53, Alistair Popple wrote:
> Commit 21aa65bf82a7 ("mm: remove callers of pfn_t functionality")
> incorrectly replaced the pfn with the physical address when calling
> vmf_insert_mixed(). Instead the phys_to_pfn_t() call should have been
> replaced with PHYS_PFN().
>
> Found by inspection after a similar issue was noted in fuse virtio_fs.
>
> Fixes: 21aa65bf82a7 ("mm: remove callers of pfn_t functionality")
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>
> Cc: Haiyue Wang <haiyuewa@163.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
Hopefully that's all now -- scanned the original patch and all
phys_to_pfn_t now seem to have a matching PHYS_PFN.
--
Cheers
David / dhildenb
prev parent reply other threads:[~2025-09-23 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 0:53 Alistair Popple
2025-09-23 6:56 ` Dev Jain
2025-09-23 7:38 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bef63c3-f424-4b53-9165-b9ad789f1ada@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=haiyuewa@163.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox