From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05639D29FA5 for ; Thu, 7 Nov 2024 00:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 669EA6B0085; Wed, 6 Nov 2024 19:57:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6193F6B0089; Wed, 6 Nov 2024 19:57:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B9DF6B008A; Wed, 6 Nov 2024 19:57:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 269AF6B0085 for ; Wed, 6 Nov 2024 19:57:39 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94C4CAB2C2 for ; Thu, 7 Nov 2024 00:57:38 +0000 (UTC) X-FDA: 82757484642.19.7465CA4 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 1DD3FC0009 for ; Thu, 7 Nov 2024 00:57:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of yukuai1@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yukuai1@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730940997; a=rsa-sha256; cv=none; b=h6FszVU3BHNFo0Cjuf3XQU1j5+oz5sI8vpOe/GJOiNrlf6VXBsXCXuyVPyPgY/bJPvhNn+ kiH7F9FfKhKnzmDsQjrloBRp34U+NAbXZLv5fH4+JvXmnlQMsIpv8mrGDqvTOy3PdJIm8y IoiLVQSKaPOg8tPgi3MluIJkIvsKg3o= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of yukuai1@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yukuai1@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730940997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpOhb50HktEr8Z/gVpS0c2EgEfl7YuIIDhcxEDdMSJA=; b=zc2hq0TnJgdrM0PKNU9wVT702l7auUjaNX9732ZwvQ4MWKDPuiBRCESQWeYqOK81Q2ntfJ fyE2EkHP1pEbViaqu/xMEhddwDyyp29fb+8u7giGW5n674+A79gBmFc4s90uRezGNYBE8J oWmW91nqSMwCuSnL8zHjZCNbPH9U3hs= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4XkNvZ6znYz4f3k6f for ; Thu, 7 Nov 2024 08:57:14 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id DBB731A058E for ; Thu, 7 Nov 2024 08:57:27 +0800 (CST) Received: from [10.174.176.73] (unknown [10.174.176.73]) by APP4 (Coremail) with SMTP id gCh0CgCHYoZzECxnGnRCBA--.54616S3; Thu, 07 Nov 2024 08:57:25 +0800 (CST) Subject: Re: [PATCH 6.6 00/28] fix CVE-2024-46701 To: Chuck Lever III , Yu Kuai Cc: Greg KH , linux-stable , "harry.wentland@amd.com" , "sunpeng.li@amd.com" , "Rodrigo.Siqueira@amd.com" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "Xinhui.Pan@amd.com" , "airlied@gmail.com" , Daniel Vetter , Al Viro , Christian Brauner , Liam Howlett , Andrew Morton , Hugh Dickins , "Matthew Wilcox (Oracle)" , Sasha Levin , "srinivasan.shanmugam@amd.com" , "chiahsuan.chung@amd.com" , "mingo@kernel.org" , "mgorman@techsingularity.net" , "chengming.zhou@linux.dev" , "zhangpeng.00@bytedance.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Linux FS Devel , "maple-tree@lists.infradead.org" , linux-mm , "yi.zhang@huawei.com" , yangerkun , "yukuai (C)" References: <20241024132009.2267260-1-yukuai1@huaweicloud.com> <2024110625-earwig-deport-d050@gregkh> <7AB98056-93CC-4DE5-AD42-49BA582D3BEF@oracle.com> From: Yu Kuai Message-ID: <8bdd405e-0086-5441-e185-3641446ba49d@huaweicloud.com> Date: Thu, 7 Nov 2024 08:57:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <7AB98056-93CC-4DE5-AD42-49BA582D3BEF@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgCHYoZzECxnGnRCBA--.54616S3 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFy8CryxXw1UtrWkXFWxCrg_yoW8tF4Upa yfJ3Z8Kr47ur18Gws7tayjvay0kan5X345urn5K345ZF1Y9FySgrWI9F15uF97GrsxCr17 KF1aqwn7J3WUJaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUB214x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka 0xkIwI1lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AKxVWrXVW3AwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTRJMa0UUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-Rspam-User: X-Rspamd-Queue-Id: 1DD3FC0009 X-Rspamd-Server: rspam11 X-Stat-Signature: 3eow639575rk5hbieyh3zwquur7nowbj X-HE-Tag: 1730941037-400325 X-HE-Meta: U2FsdGVkX18iTCtl2HYKZsXRXXPZpQ2gsrYBhC0NBND/5IppL3UR7eQ7kp5WX4McMle2VR/L2rpSIO9TZQ5KhH4a1mG/aYlkX719pafDkojPSlEWi1lcdgP/CeKKgoz6VjWd6UWDlbPslvbzRREayZMjBO/GxQrAj1MlAUiZ7+5mxXStOaAL1AWWS2WQ8NbxFVHvCY6OXzrutvNRvHh91hvs5v4I4KPjDqGymEz9RCNDvGcUwygAkrYNDsPaZf6BAzlfHXxCSxDe3D51+/ly3yz5EAYTrg1qypqqjOhdZhACtT4NIi60OTJjXamgo9UKVmAjNcDCx2yC9UBAY8locziDr/yz+aNXWZOFLSeVn5O7DwXoQkx2b/rEMyDaEgMZ6yyAlndFF2ve2kMjNlVSBZrioynVMk0cOdhZRUUa7/MNFO43f4va0ERSIprK1ZBBZakzUyj8hHJS0onJT5q44MV2KPUc1aTwvkSQr8m6O/mMBB4ToSkGjgeb9i/7/rJ0FrLdRdYJDbVG58yKhLGSrvmYstf8M11O6xaA2uyOKt9RPtMRhVjmVuA3P8TD7ITjayYgRZYx7J0LcsThER8RKV8Mj+Ruo9AqC5/Giisv5/8stxJ97C79Wn0fINqMrlOkFtfDfVS3irIg7LbInQ03nVIVWg9QquUetx3pkDgJRxP20J6EFNqBneUfXmaR4ZZ6uBh6WXwie/mVEl8T2RAUt34sJvtefrsBx03MT8mVyRZaOz6v9c8Pp8PudCm74A7c49nDdAL0Ex46uBnRSBVKEMtblMTJ9KNUBDjFVnR/jp/T0UqBEbmH5sXg3EKYse4hfQHPAe18rg7yyzplfapbyNrPgwp7izRr1ScNcaIHZQ11vgroU8RmIdRKCXJU/qsjgQ8qbcBr9VHDqw/KDXD41NYyGnxZTw2g5APGS3UiyACf0znuQCkheOokknyozg2W7i4dM4RChfoEJC6fpgl jjRB01nw Rl8VTU7GdeR1TS8sbxJvuTGfTMy2vwLHiW9kzQds1UgSGGAFyzX4veBVt9eg1OkeWUc86ZqcECmjaoNOlQYiCOoPjtp9HCQImadn4TK/JsaLnaZremFuJ02jOK/X+klNqGWou+GhCU/HJct7/ziMCAUmpioanae9bRN6LsvOg4FR7Y2I8dJjos5awLNR6OKQpJRMaIjgNxPbkS8JTU/tpJdEQjNb2cbVqlMJzTLOqLPKDEgsuExUFFlLMSFiyarG1icw7lUBqQ0vXbZ2/HoYxOsKIXVi/p56FURWoj49MZUqHb5kjmN3LDPuxqGMtqfHJEgl2Y1lutCcsjr4Xz9yuUaUH9duikbsuCDvP2sG37XOPDSw6IX40xIS+asjVt8xTLNFL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, 在 2024/11/06 23:19, Chuck Lever III 写道: > > >> On Nov 6, 2024, at 1:16 AM, Greg KH wrote: >> >> On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: >>> From: Yu Kuai >>> >>> Fix patch is patch 27, relied patches are from: > > I assume patch 27 is: > > libfs: fix infinite directory reads for offset dir > > https://lore.kernel.org/stable/20241024132225.2271667-12-yukuai1@huaweicloud.com/ > > I don't think the Maple tree patches are a hard > requirement for this fix. And note that libfs did > not use Maple tree originally because I was told > at that time that Maple tree was not yet mature. > > So, a better approach might be to fit the fix > onto linux-6.6.y while sticking with xarray. The painful part is that using xarray is not acceptable, the offet is just 32 bit and if it overflows, readdir will read nothing. That's why maple_tree has to be used. Thanks, Kuai > > This is the first I've heard of this CVE. It > would help if the patch authors got some > notification when these are filed. > > >>> - patches from set [1] to add helpers to maple_tree, the last patch to >>> improve fork() performance is not backported; >> >> So things slowed down? >> >>> - patches from set [2] to change maple_tree, and follow up fixes; >>> - patches from set [3] to convert offset_ctx from xarray to maple_tree; >>> >>> Please notice that I'm not an expert in this area, and I'm afraid to >>> make manual changes. That's why patch 16 revert the commit that is >>> different from mainline and will cause conflict backporting new patches. >>> patch 28 pick the original mainline patch again. >>> >>> (And this is what we did to fix the CVE in downstream kernels). >>> >>> [1] https://lore.kernel.org/all/20231027033845.90608-1-zhangpeng.00@bytedance.com/ >>> [2] https://lore.kernel.org/all/20231101171629.3612299-2-Liam.Howlett@oracle.com/T/ >>> [3] https://lore.kernel.org/all/170820083431.6328.16233178852085891453.stgit@91.116.238.104.host.secureserver.net/ >> >> This series looks rough. I want to have the maintainers of these >> files/subsystems to ack this before being able to take them. >> >> thanks, >> >> greg k-h > > -- > Chuck Lever > >