From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12984C47DD9 for ; Fri, 23 Feb 2024 03:12:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85CF86B00BB; Thu, 22 Feb 2024 22:12:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E68C6B00BC; Thu, 22 Feb 2024 22:12:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE376B00BD; Thu, 22 Feb 2024 22:12:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 586986B00BB for ; Thu, 22 Feb 2024 22:12:18 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6931120FEC for ; Fri, 23 Feb 2024 03:12:17 +0000 (UTC) X-FDA: 81821595114.23.9FC6B95 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf21.hostedemail.com (Postfix) with ESMTP id 63E8F1C000E for ; Fri, 23 Feb 2024 03:12:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf21.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708657935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrygkVLNhCED6wwr6Qls1CAsyMtpXogljZl8GcwaQuE=; b=MbWr29B5I6jjlR86OzmF0oUFhD+Gw3OSgk1crPoiGmlgEk+Xbs7ifvgrxkFB1J6XL8EeHd z4xx7H3xklHXWqdSkUYUOJbcWtaifF1tcoymG/FgrWdtkVoTYClayrth77mkTTAlrUICPT BwwEgsDw7a4rK11Yd1gOHNuUyggyYQY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf21.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708657935; a=rsa-sha256; cv=none; b=yNgg/AMaJYkiJ6Se5WUejpJDfKD8+4t+SIzqS9H9n1m3f48kuaG33xqAXC2ZPvr5gpv3GS HwPPrpSHBVk4KKxXPQf/txkK7alJvvpgW5ywc5RbwSlsnfRa7Cv8hNZXIdgkQeTfO3t0nh Dim3UhaobkSiQWnI9DsOr9worc6Z7lY= Received: by gentwo.org (Postfix, from userid 1003) id 155E640AA8; Thu, 22 Feb 2024 19:12:14 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 14C8D40788; Thu, 22 Feb 2024 19:12:14 -0800 (PST) Date: Thu, 22 Feb 2024 19:12:14 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Vlastimil Babka cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH 2/3] mm, slab: use an enum to define SLAB_ cache creation flags In-Reply-To: <20240220-slab-cleanup-flags-v1-2-e657e373944a@suse.cz> Message-ID: <8bc31ec7-5d6e-b4c0-9d6e-42849673f35f@linux.com> References: <20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz> <20240220-slab-cleanup-flags-v1-2-e657e373944a@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 63E8F1C000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 59y1xar7m9hc6a1ypygypx9q3btxf67f X-HE-Tag: 1708657935-273350 X-HE-Meta: U2FsdGVkX1/Qg+xuU9CPWGx7aBS+1z0MqEa0m2InsEPEId+BhGBKpCqR4/zqr7A47hxyRIIsoCMhMcu1yEqnVxFzSvBW9HmxhrnlkoIE7+Lk1M4fGhr5EdcYInLGOW3UaDFn5/ZQzIVn663pAFb7iND/m8Q2mqgRzjgqEbMfzIqcikA/z9iC2d99iXF03dqft3G7K1QrZXwUkOBjVFPOWpmcJ6j2HY+c74NUgZ1CcD8bkKAr3d2S2940YXv4+N6ay1aFeFKVTRMbjIZ/TbqtBwYYjlmlBz2xAS7SEXTbAS/WE+9sWQCGEiR3YH4hpOLqma2rT0HRnFTZbQFT3+69dna7q8UXseHlSfe2A2AkQgY2DC66h9GM24Qrb4TJuy6zDxPhxk42lK899ZyTjPoIFrzYd48onxIuE0tSnL7/rQVdlqU1mxIYlbLaR9kEe4ZbwNTJbNVeoj8b8bKa+sC1PLLTmJ7tnXz2Vk0fTzKtcNMDUQpBKO3Z4cE5pHR6bhnKPXbNkpSK0ygdg50NE4phPhZiCTL9zkoPBPqqqpqYKfx0ORHNsiCLRYcpk7lYoJBHFvTZnFfAxEht1Rk5DN4EIsDWLjYR5bJ9nTzjkqh/3YT8gNDwVpjPji3e2EA2tEzfh4zIHN9luWavtILZXDqWnhQRg5iZ+Ap/SPnuWaJ7EL88mDN9E24oW2R4kh6WuYJXml8CcxVLBfo2BiX8K6who8XOlQeNsi0arXunkdTe1jQhlb/J+AjzaVoXgCCxlgoowdtckpUkHkjEENMIZ1E4bqEisomhbHNktj3KsPtmpPIXfN6SiGlKGSHNHnlavSlstaE5ft/LgZH+LqjDf0uQsVdj0A9hi9thAo3fgjIc4KPY8Lqvy1wApWUoLder27MOJV1RBZ5WG3zqe0lv4eSmk33cBxlCUiO9k5CXNqGPV1dgEO4bWu7QnJdSRrxghUQuZwI6SzTp87s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20 Feb 2024, Vlastimil Babka wrote: > diff --git a/mm/slub.c b/mm/slub.c > index 2ef88bbf56a3..a93c5a17cbbb 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -306,13 +306,13 @@ static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s) > > /* Internal SLUB flags */ > /* Poison object */ > -#define __OBJECT_POISON ((slab_flags_t __force)0x80000000U) > +#define __OBJECT_POISON __SF_BIT(_SLAB_OBJECT_POISON) > /* Use cmpxchg_double */ > > #ifdef system_has_freelist_aba > -#define __CMPXCHG_DOUBLE ((slab_flags_t __force)0x40000000U) > +#define __CMPXCHG_DOUBLE __SF_BIT(_SLAB_CMPXCHG_DOUBLE) > #else > -#define __CMPXCHG_DOUBLE ((slab_flags_t __force)0U) > +#define __CMPXCHG_DOUBLE 0 > #endif Maybe its good to put these internal flags together with the other flags. After all there is no other slab allocator available anymore and having them all together avoids confusion.