From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA925C43470 for ; Fri, 14 May 2021 08:28:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3351461463 for ; Fri, 14 May 2021 08:28:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3351461463 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 428EF6B0036; Fri, 14 May 2021 04:28:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B1E46B006E; Fri, 14 May 2021 04:28:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B7CE6B0070; Fri, 14 May 2021 04:28:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id D7EB66B0036 for ; Fri, 14 May 2021 04:28:00 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5D1B3B293 for ; Fri, 14 May 2021 08:28:00 +0000 (UTC) X-FDA: 78139158720.39.657211C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf21.hostedemail.com (Postfix) with ESMTP id AF510E000106 for ; Fri, 14 May 2021 08:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620980878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1mI4ocY2raC+FaNmp1QLwbvQ7SwKQVD3QJeG7UD1jEM=; b=iXYDlPaS8WpmpPS49wnnbXvTx2mWguZI1FVoaWJ4VHxUIs2V4Rw05C9yq2YORtKc+Uccif Bi2RtC5HqbkyeHc6TzV7hqjjvsxCtv13N2zBUawSIX+UUATc7Lys0gJwyDoJr7LTcRS1YA xxTJQa0PDwGJYygm3mSO4TkEuvDU2SM= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-5b_EqWb8NaeRVgva3SSLsw-1; Fri, 14 May 2021 04:27:55 -0400 X-MC-Unique: 5b_EqWb8NaeRVgva3SSLsw-1 Received: by mail-ed1-f70.google.com with SMTP id q18-20020a50cc920000b029038cf491864cso670904edi.14 for ; Fri, 14 May 2021 01:27:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1mI4ocY2raC+FaNmp1QLwbvQ7SwKQVD3QJeG7UD1jEM=; b=PidDjEMDKBcKR7pPcHBjiJV64Jf+I+3KuuWICxNSKId62gEKa94AX24anO6eoGDaA6 7jSMoVkx3Ko/zwVNUN9CkHNNoa5FrW95im3UVcRmLIdoTnNby/YFnup64azvhKsiEcya Zstj+Kavo5xsZSn6XBSNk8guCozhJBfg23frak/BLfB9sM/npulQpJYdVvdYRaOxlvbX 1ZreocGMLV+hG+N/4SweluURvardd+PjG5jflVryDibBnq7Ymm475/8C2zBcGxcz3KyX DGh+LDO8qbkzGdl18Ccttzq4fGx98SQqK4rjIgwy5U3S1KbAvyeZ2n8jLzVfsrMHVIfv OPPw== X-Gm-Message-State: AOAM5310OlqILPEI9YX2y0bP/xkW4TigddgiXFSQA8yH5+zMugAMW37I FYqBXJxiaqkNDrL0wkiS2P7nJXNM3hPvb3JZ5eNxohSzKYT3KkmfMaPy5bx2TOO/VLR9D+ym52o G9Y0FCHPABWU= X-Received: by 2002:a17:907:2136:: with SMTP id qo22mr5726966ejb.246.1620980874021; Fri, 14 May 2021 01:27:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYM3IfGE3NxrG0ZrIWpmGkbHrM02LfrvrKJb1wjjik/A6PZcbISFg2IAai8LzSK6j7yfSBCQ== X-Received: by 2002:a17:907:2136:: with SMTP id qo22mr5726935ejb.246.1620980873769; Fri, 14 May 2021 01:27:53 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6501.dip0.t-ipconnect.de. [91.12.101.1]) by smtp.gmail.com with ESMTPSA id z26sm3292663ejl.38.2021.05.14.01.27.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 01:27:53 -0700 (PDT) Subject: Re: [PATCH v19 1/8] mmap: make mlock_future_check() global To: Mike Rapoport , Andrew Morton Cc: Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , Elena Reshetova , "H. Peter Anvin" , Hagen Paul Pfeifer , Ingo Molnar , James Bottomley , Kees Cook , "Kirill A. Shutemov" , Matthew Wilcox , Matthew Garrett , Mark Rutland , Michal Hocko , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , "Rafael J. Wysocki" , Rick Edgecombe , Roman Gushchin , Shakeel Butt , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , Yury Norov , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org References: <20210513184734.29317-1-rppt@kernel.org> <20210513184734.29317-2-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <8bb6ca25-5d30-70e6-c590-5930832ec9b2@redhat.com> Date: Fri, 14 May 2021 10:27:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210513184734.29317-2-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iXYDlPaS; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AF510E000106 X-Stat-Signature: awbx47qh6gf4yaagnwebcsy3kdoidcgi X-HE-Tag: 1620980879-584571 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.05.21 20:47, Mike Rapoport wrote: > From: Mike Rapoport > > It will be used by the upcoming secret memory implementation. > > Signed-off-by: Mike Rapoport > Cc: Alexander Viro > Cc: Andy Lutomirski > Cc: Arnd Bergmann > Cc: Borislav Petkov > Cc: Catalin Marinas > Cc: Christopher Lameter > Cc: Dan Williams > Cc: Dave Hansen > Cc: David Hildenbrand > Cc: Elena Reshetova > Cc: Hagen Paul Pfeifer > Cc: "H. Peter Anvin" > Cc: Ingo Molnar > Cc: James Bottomley > Cc: "Kirill A. Shutemov" > Cc: Mark Rutland > Cc: Matthew Wilcox > Cc: Michael Kerrisk > Cc: Palmer Dabbelt > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Peter Zijlstra > Cc: Rick Edgecombe > Cc: Roman Gushchin > Cc: Shakeel Butt > Cc: Shuah Khan > Cc: Thomas Gleixner > Cc: Tycho Andersen > Cc: Will Deacon > --- > mm/internal.h | 3 +++ > mm/mmap.c | 5 ++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 54bd0dc2c23c..46eb82eaa195 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -373,6 +373,9 @@ static inline void munlock_vma_pages_all(struct vm_area_struct *vma) > extern void mlock_vma_page(struct page *page); > extern unsigned int munlock_vma_page(struct page *page); > > +extern int mlock_future_check(struct mm_struct *mm, unsigned long flags, > + unsigned long len); > + > /* > * Clear the page's PageMlocked(). This can be useful in a situation where > * we want to unconditionally remove a page from the pagecache -- e.g., > diff --git a/mm/mmap.c b/mm/mmap.c > index 0584e540246e..81f5595a8490 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1352,9 +1352,8 @@ static inline unsigned long round_hint_to_min(unsigned long hint) > return hint; > } > > -static inline int mlock_future_check(struct mm_struct *mm, > - unsigned long flags, > - unsigned long len) > +int mlock_future_check(struct mm_struct *mm, unsigned long flags, > + unsigned long len) > { > unsigned long locked, lock_limit; > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb