From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E530C433F5 for ; Fri, 11 Mar 2022 06:18:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAAFF8D0002; Fri, 11 Mar 2022 01:18:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C32DD8D0001; Fri, 11 Mar 2022 01:18:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD2FA8D0002; Fri, 11 Mar 2022 01:18:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 993E18D0001 for ; Fri, 11 Mar 2022 01:18:57 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5A1B124646 for ; Fri, 11 Mar 2022 06:18:57 +0000 (UTC) X-FDA: 79231102314.02.3DAF699 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 84980140011 for ; Fri, 11 Mar 2022 06:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646979536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VmNykLNZNCecqG/aP33jF1bp4ILM+d6PRQpChl7FYR8=; b=aaqRI3tkONYsMliUp7XbtdrQJSkWvCmC1y00v+dskmYT92wPZuhzT4NTjoQlcxcpRXXk4v /IZDFSWPNc+FFBOW6EZRN7pXBH5KYULBm6RCPvSzyWjhbpMBzS6oqV2lH14UQMKiO+60Bw YSUSIfn9DV8YefQQvGvjffMxZw/Invk= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-550-OyMGwETWPeqtunVa6fo9Tg-1; Fri, 11 Mar 2022 01:18:54 -0500 X-MC-Unique: OyMGwETWPeqtunVa6fo9Tg-1 Received: by mail-lj1-f200.google.com with SMTP id l11-20020a2e99cb000000b00247c058c077so2974977ljj.18 for ; Thu, 10 Mar 2022 22:18:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VmNykLNZNCecqG/aP33jF1bp4ILM+d6PRQpChl7FYR8=; b=8HtViHK2cAiokC5uKOTNwuGWBxADc+2EGIVG4nvA3YbnzqHVuOBLZmvW/RVCbdIupM wuBAeMDH5Yp7EYgPJ71J0BTc72DsIb0YG/MTOJCfnxwQLJ+hfx5EgndBD8MN2Nuy+QXP FZ5EcClcTVtCHtvqitzdZS/M9NNkLnjMBtJCqcamyQPmnJaersfwVXrNaAKPI6Y0c38m NX+0mcpdXPFxhWMbEd78OxyS7B7hEs626fZPXO36QwR2vpcppuJvxvln9bznVl+Q1YmU DhgU4mNuXk5rvnsFrtdqDfoFcA5lm9p3C6g9fRDnpKBSwcSRK28NHhJu7vVS9Sqp5nzS bE0w== X-Gm-Message-State: AOAM533ZaGgoVea6zToQzDK8qwKf9wtSj1xKiRfmJ5oiHq5dmCvM9iaj MGhw6nqcmAaUInvFurMZHQsBYo6a4rJr5PQLK+GtKwqNmq0KF7YefAJlt/XNA9gB26e+vzfxgyo KeD8eKoayTQ== X-Received: by 2002:a2e:84cc:0:b0:247:e395:7948 with SMTP id q12-20020a2e84cc000000b00247e3957948mr5109756ljh.499.1646979533183; Thu, 10 Mar 2022 22:18:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3pZdulEss4gvvxl90sW7OTuEHg4qr/SUr/leSBxeLeAWD66PcOmH+rNEd7tWTZmxOo/LfoA== X-Received: by 2002:a2e:84cc:0:b0:247:e395:7948 with SMTP id q12-20020a2e84cc000000b00247e3957948mr5109742ljh.499.1646979532898; Thu, 10 Mar 2022 22:18:52 -0800 (PST) Received: from [192.168.1.121] (91-145-109-188.bb.dnainternet.fi. [91.145.109.188]) by smtp.gmail.com with ESMTPSA id g1-20020a19e041000000b00443131b3efcsm1413528lfj.284.2022.03.10.22.18.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 22:18:52 -0800 (PST) Message-ID: <8b9e7ef4-10b9-1061-d12f-76fd62e1ae2d@redhat.com> Date: Fri, 11 Mar 2022 08:18:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev To: John Hubbard , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: apopple@nvidia.com, rcampbell@nvidia.com, jgg@ziepe.ca, vbabka@suse.cz References: <20220311033050.22724-1-mpenttil@redhat.com> <179e3540-b9bf-5fd2-cfa4-f7274b6c33d1@nvidia.com> From: =?UTF-8?Q?Mika_Penttil=c3=a4?= In-Reply-To: <179e3540-b9bf-5fd2-cfa4-f7274b6c33d1@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 84980140011 X-Stat-Signature: 3irjs78xyf44ie35esrfprbatwym7but Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aaqRI3tk; spf=none (imf23.hostedemail.com: domain of mpenttil@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1646979536-638647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.3.2022 8.15, John Hubbard wrote: > On 3/10/22 19:30, mpenttil@redhat.com wrote: >> From: Mika Penttilä >> >> HMM selftests use an in-kernel pseudo device to emulate device private >> memory. The pseudo device registers a major device range for two pseudo >> device instances. User space has a script that reads /proc/devices in >> order to find the assigned major number, and sends that to mknod(1), >> once for each node. >> >> This duplicates a fair amount of boilerplate that misc device can do >> instead. >> >> Change this to use misc device, which makes the device node names appear >> for us. This also enables udev-like processing if desired. >> >> Delete the /proc/devices parsing from the user-space test script, now >> that it is unnecessary. >> >> v2: >>          - Cleanups per review comments from John Hubbard >>          - Added Tested-by and Ccs > > The three lines above, starting with "v2:", belong after the "---". That > way, they are not included in the commit log. That's the convention. > > I think Andrew can fix it up for you, no need to spin a new patch for > that. > > Anyway, this looks good now, so please feel free to add: > > Reviewed-by: John Hubbard Thanks John! > > > thanks,