Re: [PATCH v3 16/16] mm: replace remaining pte_to_swp_entry() with softleaf_from_pte()

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Thu, Nov 27, 2025 at 06:53:21PM +0100, Vlastimil Babka wrote:
> On 11/10/25 23:21, Lorenzo Stoakes wrote:
> > There are straggler invocations of pte_to_swp_entry() lying around, replace
> > all of these with the software leaf entry equivalent - softleaf_from_pte().
> >
> > With those removed, eliminate pte_to_swp_entry() altogether.
>
> RIP.
>
> > No functional change intended.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>

Thanks for the review!

> Impressive work, I hope it can be promoted to mm-stable now. It would be a

Thanks.

It's already in mm-stable?

> pain not to have it merged in the 6.19 merge window. Still plenty of time to

I have no idea why it wouldn't be?

> fix up any hypothetical bugs not found until now during the rc's - overall
> it looks solid.

Right yeah. It's been sat in -next for ages. The bug you found (thanks!) must be
pretty hard to hit... even by syzbot!

Maybe there are others, this touches a lot, but obviously that's what rc's are
for. I think you can say the same about literally any other series currently in
mm-stable :)

Please can we in no way delay this. This work is very important in my view and I
intend to base further work upon it in the upcoming cycle.

>
> Thanks!
> Vlastimil

Cheers, Lorenzo