From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDB5C54E71 for ; Fri, 22 Mar 2024 09:02:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 809BB6B0092; Fri, 22 Mar 2024 05:02:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B97D6B0098; Fri, 22 Mar 2024 05:02:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 632F26B0099; Fri, 22 Mar 2024 05:02:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E8F76B0092 for ; Fri, 22 Mar 2024 05:02:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF7AEA0F0E for ; Fri, 22 Mar 2024 09:02:20 +0000 (UTC) X-FDA: 81924083640.13.11F523A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id BD0A4100028 for ; Fri, 22 Mar 2024 09:02:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LEOsH4rQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711098137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qym5CaidiUi9Oi/CRseq7D3a5psds7G5Xip0Z6wJ3A8=; b=ikmQfhd83oUOCLC8m2qSo6y1RpiPNJiYtK7BuquR6rojS8IxDqUzlDgV4WBL5nQR/65P2G r3esRbWL0RGrvAjOywl82ZOtmC96h/xdGocWlDHqib9QZ5gU9Xt19S8vEcM2lZMZCximAd CggwvnTgv+buCa+uWhBa1aYcLSjfcOY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LEOsH4rQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711098137; a=rsa-sha256; cv=none; b=6mZ5ROwhPreqGb9PJQy9ye2IuccsvR+gKpooC3tAtxaLt5tyCOjMllv+EmsXPmScGGyDa3 HFfWRKlVZ9ZZ/Hv7vGcGJTw9ZLK8l7k7ARWuMSLYCdauYn1HcxU2sUGQ//n9ckWdvSdJmR ocKrUwpYpWRmlzgchQpPS+AEoXHtziA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711098137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Qym5CaidiUi9Oi/CRseq7D3a5psds7G5Xip0Z6wJ3A8=; b=LEOsH4rQvpraYtp4vSsF+e838Mj83R+tHI7T9AnjAaFdYnDbsKmU6WQFETYsNH6Afo/xCh JkKOxDOFbMPZXjmx75XkLGoWZ74CfL9fM89NLudYdv2e4HUH1DMFAptQ9F+C/023pM/McS WxbC1hW7GHBFDW6OqdOWjOVUf+kPJ+0= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-Zk6x_RQ3PUe1f52r0Dcn1w-1; Fri, 22 Mar 2024 05:02:15 -0400 X-MC-Unique: Zk6x_RQ3PUe1f52r0Dcn1w-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-514b4c75fc5so2070898e87.2 for ; Fri, 22 Mar 2024 02:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711098134; x=1711702934; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qym5CaidiUi9Oi/CRseq7D3a5psds7G5Xip0Z6wJ3A8=; b=l2lTaBlZ4NeMPI3CTs8nWTUs+p2T7MfTBWtLPwf1jzdXtjwclv2FQNbs2qHHcvh4xN cwSwYsLk4sThsBZqzZMtIbdbH07TKmEYpqO6k4x4TmftFXX1GRo4PGu5LzLCcd8ZNs12 XYLmZhvxjvc4jXWIU9fXxqUhpE9LuoObQqgJoDSzUrXkc4fodjpOrVE4MdJzBW4J9sGP UhAeDPhl5snUSedyn/XFwnXxLEfgghoFz7zoqdeNQzUd2opakHabSGmpQmqI+erYGtpo VRb3jia3YCPd1deBvTZuBYuYyK9rDWrF3QvmVXeveKFGP3Rqj2Gu0rAfFHsvpSRDj3kw L3RA== X-Forwarded-Encrypted: i=1; AJvYcCXpxaz9csf45uhpyN1WsYwcI4CN9+w4i74ZqoBYXUEcFAv9P+oGlUZ3vJ3r/sI/Ku/UgxFbAb2f5/AFC0uEWkhlrbQ= X-Gm-Message-State: AOJu0Yw7EmN9zzC7oECFFDGuF4l2g/uu0nl+oas0t1ZZO+Gi1mMV7mbF DvsNA+wKjX0MNsBL2097FCY+kbG+gfgho0jziLLWEJ5Yl8BtT9Em0kvPnYJaES+3sDxhIEJINR7 /S7sSmJGBddh2XxotrXtwKgWVQM0C99XzsecqE+JGPyFSF3ke X-Received: by 2002:ac2:4a62:0:b0:513:cdb9:bd61 with SMTP id q2-20020ac24a62000000b00513cdb9bd61mr1165399lfp.12.1711098133806; Fri, 22 Mar 2024 02:02:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcM+kwCnpKrZTFZ635VgadHAKH96SrYB3HnQjPXT1Drn/zEtEgzBgwO5W4JYCgVVmaUaXKAA== X-Received: by 2002:ac2:4a62:0:b0:513:cdb9:bd61 with SMTP id q2-20020ac24a62000000b00513cdb9bd61mr1165381lfp.12.1711098133388; Fri, 22 Mar 2024 02:02:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7e00:9339:4017:7111:82d0? (p200300cbc71b7e0093394017711182d0.dip0.t-ipconnect.de. [2003:cb:c71b:7e00:9339:4017:7111:82d0]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c4e8900b00413e79344b7sm2424778wmq.19.2024.03.22.02.02.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 02:02:12 -0700 (PDT) Message-ID: <8b5e8d52-ab93-4e2e-aab7-43221f891aae@redhat.com> Date: Fri, 22 Mar 2024 10:02:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/ksm: fix ksm exec support for prctl To: Jinjiang Tu , akpm@linux-foundation.org, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org References: <20240322060947.3254967-1-tujinjiang@huawei.com> <20240322060947.3254967-2-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240322060947.3254967-2-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 7qnxdjgirj4bergnekqd5f4441qbbouf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BD0A4100028 X-HE-Tag: 1711098137-959491 X-HE-Meta: U2FsdGVkX19O/deeWrPLdl3ha749jpiiVvAJ235X9fR/bB2OD8HlJEmOTYOquUnpH6wMx/Hx+W+qwhz4UCSJIMSNismDuB6h5gbA3cr2cUyD6VhYtqbq3vrzB0Tbe38aoW3inq8J57FLZRiZNhVbcLNuny2M+WXmtrBJ5a4B2D2CKT07YAHt6eg3drqOylOzGWs5q29TGZihH+Rf5XIkFL2cmnD1FdIscY/S9hZ6uR+t0wXe2FKJAcfBhtbymk5yYpY206xipr57DaaHqlwbmOptP4cDUQBa8ov7MAdh1f8moRvt+UVy2m9ohyh89PYwU/qBzQrVCvp9i3UKiphm/JoxkiontzT4/fO5bd8kI/q1fbzMnU5qxoRLFjpZSB1eU8VGqMDLL4dzOtuVCDlJyHw2zsDP4nqDpFzAdes7niW/XjVwzTQC8vTTCRWHKe4lbIFzjIB+Z8Ly52zwH0QSh9jFXJ2bog10U3AgBBbUSTrcoXb1aDH8EKcXHO/2w1oUtBcs3Dv/HdSMJzKcE+DlJwaXBXomrmwOEm2uiXN5k6TpMuLw4RfUB5eNEIMRLkYs9G9aEjgk/y7XeCGnm3qqsh+wvAPwR7zUfGm/MbrtVDTlri4ZTohjJW75J7s8r80HGXzG4vLgx/OdCM1TZZQ1NTwRPiMVlJczYbrweGZB1FkJsrRLnXJWwIttUhclTrnpTGhKaROsvNqZCgl8BWFfnU8ipsAlKQ+GrPHfPsHaN35V2rZ1Eu9ulZISkIeUo9F9bssMurlL8Oy6kJo3nM+lAsbZTvTyk8d1ji8kGpjNEhjX5LbfMzOZafpB1UQocdVBcYFP4Mdrqr8wFrczYZY/kfF8rIEpTJh6Dx2lRvfrGpJNhRMXD0pgUiFyEtfiNiQRDj1TbDpVbsCtG3PtpvHWr/LPvO1/cnv5pUGC/uHrXflf475R0uD42d4nU0BpiYdXbDskKWhs4o32n0PjbhJ 7smNj54L NwC8aLUxHST9h+G4lAZXITO0llSqw13pcO0c1qGMBzY+s3BbCiC9pBCUe5HZHLT38uccCR4Xmne6oTlDXcAYr0KytdQGg22HkiLFoUOtkgsHo7ss4XJo0uWBPAa/nGpvRn2d21UDJSeRNpuojy7nHkV9My8Gd9aAHdokTV3QUf6IMfKU52C53Px4wbBpuvSnNC5w5G+qqzL1MkXUQtQy/Ln2z7YRA/EEnrNbmGBXA4VD3jwypxiUqPKgAyiHy1YfOGRJCNgEOIe97NT7xX4Dqre9DyykvHrXIv10NArl5wdvhABjzUPbIzD6vmOr7QQ1Lu9d55K7JGfnJZeyOkgGCprUWsgORr+2Fx81F52hY3nAO3oKet4pClJLkmyY9AVb5Bfb3fq0B3rYnGcxPZsE0paJs0hGwXjcq0g1JZcRqTr8lJShQiR0WoFRYtLQJQ3mrXt+98dNRYqXhMYkZZVXtn7Bop3WKYfA89efT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.03.24 07:09, Jinjiang Tu wrote: > commit 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") inherits > MMF_VM_MERGE_ANY flag when a task calls execve(). Howerver, it doesn't > create the mm_slot, so ksmd will not try to scan this task. > > To fix it, allocate and add the mm_slot to ksm_mm_head in __bprm_mm_init() > when the mm has MMF_VM_MERGE_ANY flag. > > Fixes: 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") > Signed-off-by: Jinjiang Tu > --- > fs/exec.c | 10 ++++++++++ > include/linux/ksm.h | 13 +++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/fs/exec.c b/fs/exec.c > index ff6f26671cfc..66202d016a0a 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -67,6 +67,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -267,6 +268,13 @@ static int __bprm_mm_init(struct linux_binprm *bprm) > goto err_free; > } > > + /* > + * Need to be called with mmap write lock > + * held, to avoid race with ksmd. > + */ > + if (ksm_execve(mm)) > + goto err_ksm; > + But now, would we revert what insert_vm_struct() did? We're freeing the VMA later, but we might have accounted memory. What would be cleaner is doing the ksm_execve() before the insert_vm_struct(), and then cleaning up in case insert_vm_struct() failed. -- Cheers, David / dhildenb