From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63620C36001 for ; Thu, 20 Mar 2025 16:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766BC280003; Thu, 20 Mar 2025 12:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F106280001; Thu, 20 Mar 2025 12:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5682E280003; Thu, 20 Mar 2025 12:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 30562280001 for ; Thu, 20 Mar 2025 12:55:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 322C81CC717 for ; Thu, 20 Mar 2025 16:55:47 +0000 (UTC) X-FDA: 83242531134.15.19E2EB7 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 6B64EA0024 for ; Thu, 20 Mar 2025 16:55:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742489745; a=rsa-sha256; cv=none; b=U3qo2B6zAVg4Di5mWNtbWcpB63YhIq2KimgIoKCYrk4JMzrKdq82RRq7/86BX0H2tPh+QQ qlhBGZxzrHm6uC9uwLVCmT0FBufh7W7CT20SigibPuYMSIh2047LyGvBMpvkUa7Tb8ZBtm e1eXLJrYQuR0fdeNIpHby8f/Vl0EDK8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742489745; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cESvC4LT0egAIOny8aWYQ6lxbETK/HKS0OTbS1TOsqM=; b=lS/wMSjsCEK1J2H0iqS7sLVHJNdnjWvNzuhJeXNUnsb6fis3spLvZ4Kk2ieeEsZp98p4jd sTcx4Gp7KiR0/M7pSmu3sFzYzgMOfyKngtTc4zY2f3c0p8JxMz3W9LWuObeLnBxDqUOV7q uE4UDh4CBsOtJORpOHGefhZV5DJgwsw= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tvJAp-000000001zx-13kX; Thu, 20 Mar 2025 12:55:15 -0400 Message-ID: <8b5e03015a5783ed4c80ad0bd57e09e651d890d3.camel@surriel.com> Subject: Re: [PATCH] mm/vmscan: batch TLB flush during memory reclaim From: Rik van Riel To: kernel test robot , Vinay Banakar Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, kernel-team@meta.com, Bharata B Rao , Dave Hansen , Peter Zijlstra , Borislav Petkov , SeongJae Park , Matthew Wilcox , Byungchul Park , Brendan Jackman Date: Thu, 20 Mar 2025 12:55:15 -0400 In-Reply-To: <202503201810.9JxSMo0Q-lkp@intel.com> References: <20250319132818.1003878b@fangorn> <202503201810.9JxSMo0Q-lkp@intel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 6B64EA0024 X-Rspamd-Server: rspam05 X-Stat-Signature: yxkwnu4syuxs5ithxc6causokhzbcc3c X-HE-Tag: 1742489745-358325 X-HE-Meta: U2FsdGVkX1+QIglhA9p8wG6kumzixquxtkvAkDj6TMqNJSPqw0zLmJ5FZsoBznpnEbuZ/9UBFR0uagDAMpxSFS23Y8MQtESpt2KJsMcKu2/N2zLpoS/ANQIDIJA0NpOTZXQ6zE8yatQvbClPJIpLdXKZXcm+fMhSscdw2ctUkTaF8evv6VDze2X0bHAX4M31/Odi7u/+URxaNm8lEHjrTi32hgseTqwJl4Se/8/yWntnu0K1Z3AOdQMhIIi417Jf+j/IHHYRNcofmVWnucazF9rMa8BJknhVHdA/RCqyxEm1tUfjjVlz+9X/JzKYui0StcafTYrHBJ2mEgbLYFinUCvEfZQqU2KiL25Ax0ItN0f2iuC/0TVa6+6yTGbA7rd5uVBTVbeoBX4Gk+RyR/U4i6SsT3dJm230m7+mb4QYh4S/jh3Ix34kUjNog7Tu2/CUvov+Qp2V+EF76cyVhUiFjuIvN+e8xVmZzjeZ41n6A2ksMhRBb2Q/pKl3ivg/Dt6x7RQKLd3mka6Th+D1nzSo2lSZ4v3zydLyp9MTfiHiB/DEqMy2mZFpDbKfdT39Q/l30gnqBSznVCU0ZkjXd6enC+Me774QSmlc+/D/pxWSU0oGJ+u5xgYUrQGc9qINKUi+moLidwVV8avLAr2mZlh2k6BKm1VgV23t61ASa08QQCxqmT5VRoo1ApFBB13faU9yDytnXGT0MTD6ZG5yMRxPYMDBXiyTLIpiCvS4tf8njTvdM0w+PcrqmlGrEfbl2s1hjjqmMhGD2m4E3h1tvNRkRPeORrvXGMmwzk1sU3DS2RO0fVGA1AnspP66nE0XCVnUgE8smWXfpyRsPIR3VDR25pIz6MZnYyyvEdGIQ3Br3+OQ1AxjDggS7UuLK25gj+on0b/npBXWNkLA2OCJxSYqYd/ZDgJIxsq7s263Q/LNAPSmaSrjuwDwDH5UwYJMnWKjUM4bJa8k/ns7qm3ID6C 0OJd/6+D P07f5eoZxUBhf7KtRUBvxsBfFzmilrt+JZylcWopnKbmerazSNtMWcswdp2e/ennmvoIHdEhfgPLuZXpxWZvLZTXs6QMm6EnakEmaehvVcFMBN/Mi+qHfMFHVnwMqyDc5dusV/qENcy84Ohak/I1EDBKcnvuYpl1wpIc4laj7kmkJTwhCcidkycdqabBUHDttG3BVAmHKtFClmp4QSL9ajY2ZBGOAkpXn7BmFuB9toFygPCIgL/JUSmqUkG9hVMWmduUTnX3LKj9RwXZ1uzRTwCBC1apqj8nRnzOzFqtPm7M7gQZ2yxUurojdOAKp5t55wMaPjTd+D3Pmn8gcHPNbQxPsc91KXYKuGKDroUIBkzV1xM/I7D9D9VH6m7y0Tf2XiLhzfYmUqMBg0E3pmmVLPZyq7Plsge5nynDv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2025-03-20 at 19:42 +0800, kernel test robot wrote: > Hi Rik, >=20 > kernel test robot noticed the following build errors: >=20 > [auto build test ERROR on akpm-mm/mm-everything] >=20 > url:=C2=A0=C2=A0=C2=A0 > https://github.com/intel-lab-lkp/linux/commits/Rik-van-Riel/mm-vmscan-bat= ch-TLB-flush-during-memory-reclaim/20250320-013150 > base:=C2=A0=C2=A0 > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git=C2=A0mm- > everything > patch link:=C2=A0=C2=A0=C2=A0 > https://lore.kernel.org/r/20250319132818.1003878b%40fangorn > patch subject: [PATCH] mm/vmscan: batch TLB flush during memory > reclaim > config: sh-randconfig-001-20250320 > (https://download.01.org/0day-ci/archive/20250320/202503201810.9JxSMo > 0Q-lkp@intel.com/config) > compiler: sh4-linux-gcc (GCC) 14.2.0 > reproduce (this is a W=3D1 build): > (https://download.01.org/0day-ci/archive/20250320/202503201810.9JxSMo > 0Q-lkp@intel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new > version of > the same patch/commit), kindly add following tags > > Reported-by: kernel test robot > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202503201810.9JxSMo0Q-lkp@intel.c= om/ >=20 > All errors (new ones prefixed by >>): >=20 > =C2=A0=C2=A0 mm/vmscan.c: In function 'shrink_folio_list': > > > mm/vmscan.c:1560:53: error: implicit declaration of function > > > 'folio_test_young'; did you mean 'folio_set_count'? [-Wimplicit- > > > function-declaration] > =C2=A0=C2=A0=C2=A0 1560 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (folio_mapped(folio) && > folio_test_young(folio))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > ^~~~~~~~~~~~~~~~ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > folio_set_count This is a fun one, because there appear to be several=C2=A0 instances of folio_test_young sprinkled through mm/*.c in the current mm tree. I guess some combination of config options and a previous change to the tree broke this? It looks like this failing compile is on sh, without CONFIG_64BIT, but with CONFIG_PAGE_IDLE_FLAG set. In that case, page_idle.h has an inline folio_test_young(). Does vmscan.c simply need to #include or should the code be using folio_test_clear_referenced() instead of folio_test_young() ? --=20 All Rights Reversed.