From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0261CC47422 for ; Mon, 29 Jan 2024 09:13:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7165C6B008A; Mon, 29 Jan 2024 04:13:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C64D6B008C; Mon, 29 Jan 2024 04:13:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B5336B0092; Mon, 29 Jan 2024 04:13:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CA2C6B008A for ; Mon, 29 Jan 2024 04:13:26 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 19F038053A for ; Mon, 29 Jan 2024 09:13:26 +0000 (UTC) X-FDA: 81731785212.07.3087116 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 818E0180002 for ; Mon, 29 Jan 2024 09:13:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706519604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fZ7rCX5G3ksjZCH/Q+Qzc5Ja0Bkdudk8nBmH2sGQCo=; b=tw5FYhqBfUIac5HKqdBixaFnLMl/uBA5t5s05OeBTKXfhzXcfDjWX6FcyXXGaYDO1geK2K SztxEjcv2t84VRhRgr6+KWtsht4umZZYSRAUOqhTtKrzOYmtRuXl9dnmHyESl0Ljg6FP54 8jhWpvta0C4T0pbQpUqAw/xBw7D951Q= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706519604; a=rsa-sha256; cv=none; b=jb3Gp4E3xHxOYbJoMhnMlKL3uF44/BmNQFXi7rgOZceUW8g7GBxcW3N0QJ/IeVq763ajXj FFqFVlk2ysNffMPmfQGpr696W6RfHd9YlAJd0unFNJxzFlweQoBYf4CBYSRbmru2JdtCFP 18BEtAoo+7c8c7GiE4qvNJH0hai7E1g= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 334BF1FB; Mon, 29 Jan 2024 01:14:07 -0800 (PST) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 091873F762; Mon, 29 Jan 2024 01:13:11 -0800 (PST) Message-ID: <8b5dfed3-f881-4f0a-be81-d7fcf3be0deb@arm.com> Date: Mon, 29 Jan 2024 14:43:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 05/35] mm: cma: Don't append newline when generating CMA area name Content-Language: en-US To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-6-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: <20240125164256.4147-6-alexandru.elisei@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 818E0180002 X-Stat-Signature: kz89rhbf5y8ur1i4k37x7tsrhzgbsn6b X-Rspam-User: X-HE-Tag: 1706519604-922182 X-HE-Meta: U2FsdGVkX1//rQOrjszedIZZbwr5mwrbwkASuQtzpHd3710qVBdih5UJnNxyIu4bzAga4nqHCKHzi2XwYMVi4QrBxPYh/f7da6a9d0oUsj/KnlBRmVE0viKdYWtz9ww2+z6+6Uv0KbdxN/LfFGbnEjzAxYa4404fzOXka3Ezn3guiJDhQjQJb/WTzIsGUe/hcaM9aFkygmHzFFPPOklFOBgYF6R/VHfZYFHNgfo/pzXfujp3vIo7umZ6IdB4R/33sWnlZlbwJjFJzKS+p+/Us/c+0QizggPC+O7G//UP6nhFQZ2cZ5yogSUCo1MbObpSSSMIL2uciuq/4qi7wwmN1X6pdWFwWGAfiD7BmnfuFBZXfJIpq9jmRzXn1N00N8DdkioyXaN9mrOXqavubWv1nV565Ow2G+zMSFnxm6QLlJg+lg6FPFmZo5BbA9S5zDEtwYG1UXC4NMQk3sWHsxkNZ9Cvgy1gB96a8IPv6LibFp0fwAmTRcMGF7BzafXyODCz12orRlYXMAoCYaqCSnWFCI4+9YeCTEn7mw0Qg9llBR4+k+cSz7fPAtZ7o3to+7U3HYuV/7qZQg6PB0Jt8JBPv4fmvusNOuI5xw6wSPJF+mEvbKtBfbfLxGUq1McFjPDi7s9mCNTRLWlytqJtMg7JYzMcD/Y0/x/QZwD/cALAz+p+Qoynw810kHAie6m0yR1b9VZTKZnArOsgqIg0HWFbk9xAx7CzmwZxb5zaCzHxxc1uWN2hNfgtRVj47qd2KbZ09M+4JClGAv76BHVYNesCY6yR7kr/6FAvEdGSJnu3kIsmTwRm1fVA07rgJmsiglI4VuzEkmqgLkCOqIHLS1+BzXvlOExFW2iP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/25/24 22:12, Alexandru Elisei wrote: > cma->name is displayed in several CMA messages. When the name is generated > by the CMA code, don't append a newline to avoid breaking the text across > two lines. An example of such mis-formatted CMA output from dmesg could be added here in the commit message to demonstrate the problem better. > > Signed-off-by: Alexandru Elisei > --- Regardless, LGTM. Reviewed-by: Anshuman Khandual > > Changes since rfc v2: > > * New patch. This is a fix, and can be merged independently of the other > patches. Right, need not be part of this series. Hence please send it separately to the MM list. > > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 7c09c47e530b..f49c95f8ee37 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -204,7 +204,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > if (name) > snprintf(cma->name, CMA_MAX_NAME, name); > else > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); > > cma->base_pfn = PFN_DOWN(base); > cma->count = size >> PAGE_SHIFT;