From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CC7C76196 for ; Mon, 10 Apr 2023 09:46:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 360F228000D; Mon, 10 Apr 2023 05:46:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 310AB280002; Mon, 10 Apr 2023 05:46:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D85228000D; Mon, 10 Apr 2023 05:46:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0DF3C280002 for ; Mon, 10 Apr 2023 05:46:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 98FFF1A0957 for ; Mon, 10 Apr 2023 09:46:56 +0000 (UTC) X-FDA: 80665002432.12.3BD35A3 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf09.hostedemail.com (Postfix) with ESMTP id D661A14000D for ; Mon, 10 Apr 2023 09:46:52 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="j/cmmPBH"; spf=pass (imf09.hostedemail.com: domain of ligang.bdlg@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=ligang.bdlg@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681120014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iXhZnKodLTUc/nB3/7RH8sJdp5VIQv7yGdDQoWkeAAo=; b=RQKtN9duzlXPm3Lgl8bOw+qSWuWLiQwBKF0pIMr3+rZZD57p/P92/S+dsUhT2Jtc2OzaGh VGXLRfj2PftPyx+Wf6DOef/xoq3ENTHIZncOQFuS02qsRSUNtJFqQ5uPGKy9XqvD2/XfHZ WH32GArmuBU6COcYCpyG/nA8ItGp2O4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="j/cmmPBH"; spf=pass (imf09.hostedemail.com: domain of ligang.bdlg@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=ligang.bdlg@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681120014; a=rsa-sha256; cv=none; b=BOj9zQeOwccZN5aldzQO1ZQyEaHIVnY0Hv9DuCeCDpptFSePJepx09PlXQ8vyNNeey1X8J rCb+56sH7WcO/QsYqhUcDhiWqzF0XU9skgVHbz0g4IVhaMMkuwj1f7AsOSTKHIYrh2l0e+ ZjY945lxXgOQBecECQ2lXkR5r8J147c= Received: by mail-pl1-f173.google.com with SMTP id ik20so4113965plb.3 for ; Mon, 10 Apr 2023 02:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1681120011; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iXhZnKodLTUc/nB3/7RH8sJdp5VIQv7yGdDQoWkeAAo=; b=j/cmmPBHNe1gay8QbALFy+tmMeVONQCUxgAH2i6+aOtIn7IyShW+wW3eERUHjhTZ2a yfi9+2WQNTVRIUG4wn7vydcfY6ePK5FSXWYV4xUveYzrGOOko4xZ9VucG9DW0Xs+X0h4 0dgyhtig8KaVgIpX2y67yFbzqxDXPH/0Q2Nzm4+e1xH8Na17Mji40B0Ox5aKAeDPLzwH MhEagoIHVGMGDHobwKByZSQnQlmse26h3CJQqDC/FFaC674PkQw1pNly/r+CMVlijcun YuTbpMhUvcNdaRzYXYH58aCb4ve/HmgpFDnwEl1YiBOpnCPyQCuHspwZLKx88mGbIUzg OE9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681120011; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iXhZnKodLTUc/nB3/7RH8sJdp5VIQv7yGdDQoWkeAAo=; b=EnSt+sEILut1yyCNnb8QSqsFqvzrgmxMiTbrTO5O+EYm3SYkCYIN1MixfZkjwVEeGc HP5l0dgZOb9fxc9ymlbK8yEfsDj+1JtjoxUJ+UnZ6v9wAYGxBf1uLg6gGBRPDhK3KpVK DNmxnq9wQFb9s0Vv2NDiv+tplTtFB+ZBwBpmwk47y7C6pIGbh3Wpz+MPmsQR99zsaxWt 1NKaYW0xMCQXY12Li4lNEmfuIdd7N8qPNnki3cFh2NMCJ6HyU+jtJ2I0Y1N5wsdNsAIK ZSvCULIj8Tr5yrEYZZKtqpKwad4WB47+DQg9/fleOzu1gYs9fl8UdnrLMmrrDIEfRdHz DIEQ== X-Gm-Message-State: AAQBX9f3U0AXBx6yKUVUBjOxVXjCBQzCf5vPY5IQUf1jTjU2Sl1UDaaT j0BAArBFtTsRlmL58e9hChdc+w== X-Google-Smtp-Source: AKy350Y8zzmAIGxu/G3CFKW3fTvY5ItJNi92RKW8sJGkQ4BmZWPgyZ5eY54N4Pk4XPYMPowRfYigNw== X-Received: by 2002:a05:6a20:ba90:b0:db:9726:8e46 with SMTP id fb16-20020a056a20ba9000b000db97268e46mr6532199pzb.54.1681120011450; Mon, 10 Apr 2023 02:46:51 -0700 (PDT) Received: from [10.2.117.253] ([61.213.176.9]) by smtp.gmail.com with ESMTPSA id n188-20020a6340c5000000b0050bc03741ffsm6693968pga.84.2023.04.10.02.46.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 02:46:51 -0700 (PDT) Message-ID: <8b5af22d-1612-a2a0-02da-728f1fd57bf1@bytedance.com> Date: Mon, 10 Apr 2023 17:46:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] maple_tree: Use correct variable type in sizeof Content-Language: en-US To: Peng Zhang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman References: <20230410091431.74961-1-zhangpeng.00@bytedance.com> From: Gang Li In-Reply-To: <20230410091431.74961-1-zhangpeng.00@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D661A14000D X-Rspam-User: X-Stat-Signature: bfrfqob8p8g7ax7cmcgzge83ocxu7oyc X-HE-Tag: 1681120012-861039 X-HE-Meta: U2FsdGVkX1/B7csc+21s1wmp8/q5OVC/e1YOQinyOxhukeC7VHopFxNg+rF6whdwf3UWB8My4uwT6B3KuYOCi9tLrBcvakECMuVBNH9jBNHVFbhh31Dye3WqY4megE7g1Grb0pTr80r8UvA1LdzDc8zCkHVGg/PUxaehqjQ8haoUjitGQPXD9yss2dvy9GY7+vbHgcWS7+p6WspJmVxfEiQ0EuDR/E13gTvLgK/RCGog1og2dT2vMe1Ll2D/JHA6WnzmJ1HPSMqiAmfWnFOwpOBRYXpbkWlONBVws52CCabVgaiWJaYln3neOrClzs9bZf/NJWkUQf+I2NGs2w+X57WwISprFC74e4cqP33gavJCx2l/nnC0/9OKwrSCEps9Awxw3rJm1GdA1vWA+yQ3c+mo4Ad4ndlInyFgHAtKHAyE75Mrt68a6S0LKKhT7oZwXxppDEL3VkwZ4fHAAsb58iGJP1vbDDUCHWqnT6Z3q/PCozVf8AVQNeExK3mOlRW2eH4XtGru6UVUMAm5GeFeBNBuZFBsvGbAoTAwhvTl4sa61GAWDX1i3dClhl7vQF/5ARr+rEP2cmG1KMK8OL52h/pWVZ0pSrVyyGBOGA2u7VwEjRHpTK+IFtmk9tX5h6FVnuq9biTuCY8Giwxs3fin4wKXxxuaZemi5XJo+WCEGu8u0YFHfdGQJUW1ql71emTSPLyeQOgfIlQ5TzNqG0uzvvv7wKbaf7fNcfeY0RjEhAg3vUz+0vIO2BYzOsGbaC4rKN0kyOOfY5mUE9wUtJa5UK0VgZQNtGR2Rxv2qbCRFP2+YheHz1KYsUoKL+oJT0W9VtJNGYg0Hm+Duqn5fkL7Lpo5GMKPwB9ypQxT/aWdTI32WfJOoJc3yr0xx9ilAf8wlp7IeLjMsYn1hB3kUCQPPH2zmNGfC6EtsxervNa1mwvF5o8jBrSHc9xd9tVDNe0WG/bHUz0HciS8EVzXRR7 v9b1OGLg ygzajwNSL9TRrestmzGJizcjsT2hb9L3fBqoisKzlqm2D7Ws1UuPd9WhVN+2w6zWkk+LGK7hIVb3tRA4hdMK5mN9Lq5NDUYRkMEIGzHm+GFu5kfchqRzen3+cg6icyH52gQ0RDaCI1nXJQGNF2nOYf6GnYV3AlKN5cz3SmBkRkF3MLsW49/Py0PyUWao3F+OYwyTIxHbwHaBtx/OX2s+A3zyj6xrMnTJw50z06LqIwohbVrkov4H74xVKFpe8diJbU5TpRHrPfTeJF0p8UOdvp8GwBj190QIoM5MVbK5kgMQcmAZazzkOekK1HEzZtQ9okbnb1ZNiVQmC4t1qhf+ovDcv/JgrFlTIMjcXGIlxd4nAmBWWhcT4rV8bVR+H/6EXfDk0jDQGwb+SKsC5tpbAGbb9Gv7Q8mTMhHlHeY/5+Dkx3sWibURPs5IgB1N5WzGCTGCQ/NGvwnRPJbS+xV+jhTpjq7Yn27ioEG0Xbj6ZMXAfft36KNZ4E6hVdritFS/Sw1j0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/4/10 17:14, Peng Zhang wrote: > The original code is: > memset(pivs + tmp, 0, sizeof(unsigned long *) * (max_p - tmp)); > > The type of variable pointed to by pivs is unsigned long, but the type > used in sizeof is a pointer type. Change it to unsigned long. > Maybe add a fix tag? Fixes: 54a611b60590 ("Maple Tree: add new data structure") > Suggested-by: David Binderman > Signed-off-by: Peng Zhang > --- > lib/maple_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 88c44f6d6cee..b06fc5f19b31 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -3255,7 +3255,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end > > if (tmp < max_p) > memset(pivs + tmp, 0, > - sizeof(unsigned long *) * (max_p - tmp)); > + sizeof(unsigned long) * (max_p - tmp)); > > if (tmp < mt_slots[mt]) > memset(slots + tmp, 0, sizeof(void *) * (max_s - tmp));