From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493B7D767F2 for ; Thu, 31 Oct 2024 17:43:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B78A36B0083; Thu, 31 Oct 2024 13:43:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B28F76B0085; Thu, 31 Oct 2024 13:43:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EFE16B0088; Thu, 31 Oct 2024 13:43:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 825F56B0083 for ; Thu, 31 Oct 2024 13:43:56 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2837A1418BF for ; Thu, 31 Oct 2024 17:43:56 +0000 (UTC) X-FDA: 82734619338.27.F542C00 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf09.hostedemail.com (Postfix) with ESMTP id 3812E140006 for ; Thu, 31 Oct 2024 17:43:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=sxUDccFP; dmarc=none; spf=pass (imf09.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.51 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730396553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cJN1S3OA8zjlhqH9iA1Z8bsg9GoFf4IOEEdKUROgci0=; b=bM/StWz7LKV7Z/WHJwekN25YhGFHv4OqZ7ijwosu+VLwsRYJC0WwPJQW5vYfPvL9AHpUuq Sg/YLP+45dWUk/0j59dZtUL2exYocZHUigHrIPwZ8UQr8RBD02QkyYff00MyoeEg7OJ6vD +EiJUFlA+U3hNthnNdtyvrjp6a92HdQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=sxUDccFP; dmarc=none; spf=pass (imf09.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.51 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730396553; a=rsa-sha256; cv=none; b=gBPzQTOFZQqIam9BsUdoCw86gqCUEMTI1l9NPefh7ZiwN8C/sTrMujR3NVSATUWIge3BQ7 l6KTvnXngqjJpdWuK6tvqEIhoObXyo1BXdcG1VuH/qyfeBqUDoVzNMVTLvujRnXaCiCl2c Q23o7laC4OfAlxHxtcOcEiZ3bAIF/j4= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-83abdaf8a26so48030839f.1 for ; Thu, 31 Oct 2024 10:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1730396633; x=1731001433; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cJN1S3OA8zjlhqH9iA1Z8bsg9GoFf4IOEEdKUROgci0=; b=sxUDccFP+BjQ097HkUhkc3pzZXADSrvR0xZzvEvL+19K0W5YcvZSrsXDxBZbAjP4LA 5VqFZvxfQnMH45erfDuxcDqhqG9QBwCqwls+uSryKx5IRQBne/OoiZqqH4KyTDHo8Ad6 nmfcDZLmj9DmR4uoJ33TzDsDfAeuoW1FIhtgSnMQ9O8sCcfboeK80Ttpt+UVnk2nPVSt EHaZJIneQMv4v4MMDgSq3D/AcSf2Yj7TCmPtuk4Rb7ugvjAD7PY1jUlPIJORkyZVcR72 l4RK0pctxbxikuNEbI+5CAqEbWZXkHWtaaae1tICbeZCBRiC7hwNtcL1BUjJ5GT9l66h +xrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730396633; x=1731001433; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cJN1S3OA8zjlhqH9iA1Z8bsg9GoFf4IOEEdKUROgci0=; b=bqUgSSekX07G3kjTOHVml5Lmu7Z9m1Wlp9gDrSUZxDHmtaLULtkqPS7XXpCiU4fjYE OtekyR+jIDH1YOChG3FIZBTaqQooGF2uNYNgjJeAFOPXIZ5qQIU2itExM2OA8GgAAkFR sODIC9rOMnVXpGLpTDMGxfOAW/XCfx6+CapgUCMTULrzxI/rt+Y0w7erhu9Q0O0b+Mbq 8wpQYUsF9dIDMIVuvxTzg4pGtoGIvWaYqZxwJpqsefMdykEWnm5GTe4nQmML0VmV0nkd tyU1n43R34As/l2EFFtoU9YCLD6xN8X9KQbGJMlLDCG61KIgIwLALUAVO3JWfypK5qwo Jz5A== X-Forwarded-Encrypted: i=1; AJvYcCWHdBzTSW/TozttxEiD9y4IbnUp+puKpt6docyLhug6ZZHfD3rUieReAeX5w6sBL08oQkbgTTEuSw==@kvack.org X-Gm-Message-State: AOJu0YwMR50ywgqBEPw0JC/l70ExhnOZk4zSHCUEjUEjGZ51xz1dhx5p xC7zridF1Fqc8qvN1kz4RbIe9O5QFsLc15uHyhPR1lItRHb0YwBBLr0VxXGUOmU= X-Google-Smtp-Source: AGHT+IGqvDPac4jMToI9PP3ppL4bi2ob+amIyOKddZ0fGQ56qF7607m8ktK4Ur1sfUjByGfZ1fMmYA== X-Received: by 2002:a05:6602:6d0b:b0:83a:a9e9:6dc9 with SMTP id ca18e2360f4ac-83b1c4c27eemr2156317139f.12.1730396633080; Thu, 31 Oct 2024 10:43:53 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4de048e3736sm379375173.81.2024.10.31.10.43.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 10:43:52 -0700 (PDT) Message-ID: <8b4500da-4ed8-4cd2-ba3b-0c2d0b5b4551@kernel.dk> Date: Thu, 31 Oct 2024 11:43:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 00/17] Provide a new two step DMA mapping API To: Leon Romanovsky , Christoph Hellwig Cc: Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <3144b6e7-5c80-46d2-8ddc-a71af3c23072@kernel.dk> <20241031083450.GA30625@lst.de> <20241031090530.GC7473@unreal> <20241031092113.GA1791@lst.de> <20241031093746.GA88858@unreal> Content-Language: en-US From: Jens Axboe In-Reply-To: <20241031093746.GA88858@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3812E140006 X-Stat-Signature: gn4anp79rmd4oknem1toxyhu795bg165 X-HE-Tag: 1730396615-115280 X-HE-Meta: U2FsdGVkX1//eV734n9gjyXfQSyqda0qQYinKZca136TRMw1HhipUqu6EmTgyXacLCT9+gJEQsqGGXfLgBEWXMYnjvjhMEQlONjG6lZ2NadYIz49n10zBaA13w3fsjZF/whDuo/xQIVmQwz3U31Fg54GM1d2XQbyv/x73RkZKhxA7hJVfmZpnKFQU/nG/x37IR5dL0QgybnkelI3ubEV+a8th4RnqLOhIxNYtaiJMVULTQLP5fK++fRT3BdTdNBJj6lekeQ1/AMAuPBJ+80qwSqCNoIXiVGIkF7cQ1NuKfHnRODTmb6ER/l9qIYZMWufZqtsUSWaL5/fxPMEQK4f9ND+ivd5y+Rc/DUJ05CI1GtBHx9plQqPa6CWAgb9LhCDoK5rVRLGgw60IOhSq01CmO/YXlVate+V2Upqb7yUlyha6sGojOH9eFoyrPUcN1DGnegX6IwxEPPJ8HOz/Vy/G0CvikfEJ3Ueh4V2x2xHJU9WRebLUI035og1CXAJyoE4VOxOuLTtom9Lx6wK/j/6tECQHbosQYkUO16c5AHYnMWkv3SSi8Yhe1k7ZI3m1OfjSHqlAp48/z7lK7ueqh3/g963JpGCNRiulbfd8Csrvoxk+YWBSeKxhj2CjIkRLRyRmOJg5Xvwk6NPVM8ZoW2dN2yeIapgek8T92HcCVXFOHnB/SH+hJgVISSnItHMrGBHFkW4lnWQQk5i2JVpWU5WBhKN0NWzKsJMjKxHl8wVkUzDtAdq9VA+32vTQ6teoQ282HxAqB6jLqQv/e4DvMESljzC/BikTax1aEM+ozCkOdYRzEPC0uya2xnghxxn7jDQcscvedGhpdgXgYDQqPMJD9cVUjp1qYEsjn9047bGtC4d2burHGYU+sQV2jus4uwTGT8N2lYW3vrXAefk5GdyeCTIeFOR75KP8P1enjhBzTZtW5L/4WJWOUivTQPfZA7fgOGFSKbS878Y9NhDYyF 88GGKIyJ eGE9rroadtFzgJ50PYw7hQZwGrm1qlE42A6NExV7CXe7qnRbD2cFeUN1U5qza/SYbEgK2xCsKu8fzoKr31vSSRkffDAhaL/dejrBq89i5ofqpZUvFHBHpBs7ym/wWjBM7cwVsdY5Bl1cDzE6QRATlbYuchMtbt+MdlfAcv5oseuo8PSOSgmjk5atLD+56S8YGcVU8Mhhe5jkIjBvcxtNm0YYLQgaDjS/vcbESrF83mIv2tC2duPDjWLc99zLLkgY0BoYsPui+9QCgqX/pxChPfdJow1gvdCHG1yV/R+4iSgYunOtq9JtgqjLsJ7MPX5ca+H7QgnMEP8vU5kBO+MAvLpe5J2iESKTw3bl8LTy0YVuUHeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/31/24 3:37 AM, Leon Romanovsky wrote: > On Thu, Oct 31, 2024 at 10:21:13AM +0100, Christoph Hellwig wrote: >> On Thu, Oct 31, 2024 at 11:05:30AM +0200, Leon Romanovsky wrote: >>> This series is a subset of the series you tested and doesn't include the >>> block layer changes which most likely were the cause of the performance >>> regression. >>> >>> This is why I separated the block layer changes from the rest of the series >>> and marked them as RFC. >>> >>> The current patch set is viable for HMM and VFIO. Can you please retest >>> only this series and leave the block layer changes for later till Christoph >>> finds the answer for the performance regression? >> >> As the subset doesn't touch block code or code called by block I don't >> think we need Jens to benchmark it, unless he really wants to. > > He wrote this sentence in his email, while responding on subset which > doesn't change anything in block layer: "just want to make sure > something like this doesn't get merged until that is both fully > understood and sorted out." > > This series works like a charm for RDMA (HMM) and VFIO. I don't care about rdma/vfio, nor do I test it, so you guys can do whatever you want there, as long as it doesn't regress the iommu side. The block series is separate, so we'll deal with that when we get there. I don't know why you CC'ed linux-block on the series. -- Jens Axboe