From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3988C433EF for ; Sat, 11 Jun 2022 03:15:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF2F18D00FE; Fri, 10 Jun 2022 23:15:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7BCF8D00F7; Fri, 10 Jun 2022 23:15:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF4FA8D00FE; Fri, 10 Jun 2022 23:15:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A898C8D00F7 for ; Fri, 10 Jun 2022 23:15:01 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6EB31218DD for ; Sat, 11 Jun 2022 03:15:01 +0000 (UTC) X-FDA: 79564488402.12.076964F Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 104491C0081 for ; Sat, 11 Jun 2022 03:15:00 +0000 (UTC) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-e93bbb54f9so1531242fac.12 for ; Fri, 10 Jun 2022 20:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=i3PveqzxOSfMeIA5E7qSY6I1PBV29u2B7LHH4YJatsw=; b=NdJmIjo/fkkrwGS2vSrcmgt+wPfap+5wiAUAo47bVRkzsY2soRkocWOl1U4OdC4QvW 1+o3AzwgNPGHEVve1PXadpMxGAKqW9xnVck+n7EI1wrWaDoYUHaXf08dO1/feGuAIQYm Q6INuuIejIksWcprtyxG1n2jxlVy/L7l0iShsXdgoyv7Ra/xMHKpZkV8lVnnGiYqwMb5 vAm/b61+kDNuiDTODbHQ7qgZ2CZ3JL3eeQvTDFeiTc1/Z5MDbRNYVL1yjGq+tE4E1HT/ lR7nzwjrCJHUKlJ3l6mtdgYk0bK0XGa9DHrdd6UKolK2dqyPQep1hMU3BsAIylqcC7ER 8nqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=i3PveqzxOSfMeIA5E7qSY6I1PBV29u2B7LHH4YJatsw=; b=EAsTidwokhC52MNM4QsJGKmI5i84MaeTf+w5I0VRPniq/yyqNVxl5Aum4rvqIu0jTK 21GMsu7T8Gtj6TRdUgVdb0r1fX8oKjwOzfaS66zksWRuJRpzYYDFOPjYs5rwpyMEwjDc oHonxYeQrRQ0wghhOT4nNNGGUSAv+8U610KEuM2IpHuyLBjw8WAEyAOOPrQZYtYYvbW2 7NjwKXrhgHmGwS2dZFvNQmgGFq+MZgP/kRKso2ncQT0emuEzM4tMQLGdyWDW1T6ADVDh b1OdVC5JFP/EsblvYPWQ3n+sXdgGj2dTJskve7uMacenr6DlUIkfLNiEUhJ//y/D9DSF DepQ== X-Gm-Message-State: AOAM531/fJvwevbzOmhKf/MDoZnwAm5+j4Ed1qGJCBOZx4X5wzqbRgcc 5h5j8+URWZQdeuC+K5vSM9ZKbA== X-Google-Smtp-Source: ABdhPJwlicWpC0b0+htVy1SbYiuX+t5H3/KQGj98sGWA/Sr0QJvC4IsBypGanwOYgphFBqTOU3gLzQ== X-Received: by 2002:a05:6870:638d:b0:f5:d6c9:3f45 with SMTP id t13-20020a056870638d00b000f5d6c93f45mr1563800oap.233.1654917300112; Fri, 10 Jun 2022 20:15:00 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id be8-20020a056808218800b0032ed4543c36sm570080oib.36.2022.06.10.20.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 20:14:59 -0700 (PDT) Date: Fri, 10 Jun 2022 20:14:46 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Miaohe Lin cc: akpm@linux-foundation.org, hughd@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled() In-Reply-To: <20220611022314.21593-1-linmiaohe@huawei.com> Message-ID: <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com> References: <20220611022314.21593-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654917301; a=rsa-sha256; cv=none; b=fOl9mQ7M+J8pCzBtU6S3THLgD+R5klS3h2Favgk5kGPN4MPEbgJQF0h8z29FzkjFsh4oM5 UNQ7fLYQJw5YdEpZIweDzLoGG4KcYEITJoEYoUjHb2yf60In6Ls6dQi+d8Owr0BCpH4VtU O8wLeFcFGMO5LvLZpLqcbD1efTeroZE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="NdJmIjo/"; spf=pass (imf21.hostedemail.com: domain of hughd@google.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654917301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i3PveqzxOSfMeIA5E7qSY6I1PBV29u2B7LHH4YJatsw=; b=3XPou4wBYdK7+K9Nkbd897SEgO3f8p2g3cGEajGQ4o2zq5c1ONxwIAhQCtyTugYTX2f6fa 9pzSmYrXjvDQIsBLhWxcKdenCJ72+uZqKlWsYW2AYDuIL3Ut/JmkD39eZaO280AJpIbGSA pMOyid1h+DatmBNRhoCXPVlRAeeDYCk= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 104491C0081 X-Stat-Signature: ejuizre6k5ghsp3b6iswx7ytk6sdmb8r X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="NdJmIjo/"; spf=pass (imf21.hostedemail.com: domain of hughd@google.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1654917300-306635 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 11 Jun 2022, Miaohe Lin wrote: > Use helper transhuge_vma_enabled() to check whether transhuge is enable > on vma. Minor readability improvement. > > Signed-off-by: Miaohe Lin No thanks, that's a readability regression, forcing reader to go and look up what transhuge_vma_enabled() actually means. What you call a helper, I call an obfuscator - as I implied in b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()") Hugh > --- > mm/shmem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 133c67057d41..59cc2e980c95 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -480,8 +480,7 @@ bool shmem_is_huge(struct vm_area_struct *vma, > return false; > if (shmem_huge == SHMEM_HUGE_DENY) > return false; > - if (vma && ((vma->vm_flags & VM_NOHUGEPAGE) || > - test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags))) > + if (vma && !transhuge_vma_enabled(vma, vma->vm_flags)) > return false; > if (shmem_huge == SHMEM_HUGE_FORCE) > return true; > -- > 2.23.0