From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA5FC6FA99 for ; Sun, 12 Mar 2023 16:14:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E4478E0002; Sun, 12 Mar 2023 12:14:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 394C88E0001; Sun, 12 Mar 2023 12:14:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A96E8E0002; Sun, 12 Mar 2023 12:14:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1C8D78E0001 for ; Sun, 12 Mar 2023 12:14:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D7C9E40A56 for ; Sun, 12 Mar 2023 16:14:30 +0000 (UTC) X-FDA: 80560743900.17.AB70AC9 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf27.hostedemail.com (Postfix) with ESMTP id E5D6340014 for ; Sun, 12 Mar 2023 16:14:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of alex@ghiti.fr has no SPF policy when checking 217.70.183.197) smtp.mailfrom=alex@ghiti.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678637668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vx9TZnmzhw2bbJrzNDswdM8xfDOEAMeKHl8uVm06fQ=; b=VAn9oVHPxj5/qdmsZ0Ix4ukpZx+TKJd1FyfrHbOE9+UmMeEYHpfoa232H0iRJkSpZm440y XexFjdeUr4rznD+VDFD1GIganwqIvgQ2A+ZYswgBg/F0Hiag+eEw02k9MpxnU6m2G6e0b2 A+zbhbRf/JK3kS40Fk3PmlnCRIWoCWU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of alex@ghiti.fr has no SPF policy when checking 217.70.183.197) smtp.mailfrom=alex@ghiti.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678637668; a=rsa-sha256; cv=none; b=Djuvz9mVR4HER/HArov1KUzEk/EcUyzoJW5tiIHRp0Hc+3aU8k3nSZMvRN/zBCungbuQAr jV5viv3rAbSDklskvk8+Yt87C1IuiZNW1alZkQndtG4AJwYFCa2qyrzNa7dp/Ux3Ke74hW yFbiybdoeURFUwksu5FncRBlLAVJpQw= Received: (Authenticated sender: alex@ghiti.fr) by mail.gandi.net (Postfix) with ESMTPSA id EC8CA1C0002; Sun, 12 Mar 2023 16:14:20 +0000 (UTC) Message-ID: <8b338d50-d790-a2e9-9ba9-fde444309bfc@ghiti.fr> Date: Sun, 12 Mar 2023 17:14:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v7 2/4] mm: Introduce memblock_isolate_memory Content-Language: en-US To: Mike Rapoport , Alexandre Ghiti Cc: Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Frank Rowand , Andrew Morton , Anup Patel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-mm@kvack.org References: <20230310094539.764357-1-alexghiti@rivosinc.com> <20230310094539.764357-3-alexghiti@rivosinc.com> From: Alexandre Ghiti In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E5D6340014 X-Stat-Signature: semqz3t3j8cw9injo4e8xtstz1ttmew5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678637667-255489 X-HE-Meta: U2FsdGVkX18JzQqwhXHmpPAiEU5U8MAIOYkT5AhaHKfkqLk2HuiNlcfLKgzTOXK5+yBTxjOqA4YHuCZgTdfcTjWtKu1k2XiLMtjOvQrguamGpwMayJKmg1ndkyZSxShgSI7DWJ2vh2WtmDffGYcSAZoFFF1msJdpq9aSHbqzdRRA7ExcrUxzoOvrlDGuPZEhOu3lYNrtD/+XT7jZPz2ma20o/Pvfnj8XJTZ8PZpwBajTH5xbotXCzoAKweffKgm8D/JYwCobtnX4WmGvkAcCFPVhddIvHc2TWAsFAkg71yioqxIFv+wz+6U+h743z5lOao3DGxYGOHsY0ifQJmRm06P4tZUAewFjMi12Roi2jmJ6FX0wJKPZ9a3FQg18SM8TSssAkws7YXn+OzAagEb3tsyLEWBGsfw5jH7ifovtqGmVfvAKSPCN4/0uetouy44h01gDGEFsjjX+4RiMXWEvWUMGyjrY5yCOapqsjfR4Hm1sgGGNCDotHk05FNX4H6rEMqcmQYdEoxdLDcowWiy3plFJSOfQ3LTDNlFQ9JxbkNA7CHN4zN84e9sQbB6F+BN+nsFUS0J+CyVjVi5USxzO93jUQa2wqNgzI8rgE9GgmBdrFEqvzsZuIY5Ru9Ct3Zqv2PjG8z2Fihk5ToBsKIDk2+d6R1uttRE1VnkkViNfJIC8JlD4ysBQUjKHvsjdS7LrlHXbvpSfUaZILdwhep1AtRMrqfaoNlzWwf3/2pQSpMQ6GSLSD7AmUG4EAQYpzifDjqSu2/xPJjMwkgMiOQP2m/RTkTK99+Su1+htgB+FUvfcoNy5dwiEsKreR80clRvUuwAdc21WBDUhKxsMsY+Dpd5YQ4rNOIbGwHB/mvjysf2eI3sJ/TkiXsM2KVdz9lP5D8Kb3A9gDSecePjej0IkpOLkeU/G9LFFF628nCK5YhlOP12IerJkvkSYmhnV07kA/xYVu1ffx6wAV3JogdU KIJq5QZ/ Ucvr0XJ2/keayfojTZxC812w+4820weGuBki8X3AzdMmE+QSux5qs3nXYJ5CRI7PZ/t42/QxsjyfvmppghWT9tzyrYzeAz0AqmAzBU+haUcwYzBXQ20j3T0Bhw8ZPU1MP70s3LXlevEp16Unzs6atAv72UqQOMi7PHsWVqZfa224GNTcKBaB6ZmPicQh4Tn7X07cMeo9f+Z8wnJywiJkx8dCO/0WZy0prKAFP5d2VCLWaDsWJ16MFyi9g2vKAtmtEMDyH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/12/23 10:35, Mike Rapoport wrote: > Hi Alexandre, > > On Fri, Mar 10, 2023 at 10:45:37AM +0100, Alexandre Ghiti wrote: >> This function allows to split a region in memblock.memory and will be >> useful when setting up the linear mapping with STRICT_KERNEL_RWX: it >> allows to isolate the kernel text/rodata and then avoid to map those >> regions with a PUD/P4D/PGD. >> >> Signed-off-by: Alexandre Ghiti >> --- >> include/linux/memblock.h | 1 + >> mm/memblock.c | 22 +++++++++++++++++++++- >> 2 files changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> index 50ad19662a32..2f7ef97c0da7 100644 >> --- a/include/linux/memblock.h >> +++ b/include/linux/memblock.h >> @@ -125,6 +125,7 @@ int memblock_clear_hotplug(phys_addr_t base, phys_addr_t size); >> int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); >> int memblock_mark_nomap(phys_addr_t base, phys_addr_t size); >> int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); >> +int memblock_isolate_memory(phys_addr_t base, phys_addr_t size); >> >> void memblock_free_all(void); >> void memblock_free(void *ptr, size_t size); >> diff --git a/mm/memblock.c b/mm/memblock.c >> index 25fd0626a9e7..d8cf1c9eccf0 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -753,7 +753,8 @@ static int __init_memblock memblock_isolate_range(struct memblock_type *type, >> int idx; >> struct memblock_region *rgn; >> >> - *start_rgn = *end_rgn = 0; >> + if (start_rgn && end_rgn) >> + *start_rgn = *end_rgn = 0; > Generally, it's possible that either start_rgn or end_rgn will be a valid > pointer and this should be handled here and below. > > My preference, though would be to leave memblock_isolate_range() as is and > have unused start_rgn and end_rgn in memblock_isolate_memory(). Sure, I'll do that then. > >> >> if (!size) >> return 0; >> @@ -795,6 +796,9 @@ static int __init_memblock memblock_isolate_range(struct memblock_type *type, >> memblock_get_region_node(rgn), >> rgn->flags); >> } else { >> + if (!end_rgn || !start_rgn) >> + continue; >> + >> /* @rgn is fully contained, record it */ >> if (!*end_rgn) >> *start_rgn = idx; >> @@ -805,6 +809,22 @@ static int __init_memblock memblock_isolate_range(struct memblock_type *type, >> return 0; >> } >> >> +/** >> + * memblock_isolate_memory - isolate given range from memblock.memory > I think it'd better to use "... range in memblock.memory" Ok > >> + * @base: base of range to isolate >> + * @size: size of range to isolate >> + * >> + * Call memblock_isolate_range on memblock.memory to isolate the given range. > Please elaborate that isolate means that the range does not share regions > with other ranges. Sure, thanks, I'll come up with a v8 tomorrow along with other fixes (rv32 and arm64 comments that I forgot to remove). Thanks again, Alex >> + * >> + * Return: >> + * 0 on success, -errno on failure. >> + */ >> + >> +int __init_memblock memblock_isolate_memory(phys_addr_t base, phys_addr_t size) >> +{ >> + return memblock_isolate_range(&memblock.memory, base, size, NULL, NULL); >> +} >> + >> static int __init_memblock memblock_remove_range(struct memblock_type *type, >> phys_addr_t base, phys_addr_t size) >> { >> -- >> 2.37.2 >>