From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE3CC46467 for ; Mon, 16 Jan 2023 11:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FAA86B0072; Mon, 16 Jan 2023 06:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA8A6B0073; Mon, 16 Jan 2023 06:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299DA6B0074; Mon, 16 Jan 2023 06:38:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1BEDC6B0072 for ; Mon, 16 Jan 2023 06:38:00 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ECECCA0752 for ; Mon, 16 Jan 2023 11:37:59 +0000 (UTC) X-FDA: 80360463078.27.2DCDAD3 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf25.hostedemail.com (Postfix) with ESMTP id 95546A0004 for ; Mon, 16 Jan 2023 11:37:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673869078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WfL4x+ToPo1HU6DwcCeAgVvCndSHDlLTLG58dNcss40=; b=Sk6HOSZ7E3Pj0HMU+wg8arjGhXxY0S0LfwpG514CYpjndY1zOG/VsZJqzVEdW5djD3nyYL EA/QJmcAUASiTCueneuq7/DwDnEin1wBSy+HZ7ChEkKvTPwRmfR3cFfPXGRe/kxs6vw8Qz NNU3GTKGko/YHwJ79oTsCGy9V2fyu2U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673869078; a=rsa-sha256; cv=none; b=TjzlMK2Vd4BDi5ouE+6FJZ5gJTSeENsOHX53O9NeiynpnnGwIqrBxL0hTUKa7FrTC/7EqJ sHMs54D7TcE1319uOcV8p6XnkhL1a/Z1NTVJXGd8cjX6nDt9X40rVOasbZptp5ywLzZohj ty+00JfT/vSt1Z7ykczLX0b8qmfy5gY= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NwTnQ6npQz16N8W; Mon, 16 Jan 2023 19:09:46 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 16 Jan 2023 19:11:28 +0800 Message-ID: <8b26ceaa-79b4-4c3e-c37a-e191b3403358@huawei.com> Date: Mon, 16 Jan 2023 19:11:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next 2/7] mm: memory: convert do_anonymous_page() to use a folio Content-Language: en-US To: Matthew Wilcox CC: , , References: <20230112083006.163393-1-wangkefeng.wang@huawei.com> <20230112083006.163393-3-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: zwz1dusy8ywcqpqwsdchhrxgogiu5txd X-Rspamd-Queue-Id: 95546A0004 X-HE-Tag: 1673869077-307588 X-HE-Meta: U2FsdGVkX1+RloXfp8NBHEUpH1dl8lC+6LhqEuVrcJW+pPrp8gbQtm/NVurLaNtrtNLIYbO+E23yjA+PqJv0stdA1jc6yLnGEAJueI5y5Y7EhNR2V+oQ8XdatpwUL3ViQxPrdQb6GdH60FtQ3GQIOhtwFPSC5Rm/JetQqRvQ/xVw7xKI/WMCVrgSdBhQ7cIGzAtSQvHx4dfsLrcA4JcL5LdT+U7cUMI1P2oOq0nOHxZ8NkJeJ4od9PQ39enm+tEP0Tp9PsCz7BnsUkXM87hPXXtTblhvHmY1xYOMVNLYUvmN7jSKP9TJXuCoOL042qU36SshXfEWr6Ttu6xwllWME+HxQ/qhmYHuAw7WhnhytEaaUFYGdT7QIRyz0u3lOuTRk2bmuBqP8vsBfU7wcJtw490oragKCaAVbIO6JbZi2LmNpBU3M5NVRK7oJqS8CBt9AgUStkUMAE+yhT9CbuWiIquucX1buD4BCiRGVlBTSc1PwvBaupY+ArzTgo/O7ZWDXyIH85u4JdE0hrWVTmv+fEqm+Jl2Ndr7j+aTnmqdn29DBRoNsnYiGBGdn0E4ChoDCdWic0X/JLvNJ26SrHjAvvs5AVx+dLgKUjEey2MNzCcBoOjxBtdAkHD/BpqTrvlJVqeUzZ25KpEF8tlEfZmU6H2tU1L10lhhJsuaZsmr/uolHmx2fj3CbQ9tw2+N0Qtj0rLxqnl96Y6totRRSeMNhsKO9sxCCgCAvr62dznB93XgDP/2+IKLJTnBP5O+tVRuCTXNv8OIB/CO5ih8hrW0X94Ky3dbNu2OD30+d3N6O+1OWe02jBrTCsb0ZzTE9fRJ8m3xSiP133d4zfML2L03M7LLgmykmzImtYXANN5DTgBa9dFb8Y6uqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/1/13 23:33, Matthew Wilcox wrote: > On Thu, Jan 12, 2023 at 04:30:01PM +0800, Kefeng Wang wrote: >> Convert do_anonymous_page() to use a folio and replace related functions >> to folio functions. > > I think this patch has a prerequisite of sorting out > alloc_zeroed_user_highpage_movable(). That way we can get rid of > the 'page' variable inside this function altogether. How about provide a wrapper like folio_alloc_zeroed_user_highmem_movable(), but the is a little bit long. static inline struct folio * folio_alloc_zeroed_user_highmem_movable(struct vm_area_struct *vma, unsigned long vaddr) { struct folio *folio = NULL; struct page *page; page = alloc_zeroed_user_highpage_movable(vma, vaddr); if (page) folio = page_folio(page); return folio; } > >> inc_mm_counter(vma->vm_mm, MM_ANONPAGES); >> page_add_new_anon_rmap(page, vma, vmf->address); > > folio_add_new_anon-rmap(). ok, will update. > >> - lru_cache_add_inactive_or_unevictable(page, vma); >> + folio_add_lru_vma(folio, vma);