From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F11C3ABBE for ; Thu, 8 May 2025 14:47:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB0326B0082; Thu, 8 May 2025 10:47:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B60CF6B0083; Thu, 8 May 2025 10:47:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D7AF6B0085; Thu, 8 May 2025 10:47:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 81D636B0082 for ; Thu, 8 May 2025 10:47:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D9A275AD2E for ; Thu, 8 May 2025 14:47:03 +0000 (UTC) X-FDA: 83420017926.10.6718FD9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 3EA56A0009 for ; Thu, 8 May 2025 14:47:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ftc0d1+C; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746715621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3WfBLYQC3hmzGXkm7havEwwHluNTlzt6k0jnmYRuEz8=; b=2I1lgZ0uiEo5lvHnFhq18uZsLscKvbEuBAsDPUhkjQ0fBtxe4utszqPLlKvPJOPqrbO5wb xtTq5AW2UhHsQ6Sp7BqCOrrcm4Luo7Qg/Y/3VFjAvR18UCL1A97OpXnrdPYfVqxIhYq7p7 72Q8J8fLU8BY/Sk8ye3M0djRxByzc/4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ftc0d1+C; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746715621; a=rsa-sha256; cv=none; b=B3K0JMhGM+EdDpgX7MrjmjqcryC3V6BUI0LUbSxutmtCnjV0m52mO69qmFuUlP5DbvzQva BeikpRtvdiKVi3AKzoIOhX+2Q3c8Wi2rRcAlwu/UBNW4WYCu/bCPCs23KT7qSoy+WpOi9q 8P+vVCNMYfvZh6OJ6xzJrDRSeIKkmog= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746715620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3WfBLYQC3hmzGXkm7havEwwHluNTlzt6k0jnmYRuEz8=; b=Ftc0d1+C+SSdf0EsfK3QRjo/r5YVZYlQWk/QZZlLgIK55rrH1/9k4aGxZlrSt38JnBJn3x xEawOSJheRbCCz2lrRFimvDCiRW/G+lS0EmpQv67vzZ8rFCiee6Jrv8CEM6fKdrhEzNbuO cdCSm043jT3MPAU1/2Qx+Pj5BzSJWBw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-tAnz7o-TNUy8Xl6D-4N8Tw-1; Thu, 08 May 2025 10:46:59 -0400 X-MC-Unique: tAnz7o-TNUy8Xl6D-4N8Tw-1 X-Mimecast-MFC-AGG-ID: tAnz7o-TNUy8Xl6D-4N8Tw_1746715618 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442d472cf84so2285185e9.2 for ; Thu, 08 May 2025 07:46:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746715618; x=1747320418; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3WfBLYQC3hmzGXkm7havEwwHluNTlzt6k0jnmYRuEz8=; b=HrYzTwFP/47uG5hPbp1JYrVyu1rHoda7IykW0nuDCEeCQ6rsKXROmtnzayccrGyf2x H/QUTLQwoLjQHHUTIOu7ECEkGduCSG52lVBH19qV6VYOjnptdHv+42snZJS0DjdGWzI/ 9a2zPNv5I5ZMmOEvok0FhuAK5OCKAAcwIt/6QIh33zFjGLQQeCDfwCk1VZyKA0nIxqIc kCvI4TjIjWKso5ajjtXJraaWhNmZToMRauheHF4aCG6JgUfB7thF1F6bsCh0D3NGZdIn OTtFFx2Z0OHnVTJB6z9rOmX5qPdRrTShdOQ83Vfu6/DYWxqNTrLUUYJba/mtcyzXOb2e 4XLA== X-Forwarded-Encrypted: i=1; AJvYcCUwdHcZQ6q4I4YINp5lp9xIjoBrz1mh7O7q3K1oqCSBuX87SAIe60Ubokq6vgztHRvvyjaB8dW0Cw==@kvack.org X-Gm-Message-State: AOJu0YyXB4oh2qV5QcW0pFgFJ/IEMRHasGIWKBBpzMp1SiajCmnn3f3P ZgsUhZWfGvjzp4QWMFY4rtQww8U93Qu2ApswvA4bB7DRblIG3/tOuVUNK+YkvDztE2xiEHVxbKT K8mwi4+mHmgO0CJ9lQyG/OyclDSvPXmztO/FLWKDk40NE08ds X-Gm-Gg: ASbGncsGCs0aJttI4qrTBHIGiIfzbERUfzywhFSI/8oWNGjQDl7Oq0sTnkDDL7hRDlt bhEsWwKBiCJosGB5fp7qdgyxiOzRCL2vUIo9o+vBFCMG5U1lMvK72eMdsKgMcnu2Ft9AnrRAfEp PdaLOF6arrOnLiaI79C71ItGqAwATmH2ZM4fKyTF5LGuO7QbfBAbuRWAIhh0bEd0eEYT9RAK7Pq uN+XmWgcs/STbs1QjSQgY5ekHfCTUddNO35qgkf9/bnURhVk5h9CTxRr5t0C7hNtfF0/36u4Jv8 MsRWTq6/9YgA7WYbH//9QWR1vxuLFLl6PZKdXGHe27Le1QmL/fSYZMhGAbL+JCqHuSyeAjIeaGa WjVSQIRDt9DqXaBXjEbw3a92MM2mNt19DwyrTy5A= X-Received: by 2002:a05:600c:198d:b0:43d:160:cd97 with SMTP id 5b1f17b1804b1-442d034ad66mr27923615e9.25.1746715618279; Thu, 08 May 2025 07:46:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMazOFBQxOkJsC7u+4627X9ECffOM+ndlKzepZRCW/CDop3JsCzx/Dr+2gqQj4Jw/B8gOF7A== X-Received: by 2002:a05:600c:198d:b0:43d:160:cd97 with SMTP id 5b1f17b1804b1-442d034ad66mr27923245e9.25.1746715617803; Thu, 08 May 2025 07:46:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c? (p200300d82f3e590027aa5f4ab65c3d3c.dip0.t-ipconnect.de. [2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f5a4c804sm157216f8f.95.2025.05.08.07.46.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 07:46:57 -0700 (PDT) Message-ID: <8b197d87-e2a6-4f35-8f25-4d32b6e34202@redhat.com> Date: Thu, 8 May 2025 16:46:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 06/13] KVM: x86: Generalize private fault lookups to guest_memfd fault lookups To: Ackerley Tng , Sean Christopherson , Vishal Annapurve Cc: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com References: <386c1169-8292-43d1-846b-c50cbdc1bc65@redhat.com> <7e32aabe-c170-4cfc-99aa-f257d2a69364@redhat.com> <39ea3946-6683-462e-af5d-fe7d28ab7d00@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 221tjUvtF8Ut-6QER2MSG991HEzIbwB8tO7TqYsMW-g_1746715618 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: r7asic8n9ssztrshtgjyu7sr93yiki48 X-Rspamd-Queue-Id: 3EA56A0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746715621-453150 X-HE-Meta: U2FsdGVkX1/oDKAk3rsN3IbDXObYpoOx9M6kO3KeRLw7B2KVtHs2IaX0tpFbebPsl4CCbUJ/Rfeu+3GZWTRyl7oaDlrOA7pn2piW1W1XO9VqafecPKGMkFN1IkYgYisGdcomcqDSYYcAtxr3lnUI75OOoC9sB7UaT2RLpI6d4wJ9Mnd4LMzjbnsm1OF6Z7b+8tTVQbwsqde94j5V2VPyUMyvMfHNAp4GpKvWdxbxkDyg4+uV2exWl9n2LCNe/6GID8OiWwzssXAsRbc/EemA00tVyOL1eAJHpb7yVVcENzw4DZ87oZxB5RYa4aroZldvAeXMDm0b4kGbp7RIwvIlviwJnqqykdM/qunNOtiULBpRtgCIM2aVYy3WrVLe+thLDfkoEoXSf73Dw5PmI3vK+WSfkqQkIEDdD3SIiEkgwcDaiCWQernPB0ZBtmR91Xzeo55tSXLgXidWCOQjp3gBUSkGGQulQWirI6AxxPsQhQGh15MM1CMM44ps9CnvUspIqO+j1iM4e1nG4ejsY1hu7FOt9joE5YCORc9iW1zVeO1UYOCvWEhrdJHCwKhfouNNp1dR+QIHJNv590r4vDb+wfzgRivY2Xjh8jHXVIv7MT7hv4kuJ+tpbWBTnRQ1lKUflHdkiBB9PYayL9RTs6S9ESV46L/S9HvZQyie8wyY932nV1HSFdwmjACYw+jKHsU9VFPbr4jWOJWtE2HQ7/dssyl4uuDPlYXXKe74UmAAUlIXQetVoeH3SdqqF0Ln2CK5KeWQ33q3DiRh/UIlx+XKrp3G3K+Z4z7ZX5E2YJ3L/pJXWBOBKDN8xwnoMNoEyK19kMaS/Ta7y5/+Z9xgsRHVqKnv6veAeJv8KRUhgKgkPa0TZb9dOlPMrrFYREcNaVgKIpPrSHhH1wyq4fe3zXjtiYABBPpu8EyZ0JCQ/PyBThOvHs7v9UaxFLPKWMRL2ew4fZr5wjxrftIJQxrtA68 2ZCQT3CH p7CXZM+9i8Xb6hXReJoCJp9uGLNFTLe/yCHlnscExeV9/o2QQS3b2tm+vndShe9ant8kK0pg0eXwtIQSz0QXcpfCMi1XbxyPZvGb8B3SEAcjR0EEmPCj5p6mPxJztkVkBQ6l6nHRUeP7mL81r9feJ+aUgZ7QnQ8r5gfWBKzXgaGG34qIm499OyhZ90uPe2Ku1Jox+w8S/gGUvQ4Z3GF/s4s24HFcc5ogzpxyFxRX2d7VCZtGFY1F5ejvCVyKEsoeCradaJtwZFqf1ATFDAx8j6EMc0W6Qkut7N1zS4Pmx89VjD9r9y8ZLgl8D3pTJV+dYhEoZytLrU9k4Vfgs0kaM7sPb9r/I1aeXPHXHEDTIdTSs1wI6HOTmY9kb1BFqJgZwV2CXzc7t25s8Epui7rrYnBc8KRUl4odW4Tbc3IC7+c1bWLEYKoaO6Y8lS5dGawNRmisP+XOstDxxVamhV856FTcr+BolCWaeSfd/HmV4MFEX7j3eabwz9ow6i/PcyMU1QDVumnZr6am6fKcYDLkfcBm8HsVbh/cEaB+oPF5kybasAF5tuwvF2SgYlIPQg5xH5UC989rb/0LEvM2vuy4hkz5KvcpxyQF3AOoojBibbGBTA7uD3z+g1SRs9rPaW4j1Ox+FGweW/U5+MnY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> Yeah, I ignored that fact as well. So essentially, this patch should be >> mostly good for now. >> > > From here [1], these changes will make it to v9 > > + kvm_max_private_mapping_level renaming to kvm_max_gmem_mapping_level > + kvm_mmu_faultin_pfn_private renaming to kvm_mmu_faultin_pfn_gmem > >> Only kvm_mmu_hugepage_adjust() must be taught to not rely on >> fault->is_private. >> > > I think fault->is_private should contribute to determining the max > mapping level. > > By the time kvm_mmu_hugepage_adjust() is called, > > * For Coco VMs using guest_memfd only for private memory, > * fault->is_private would have been checked to align with > kvm->mem_attr_array, so > * For Coco VMs using guest_memfd for both private/shared memory, > * fault->is_private would have been checked to align with > guest_memfd's shareability > * For non-Coco VMs using guest_memfd > * fault->is_private would be false But as Sean said, looking at the code might be easier. Maybe just send the resulting diff of the patch here real quick? > > Hence fault->is_private can be relied on when calling > kvm_mmu_hugepage_adjust(). > > If fault->is_private, there will be no host userspace mapping to check, > hence in __kvm_mmu_max_mapping_level(), we should skip querying host > page tables. > > If !fault->is_private, for shared memory ranges, if the VM uses > guest_memfd only for shared memory, we should query host page tables. > > If !fault->is_private, for shared memory ranges, if the VM uses > guest_memfd for both shared/private memory, we should not query host > page tables. > > If !fault->is_private, for non-Coco VMs, we should not query host page > tables. > > I propose to rename the parameter is_private to skip_host_page_tables, > so > > - if (is_private) > + if (skip_host_page_tables) > return max_level; > > and pass > > skip_host_page_tables = fault->is_private || > kvm_gmem_memslot_supports_shared(fault->slot); > How is that better than calling it "is_gmem" / "from_gmem" etc? :) Anyhow, no strong opinion, spelling out that something is from gmem implies that we don't care about page tables. > where kvm_gmem_memslot_supports_shared() checks the inode in the memslot > for GUEST_MEMFD_FLAG_SUPPORT_SHARED. Makes sense. -- Cheers, David / dhildenb