From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF04EC77B7A for ; Fri, 19 May 2023 01:19:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66B39280007; Thu, 18 May 2023 21:19:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F44D280001; Thu, 18 May 2023 21:19:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4945B280007; Thu, 18 May 2023 21:19:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39C73280001 for ; Thu, 18 May 2023 21:19:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 13AC7120930 for ; Fri, 19 May 2023 01:19:58 +0000 (UTC) X-FDA: 80805248076.01.BAA804D Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf11.hostedemail.com (Postfix) with ESMTP id 6FB9D4000A for ; Fri, 19 May 2023 01:19:54 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684459196; a=rsa-sha256; cv=none; b=i6WPCWjd5wLz7Yu3wi/AULtC686QQ98G8ymABm6inPegz69V5oH5B6LMgg1YF8L6sZNprw 5NQHrwl16i51F+Cy3jNa/uDClN+2jJqSFlaK4g4u3edtPmd1OKkfkWASEC+GcJ5qnVIA3d /C9cN/DOzfgT19EWnTu4S9y7MiwS3pE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684459196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HR1UBLl6JAMcopg0pwOE03agA5iBS8HWTb+F26tT+nM=; b=Hjs8m07xDqpIq9t4F/H+MwNcRuErQA6TzYaDF61leTBHIIlQxKdxqKg5yxzwMPCyOLhHpY lfxRgCNp/VRY8oBpRKntqU3vCquU4L1oWMX2InjhdvrSI3hlQYWkn6hMC9cFRzOyxl342W FUdIpxbkpB2gpycsnKyofwctI7bB8TU= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QMpmw34YQz18LYw; Fri, 19 May 2023 09:15:28 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 19 May 2023 09:19:50 +0800 Message-ID: <8b102796-2a90-de0c-9889-4b8b8aa8a98d@huawei.com> Date: Fri, 19 May 2023 09:19:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static Content-Language: en-US To: Tom Rix , CC: , References: <20230518141119.927074-1-trix@redhat.com> From: Kefeng Wang In-Reply-To: <20230518141119.927074-1-trix@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6FB9D4000A X-Stat-Signature: 68y8nkz3sye9seanqprjes9pqc4ao8ke X-Rspam-User: X-HE-Tag: 1684459194-319472 X-HE-Meta: U2FsdGVkX18piLOL+pTB6hKl+H8kkEomsmidzIZ6zP1uAuuSAlPw1TJa9rZ00ihmqCONP4joCNVbCdv6lQUGzLNdgd4SmQkPk9fz+GBATiCfhuq6bC9Cuwh2DxeBu+SjyJ6zn1ZKnpUJ/EX4KkoHGw2uM24+GoFPm0NEGIqE6RS4WUJeVyzhCL2FihJfvEDfZaKqaQ/yshWHZst3VCeTfvQ0YbKBA5QiIXMrPTPWlHA2rrTswV4Cnf7lkreiOPe1jfDqfITQGfmSOPts5/gz8tbTdxPNx3b1PM7E86hVKe7ZVzDphxyVKrb5RqO28Y2eMbZSwnW1oByAZBomc4wCjKi0cZVnlzJH8oYXTnxgnlp86alJoKAhw5g/iZv0lkBVgV2KWNU5G3guOCXfLCY2LF7OIgW/7exZTRTEPpYA/5WIIsG8n0+LTHbn7v/tI68U+o1WdqPIkz7OLGwsFkwRyHeosW9NZDQIKQcgg3Oq3uotw30McOYU+++M2Fa1Ie/YqaShyfqKdtewCkPblmibOVJv5u6C42C6UydJs3kxhTpaHC/HGXhvb85jplF3Vg5rRg68JRGto62gcemyLobsQs/VDE3OloyB5Tp7C6fsIDH5DxoNnclHm9EQ3HrjWRxfEAD/IINqe+4kpJPy8hZh4LChhQPQ2YR720scf4ZkPwnmL0mTuP1+GsvgcEL+Ti1c+27F+ueQqvaytwUyqFJavvN0CNNAi/RoPkv/rSbuBLKnw9DT4LhJjHtE3+fxkw3R4eIGBtl22ANFsMZwqtBVTVnLkuNM3vrvxTWv5q36iqP/lfKSCz529CYA9m2WF9Z7pjvuta1RRNsX43pI6OeFb/bQX1mI6L3Wy9MPz8B+CQZxS5AmgMffWW244iHTRYd2Mc6uPkUrL2RodNfDKOp0yI2xwc8PJCZRz6uMzMIvr9T/SgJr5xHueaKh5vDdOKcVW2JmpUEvFbiYHP4o39C Iykz/cFb CeAPG3uiiLdhGXFTvt/Fp/YqIXKlzqG5IIm9czw/TLorp8OFMi7JQod61uHRsVguZ5x7oCRJ1/v2iZY5Fl7njIOAaS0VkJyUGsqZd6LLckdMKCKDfDFIdPm5zlem9XIPeb53uEL1YcZ9kISdWO1iFKdkBZOG3mVYU0jxzDrfAkpFIgYM4WcLDVayz+VJrnNo4kHOsOh3cU5F+DVcRpyD3ap78B8OKvdGp7L0j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/18 22:11, Tom Rix wrote: > smatch reports > mm/page_alloc.c:247:5: warning: symbol > 'sysctl_lowmem_reserve_ratio' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static > > Signed-off-by: Tom Rix > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Missing this one, Reviewed-by: Kefeng Wang > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 1023f41de2fb..8032fffa425a 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order, > * TBD: should special case ZONE_DMA32 machines here - in those we normally > * don't need any ZONE_NORMAL reservation > */ > -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = { > +static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = { > #ifdef CONFIG_ZONE_DMA > [ZONE_DMA] = 256, > #endif