From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC264C64EC4 for ; Wed, 8 Mar 2023 21:49:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D19C6B0075; Wed, 8 Mar 2023 16:49:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25AF7280002; Wed, 8 Mar 2023 16:49:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D4F6280001; Wed, 8 Mar 2023 16:49:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EAFD66B0075 for ; Wed, 8 Mar 2023 16:49:56 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3F33C0217 for ; Wed, 8 Mar 2023 21:49:56 +0000 (UTC) X-FDA: 80547073992.16.FF1ABEA Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by imf25.hostedemail.com (Postfix) with ESMTP id 93B6DA0017 for ; Wed, 8 Mar 2023 21:49:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b=CleEgxdg; spf=pass (imf25.hostedemail.com: domain of deller@gmx.de designates 212.227.15.18 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678312193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mcCVyWy+dNFAzub8GnZnx7hWXKla9PkkPd8rZ+GGdzY=; b=3OHtF2pYVT/75KTaJaFeGCj1MW+Ff56CHlWJRq3w7tYxinA/mELMkjKnLJUbvvWnyajOjn FXVkpOQsuBzg2JHO0fzFSpuXeE4OAYkG+TTjU22/9LVhQmee3FW0hFQSc+X9IY3Lq4AcIy NyyzSagprkXPotaYVP8dR25WgXYRY4Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b=CleEgxdg; spf=pass (imf25.hostedemail.com: domain of deller@gmx.de designates 212.227.15.18 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678312193; a=rsa-sha256; cv=none; b=loS2GirNXhd4AQa+dIUXzX5n/7duBsG7kq7+IUo5khHnCZLbwni90Y2XlojgGdUNWIi95l waPYrnIdTXC3UQgxSuKwtul++tT4bz1xIeq6DVPUUCcx2+T2wXqwwNqJsl22uCxkEEdC06 8WKj1BY3V10a9QK522ybovcOQOYz6bQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1678312190; i=deller@gmx.de; bh=jgoW+riUHZiigAYb6wOad0OH+0PbUiPGc0lsDkfOFMQ=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=CleEgxdgNqecF8/8u0t0m5mUC58mAQ4g7NYlPyknZ3H+4jKTKhedF8OmEE9NhCMCD 9wuhH6oaUGI0SwNlyturO96w47AmsBdZRlGx5zCiLaAFLyVpGF1/kXdTYyKG8IKj0+ JXVSS3k2yQZr24iTa6bJc/tIvr21JwjXXTL0uD04dMH/KcQx1EiH/P0ZUOHhtTZphr Q+QWal7T6dNozoOYvHdMr5YIV9kVQ3f93d3wI8/JxDEKGvPCOuInjAiueIbp+lBd3B ywaRFOLb+cJYzpOEeZcWTCeL+Dqh0d1PKCl21ENtVNh6RgQJOJ7LqzUJ1BbwpNWhHn myGADBgO6D4YQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.151.44]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MowKi-1qM4W01P5i-00qRAh; Wed, 08 Mar 2023 22:49:50 +0100 Message-ID: <8b04ebe9-4073-dcd9-8d42-1e84093e1633@gmx.de> Date: Wed, 8 Mar 2023 22:49:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Content-Language: en-US To: Arnd Bergmann , Luis Chamberlain , Baoquan He Cc: linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org, Michael Ellerman , Geert Uytterhoeven , Christoph Hellwig , Thomas Zimmermann , Christophe Leroy , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-2-bhe@redhat.com> <74915109-446a-4c1f-91bc-95dc6e3be200@app.fastmail.com> From: Helge Deller In-Reply-To: <74915109-446a-4c1f-91bc-95dc6e3be200@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:G75vQn6FwHhJiWr7cH1dVaVr5agnStDlmXhWFLJtvLq98ls7AoI RPhQq752jqv0SnRUVTDmjFt69rNbvlLOyvpORcjf2/cPbSJYQp83Sj7XbozrMYJlPsajDBX QCgzq2rXNHLuVo8f011/PeV9rWMyKXZJYVZcXc/7e4O6DauED6Ig5FyJRVsh3nJKxEd3lpc 8d/W3S1XHOGMut2uvZ8Hw== UI-OutboundReport: notjunk:1;M01:P0:613HBZ7HvUE=;hryudKXNhFIoRc2i8iFTI9XC0UK 4b6kMoUr1wHO19IjfCXiPfh3vaxOR5+X5/vvv/4Mp3QkLv8u0e3zwBxZ9JgY36ok2t2o3KYv+ PAyAkNb9MUxgxaYWqdkGAUlkLdDn8tl6LwNC8psLfK+wB4yz7+OxfgWgQJNQMEhYq26p9KbZ9 dwhbN6KR8ChJYzU76Aq7EWT6rK3Vnu9/84QXBUeGBenPcxgoQwfo+3B/S1+jEzeaqQQa5MBLV 3q7bGUtFoU3sR8j+O5Jxr021tF53TX0I0jso67pRi+mqErKs8IPEtcJyJ75AWMOKec7OV/Ll5 Vvix5I2GIMznk1dc/iWgN7OiNDyNzGHUdDJlcXopNR6pGIn73EhBDlZk6dt6ldJS/FA+L0vst ZdFOANLDG20pwy+4GFDabgrhzm9+BOXVYUzU0i9E9ZF6+fn5u75P7a/TM8XuHrJlC3elGEb6m f7/L3OGuSpehl6YriqPh1dPae4IE/cWdWvZddVOgZH4Vwdm+mS6Y2g3CmXgAd6q/P8PbXe1r1 6rK2GQRn2SUs4sFyxJWPEwCCsZVS5vw2PZhxlX78GyyPHM3lbkXzSmKmGJKCxbLoi1R6hFott jwihGtwy1sshx7XBqoOLnpUiyv3yw0zZuJut+ZbHjFBsv/q5RtU2Et5oB9RRu7kfjaGHsWdfL IuRJ7r3b9sL8CDVdLGHlanAUXJxiXqVnkQq8LLNVAb/KO/GbdqBm/T65PC+zG0ayJtLsIx7cu 6H3scyv/s8BcSSiR7U1vlaoPA47d+KcMD7kvEC2UXhqL3dPZtjzis1fxcdxKCY/EBZGqDlTp+ RKnwqwBN2raSeMEs/Z117F1mYdW0mJUOOUCJA03Tb/bnB7+/dkI96GbZCM+ggJmQUYSnDLKeN awdOQQoMISAgFIV3zvbwVoMA0ommjqq9la2X1P+vu2DnislHhxNKqWNyIgD6/dUPrgs7PfU55 igV9VBkFlFINvuA17XazpY4UIRM= X-Stat-Signature: gsrs94riz11z7xha7mhs7orbzbbg8cp3 X-Rspam-User: X-Rspamd-Queue-Id: 93B6DA0017 X-Rspamd-Server: rspam06 X-HE-Tag: 1678312193-517202 X-HE-Meta: U2FsdGVkX1/4fteKNYwpXpQoHnIYwPFLJTkLVvyzMfmkxuY0lkeU6UQtOoWh6lcntRVC3cAxKgfo0GfrYh6PRgXhBYadqa9yrQ/Lm38W3Dyrc8Anrnzcp59K8m3P2B+ZS86Igo4kucvcH9yBl63V7ZVJXCKkHV4UgTUcNQgKGjGuXOGkJ+E5cW7U1HCTvPe7mmX9aXbNyWn3SNJUn+EfHFsp/sH7XiR4p6q3mCOdSAmSHhMVYLXQLGjEkSgrO30900UCS2S+QLSztQu0FyK0eLdHUgHy86yNgkeMdIUmsH1SWPBCdAgK3cG1QHsoWl4NDQEVw9EbErCJQDcVB66OCrwfqS4xxSrz/nDk99bRXP0B8J3pakLHHfZnYPlVyjNuwNbgj2Uwg2bslB8MmOJZfy2NCWehThfbk7BvOycVDtp9Dli1YTWsK2KKIVq4jMEARZsoEmlk0UzZh366oUpILUVBm8OSjC/slmMZjz/vFDd2BLYX5G1VUWogY2JLZQvpVo+0N5gjYSSUFYX0/OZW90myhisl8SjZMLIbc+nXAnfOjozI7mU47W08HofOYE1ANrxKsatt1tPAXja14V2Ljw3q4uSKeY7ut1XxXYkR2O2D/DR98Dp3xXEzf+MPFHEGU5vn5GAKcSmXHSBnR8QmEUus1dcjr3lHzkLUeBDsC18zIPKXzm8YrHzvMysCZ/X7fcO7s2CsSUCKGapZNc7QPK6CxvjJ/9jMLnUPOqTPg8RZ+XhGaLb4cOupBEDFdHkvDRQEoSntGqsDHPB3V2U3YqE7/nYGI2yIk1JDcCeqYLxEYVprPIl1TtoNdK66G2HPGI7L9n1jHdCSJLFT7JM3o5HxC0dHRzWdgv02VI2n2KN+8Unx6qpHNFI+AhoUseMExn/131lksqUTfSEWYPvS/xd3qj5lU55gqxXlLEGOBZQigIHI955rNuhFfFgRJrPtU2B2OWUK5sX6uEL5ldt dQBBpLPD 5jq6tlyL+R77UuY5g1RaVjFp57RsqJfzmUHK9I2eGycx6nS9kmIP1hx+NqFTvcaezp70fXzss54VGuJQ5VdTDLig8QVGsAE/kvOWQ+K3qCvkpGZoRd6wDIZbYu+I+fuKJRaOazKtgFQcNx2zqoLzXrcX9E0iVe0BjmRIOsdz5Ma8667CXHXFfPeakKGJpQ+e1fmbDlWKXSb/PYhaAwUdHYZGEOs7lLigA059ofgKU5Rh5VSMP3wn+nlZntrYvVcgSAoIkTZ3+fY2ynbEwi42yoa2KENFxRMYMaxrtMkixyknZ3D+zEGp0cF+8rCka6+bXd5y8armzNKZdHNG8NDVW+1pbzMLtiYI/VeaceeLmDgS61huRbBk3HwYWyA3BA0C5e61WQEacOvyPXzBh4lLLYJ7lQsAqeXGpjljQ05VsarloyONGbzfZy/iBBvwm0Pw5k7O7ygxZoY3EG24qPIefkzpnLuxRWvkmESvMqAQRCeh5fLmPDV+sl4KgtpY29uDZpHYUyR1mmmvjfLcvafhoQIIBgqFs+3z+oL10amSh1c74+8L/Xbjvq28K+dUXTlqYk7ceVGQjiyqk4Ak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/23 22:34, Arnd Bergmann wrote: > 0On Wed, Mar 8, 2023, at 21:01, Luis Chamberlain wrote: >> On Wed, Mar 08, 2023 at 09:07:07PM +0800, Baoquan He wrote: >>> From: Arnd Bergmann >>> >>> ioremap_uc() is only meaningful on old x86-32 systems with the PAT >>> extension, and on ia64 with its slightly unconventional ioremap() >>> behavior, everywhere else this is the same as ioremap() anyway. >>> >>> Change the only driver that still references ioremap_uc() to only do s= o >>> on x86-32/ia64 in order to allow removing that interface at some >>> point in the future for the other architectures. >>> >>> On some architectures, ioremap_uc() just returns NULL, changing >>> the driver to call ioremap() means that they now have a chance >>> of working correctly. >>> >>> Signed-off-by: Arnd Bergmann >>> Signed-off-by: Baoquan He >>> Cc: Helge Deller >>> Cc: Thomas Zimmermann >>> Cc: Christophe Leroy >>> Cc: linux-fbdev@vger.kernel.org >>> Cc: dri-devel@lists.freedesktop.org >> >> Reviewed-by: Luis Chamberlain >> >> Is anyone using this driver these days? How often do fbdev drivers get >> audited to see what can be nuked? > > Geert already mentioned that this one is likely used on old > powermac systems. and the latest generation of parisc machines use it too. In addition, on parisc machines it's also important to map all io-space memory uncacheable. Since ioremap() takes care of it anyway, the ioremap_u= c() was simply referencing the call to ioremap(). Helge > I think my arm boardfile removal orphaned > some other fbdev drivers though. I removed the ones that can > no longer be enabled, but think a bunch of other ones > are still selectable but have no platform_device definition > or DT support: FB_PXA168, FB_DA8XX, FB_MX3, and MMP_FB. > > These four platforms are all still supported with DT, but > over time it gets less likely that anyone is still interested > in adding DT support to the fbdev drivers. > > Arnd